https://bugs.documentfoundation.org/show_bug.cgi?id=96099
Stephan Bergmann <sberg...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
CC| |sberg...@redhat.com
--- Comment #68 from Stephan Bergmann <sberg...@redhat.com> ---
Setting to RESOLVED/FIXED as per the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2018-June/080462.html>
"Close EasyHack tdf#96099 'Reduce number of typedefs used for trivial container
types'?":
"While there are certainly the obviously silly, use-once cases like
typedef std::vector<int> IntVector;
IntVector v = ...;
there are also cases where such a typedef introduces domain-specific vocabulary
into a (larger) portion of the code (e.g., see removal of such typedefs in
<https://cgit.freedesktop.org/libreoffice/core/commit?id=89e0663c55f7f1763536a345d63111115c71ef26>
'tdf#96099 fix trival typedefs, Path to std::vector<OUString>' in configmgr and
<https://cgit.freedesktop.org/libreoffice/core/commit?id=5437eb15ad3975b11c6eefe77dfd6687e0e73f81>
'tdf#96099 Remove trivial std::map typedefs in [cd]*' removing the Dependencies
typedef from codemaker/source/javamaker/javatype.cxx). In such cases, there is
always a tension between keeping the code simple (in the sense of easily
understood by using well-chosen names) and keeping the code simple (by not
introducing unnecessary abstractions), and finding the right balance there is
likely not an easy hack.
"(Tor's initial description,
<https://bugs.documentfoundation.org/show_bug.cgi?id=96099#c0>, already warned
about that, but it's not clear to me that that warning has always been taken
into account adequately.)"
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
