https://bugs.documentfoundation.org/show_bug.cgi?id=120301
Justin L <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Assignee|[email protected] |[email protected]
|desktop.org |
Keywords| |bibisected, bisected,
| |filter:ooxml, regression
Ever confirmed|0 |1
CC| |[email protected]
--- Comment #1 from Justin L <[email protected]> ---
The faulty commit from 2010
commit 7a5084f1acacb0858588d4d0c82651e47ca9914f
Author: Daniel Rentz
Date: Mon Feb 7 17:18:11 2011 +0100
dr78: rework of stream handling, improve handling of very large streams
(prevent loading entire stream into array or string, esp. dumper and VML
import), full support of XComponentContext
diff --git a/oox/source/vml/vmlinputstream.cxx
b/oox/source/vml/vmlinputstream.cxx
--- a/oox/source/vml/vmlinputstream.cxx
+++ b/oox/source/vml/vmlinputstream.cxx
@@ -56,5 +58,5 @@
inline bool lclIsWhiteSpace( sal_Char cChar )
{
- return (cChar == ' ') || (cChar == '\t') || (cChar == '\n') || (cChar ==
'\r');
+ return cChar < 32;
}
Hmm, the space character *is* 32, so should be cChar <= 32
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
