https://bugs.freedesktop.org/show_bug.cgi?id=54940

--- Comment #28 from Jean-Baptiste Faure <jbf.fa...@sud-ouest.org> ---
Hi Michael, Miguel Angel, Markus,

I did several tests after having reverted locally (in my own build) the commit
9edb6ba992ad2ef092996903d775df5313613bee as suggested by Michael. Precisely, I
reverted this commit after this one : f4b412ebd57016823dde50c5d41bdc39337b6b74

I did my tests accordingly to the following workflow:
1/ use Format > CF > CF to add new CF or modify existing CF
2/ use Format > CF > Manage to have a global view of existing CF and, if
needed, choose one to be modified.

My results:
- Format > CF > CF works as expected as long as you define CF for non
overlapping ranges

- Format > CF > Manage shows the ranges with CF as they have been defined in
Format > CF > CF: 
   * the formula is shown for the cell in the left corner of the range
   * if you select a range in the list and hit the Edit button, you get a
dialog
     with title "Conditional Formating for <range>" and the formulas are shown
     for the cell in the left corner of the range
   * if you hit the Add button in the Edit dialog, you can add a new 
     condition and if you define this new condition for the cell in the left
     corner of the range, then the condition is propagated over the range, as 
     expected.

So, for me, without the commit 9edb6ba992ad2ef092996903d775df5313613bee, these
dialogs work as a standard user would expect :-) So I propose to revert this
commit in the master if it does not play any role in other area.

I think this change should be backported to 3.6 but I propose to wait for that
that we have a daily build of the master that Miguel Angel and other interested
peoples can test. 

Remark: during my tests I encountered 2 issues, perhaps independent, I do not
know (If it is the case I can file new bug reports):
#1: the changes done in Format > CF > CF > Edit does not trigger the flag
"modified file"
#2: sometimes, changes like condition removed, seems not taken into account
(view not updated) until you save and reload the file, or go downstream in the
current sheet and go back.


I am very happy with this change. Thanks a lot for that. I am sure we are on
the way to a CF manager far better than we have in previous versions. The
Manage dialog is a clear plus for me and, only for it, I wouldn't go back to
old version. Even if some UI improvements, like resizable windows and range
pickers, are needed (from my point of view), but that's to be discussed
elsewhere.

Thank you very much for your patience. :-)

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to