https://bugs.documentfoundation.org/show_bug.cgi?id=129552
Bug ID: 129552
Summary: LO 6.4: form controls flicker, high cpu usage
Product: LibreOffice
Version: 6.4.0.0.beta1+
Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
Keywords: bibisected, bisected, regression
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: oliver.brinz...@gmx.de
Blocks: 107742, 128256
Created attachment 156732
--> https://bugs.documentfoundation.org/attachment.cgi?id=156732&action=edit
flicker demo file
The "form controls flicker, high cpu usage" problem seems to be back.
steps to reproduce:
- open attached spreadsheet
-> radio controls will flicker
reproducible with:
Version: 6.4.0.1 (x64)
Build-ID: 1b6477b31f0334bd8620a96f0aeeb449b587be9f
CPU-Threads: 4; BS: Windows 10.0 Build 18363; UI-Render: Standard; VCL: win;
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc:
but *not* reproducible with:
Version: 6.3.4.2 (x64)
Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win;
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc:
this seems to have started with:
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=5b51aa12e8ebfa894ecfdd0c8c9004aa99e6f46d
commit 5b51aa12e8ebfa894ecfdd0c8c9004aa99e6f46d [log]
author Miklos Vajna <vmik...@collabora.com> Tue Mar 26 11:36:37 2019 +0100
committer Miklos Vajna <vmik...@collabora.com> Wed Mar 27 16:07:59 2019 +0100
tree 22579d695d43818ef802168ef97279c40114b6d9
parent 5f8aaa09d3d7fbf10446b085f9ace83c074a65c3 [diff]
tdf#123505 svx: fix invalidation loop caused by special form control geometry
Regression from commit d464d505fbf6e53a38afdd3661d320fac8c760d6
(Refactor calc non-linear ViewToDevice transform, 2018-10-12), the
problem was that the opengl menu was never painted from the starved idle
handler as a paint-invalidation loop starved the main loop.
ScGridWindow::Paint() called vcl::Window::ImplPosSizeWindow() for the
form control of the bugdoc, which triggered an invalidation -> paint ->
start again.
Checking what adjustControlGeometry_throw() did, the result of the
transformed points are quite close to each other, but not equivalent:
debug:18521:18521: adjustControlGeometry_throw: aTopLeft before transformation
is (1773,426)
debug:18521:18521: adjustControlGeometry_throw: aTopLeft after transformation
is (64.935,16.0382)
debug:18521:18521: adjustControlGeometry_throw: aPaintRectPixel is
952x586@(64,16)
If we round, rather than truncate, then the size of the control is
always the same, so no actual resize and invalidation happens during
paint.
/cygdrive/d/sources/bibisect/bibisect-win32-6.3
$ git bisect good
2ec3f0b0a0566c0fcb165d022e153a2dc2905db7 is the first bad commit
commit 2ec3f0b0a0566c0fcb165d022e153a2dc2905db7
Author: Norbert Thiebaud <nthieb...@gmail.com>
Date: Wed Mar 27 08:54:42 2019 -0700
source sha:5b51aa12e8ebfa894ecfdd0c8c9004aa99e6f46d
source sha:5b51aa12e8ebfa894ecfdd0c8c9004aa99e6f46d
:040000 040000 adb50067ca87bb43313b51e49c73a747f4b89bcb
47f7cbc985a20111ffc35c747cf529ff0dfb2950 M instdir
/cygdrive/d/sources/bibisect/bibisect-win32-6.3
$ git bisect log
# bad: [18f926e8e18b3d855c2f79ef279febbeb846b8cd] source
sha:13152ad88b24cadc836a829b4424a72a152ca9b1
# good: [ea94942caaf195b8d8b2d5c2abb523359ab390e7] source
sha:a20a2d7e0d28658f2d9089da076961a599833a28
git bisect start 'master' 'oldest'
# good: [3aea60569b9190400409ebb93f0a5d323b6fc5d4] source
sha:47ce4b87d8a13fc340794ffd9a10d5bd6a15e644
git bisect good 3aea60569b9190400409ebb93f0a5d323b6fc5d4
# bad: [3b794d71dd796e467baef082c140bdc77c69c979] source
sha:47d25dc5abe000ce751cb1e4dbd1f85f7198ca05
git bisect bad 3b794d71dd796e467baef082c140bdc77c69c979
# good: [8adbffa485cdd6d5e13106e5f55e70249f46a4f6] source
sha:15e9e6d12aa2d49e114ec0cf8326f2264ccf2640
git bisect good 8adbffa485cdd6d5e13106e5f55e70249f46a4f6
# bad: [446d84046fe885e09f7cb71061f6c80ff83137e3] source
sha:5bd1caf14c8e297db229e9060a584386247e62b1
git bisect bad 446d84046fe885e09f7cb71061f6c80ff83137e3
# bad: [290c14249daec35d65309db03bbb2d8dd9577869] source
sha:a67125aa5c5ef8f2a19dcbcad778cd66a304761b
git bisect bad 290c14249daec35d65309db03bbb2d8dd9577869
# bad: [8893400736b4e45e29c30cf30ca8537d5f7688d4] source
sha:92ce72a4731ad468f5928efd9da7fe66bfdb08ea
git bisect bad 8893400736b4e45e29c30cf30ca8537d5f7688d4
# good: [3d66d55d73ab46e044cfa3f0f113ea7fa16db0b7] source
sha:93f0b6143822d171caf6cd3db10d4730e276dad9
git bisect good 3d66d55d73ab46e044cfa3f0f113ea7fa16db0b7
# bad: [e838c9ebf7cac8762d7fb143622bb76797c3e56c] source
sha:3dfe2ce66ac220c8f137730d7146bc334c1859be
git bisect bad e838c9ebf7cac8762d7fb143622bb76797c3e56c
# bad: [a8f56f90bcebbdfbfe8248b2fe981737316af0f6] source
sha:f897e80d063436be07356049f595efe5afb04859
git bisect bad a8f56f90bcebbdfbfe8248b2fe981737316af0f6
# bad: [f400ff1767df5003a4ce7b182d12df0162efeedf] source
sha:28eab5de358631758315a3581e860d6ef533259a
git bisect bad f400ff1767df5003a4ce7b182d12df0162efeedf
# bad: [52f6a8fc06840d36b1ac6ab8cb24ac9aa7db7ba0] source
sha:58b3982a15eb55f2d4c364d256f37970e1390392
git bisect bad 52f6a8fc06840d36b1ac6ab8cb24ac9aa7db7ba0
# bad: [2ec3f0b0a0566c0fcb165d022e153a2dc2905db7] source
sha:5b51aa12e8ebfa894ecfdd0c8c9004aa99e6f46d
git bisect bad 2ec3f0b0a0566c0fcb165d022e153a2dc2905db7
# good: [5c0ceb2e6e66d4a97f0925ab4e9f8165fee0a676] source
sha:5f8aaa09d3d7fbf10446b085f9ace83c074a65c3
git bisect good 5c0ceb2e6e66d4a97f0925ab4e9f8165fee0a676
# first bad commit: [2ec3f0b0a0566c0fcb165d022e153a2dc2905db7] source
sha:5b51aa12e8ebfa894ecfdd0c8c9004aa99e6f46d
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=107742
[Bug 107742] [META] Form control bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=128256
[Bug 128256] [META] Regressions introduced by Refactor calc non-linear
ViewToDevice transform
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
