https://bugs.documentfoundation.org/show_bug.cgi?id=116412

Julien Nabet <serval2...@yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |d.ostrov...@gmx.de,
                   |                            |glo...@fbihome.de,
                   |                            |michael.st...@allotropia.de
                   |                            |, serval2...@yahoo.fr

--- Comment #9 from Julien Nabet <serval2...@yahoo.fr> ---
I could make "import bz2" work with these changes:
diff --git a/external/python3/ExternalPackage_python3.mk
b/external/python3/ExternalPackage_python3.mk
index faddf06fc36a..cadb3bf3e9f8 100644
--- a/external/python3/ExternalPackage_python3.mk
+++ b/external/python3/ExternalPackage_python3.mk
@@ -64,6 +64,7 @@ $(eval $(call
gb_ExternalPackage_add_files,python3,$(LIBO_BIN_FOLDER)/python-cor
        LO_lib/_bisect.$(python3_EXTENSION_MODULE_SUFFIX).so \
        LO_lib/_blake2.$(python3_EXTENSION_MODULE_SUFFIX).so \
        LO_lib/cmath.$(python3_EXTENSION_MODULE_SUFFIX).so \
+       LO_lib/_bz2.$(python3_EXTENSION_MODULE_SUFFIX).so \
        LO_lib/_codecs_cn.$(python3_EXTENSION_MODULE_SUFFIX).so \
        LO_lib/_codecs_hk.$(python3_EXTENSION_MODULE_SUFFIX).so \
        LO_lib/_codecs_iso2022.$(python3_EXTENSION_MODULE_SUFFIX).so \
diff --git a/external/python3/UnpackedTarball_python3.mk
b/external/python3/UnpackedTarball_python3.mk
index 31b6a166e6ae..68490e2e9fee 100644
--- a/external/python3/UnpackedTarball_python3.mk
+++ b/external/python3/UnpackedTarball_python3.mk
@@ -23,7 +23,6 @@ $(eval $(call gb_UnpackedTarball_add_patches,python3,\
        external/python3/python-3.3.0-darwin.patch.1 \
        external/python3/python-3.8-msvc-sdk.patch.1 \
        external/python3/python-3.7.6-msvc-ssl.patch.1 \
-       external/python3/python-3.5.4-msvc-disable.patch.1 \
        external/python3/ubsan.patch.0 \
        external/python3/python-3.5.tweak.strip.soabi.patch \
        external/python3/darwin.patch.0 \

This last part disables the patch which disables (double negation so I should
say "enables") a lot of libs from Python

I suppose putting minimum allows to provide lighter packages but if Python is
provided for macro scripting, I can understand the need of full Python, not
just core of it.
Also, if people have already installed Python, it's a pity we force to include
it again in LO.
=> In brief, I don't have strong opinion about just putting minimum libs in
Python embedded in LO.

Perhaps the start would be what was the goal to include Python at the first
time? macro scripting? LO QA tests in Python instead of Java? Other?
If people could provide pros and cons or perhaps should it be discussed in ESC?

Jan-Marek/Michael/David: any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to