https://bugs.documentfoundation.org/show_bug.cgi?id=147409

Regina Henschel <rb.hensc...@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de
                   |desktop.org                 |

--- Comment #5 from Regina Henschel <rb.hensc...@t-online.de> ---
Both have a wrong construction for the toggle:

css::uno::Any* pAny = rGeometryItem.GetPropertyValueByName( "TextPath",
"SameLetterHeights" );
if( pAny )
{
    bool bOn = false;
   (*pAny) >>= bOn;
    bOn = !bOn;
   (*pAny) <<= bOn;
}

Making the change into the target of pAny changes the rGeometryItem, but does
not trigger InvalidateHash(). So the rGeometryItem has still aHashState
"Valid", but the hash was not recalculated and therefore it is wrong.

Instead a Set-method of rGeometryItem has to be used. Something like

css::uno::Any* pAny = rGeometryItem.GetPropertyValueByName( "TextPath",
"SameLetterHeights" );
if( pAny )
{
     bool bOn = false;
     (*pAny) >>= bOn;
     bOn = !bOn;
     css::beans::PropertyValue aPropValue;
     aPropValue.Name = "SameLetterHeights";
     aPropValue.Value <<= bOn;
     rGeometryItem.SetPropertyValue("TextPath", aPropValue);
}

I'll make a patch, but after https://gerrit.libreoffice.org/c/core/+/124337 is
submitted. Otherwise it might generate a merge conflict.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to