https://bugs.documentfoundation.org/show_bug.cgi?id=145843

--- Comment #32 from Patrick Luby <plub...@neooffice.org> ---
(In reply to Telesto from comment #30)
> 
> Whole problem, I can create the issue with a few steps.. somehow, but not
> everybody else does. 
> 
> Comment 8 works pretty reliable for me
> 
> Alternative
> 1. Open Impress from Start Center
> 2. Double click BeeHive template
> 3. LibreOffice -> About Window -> Press Copy About
> 4. Close the dialog
> 5. Enter Click to add title
> 6. CMD+V
> 7. LibreOffice -> About Window -> Press Copy about -> Might crash here
> 8. Close the dialog
> 9. Go to slide 2
> 10. CMD+V
> 11. LibreOffice -> About Window -> Press Copy about -> Crash
> 
> Alternative -> even less predictable
> 1. Open Writer from Start Center
> 2. LibreOffice -> Preferences -> View
> 3. Uncheck Use Skia for all rendering
> 4. Hoover over the Apply/ OK buttons.. Press Apply button. Close the restart
> button. Press Cancel in the Preference dialog 
> 
> It appears Window related, the dialogs appear like tip of the day/ template
> manager/ about window/ preference the often it happens.
> 
> But will there some kind of timing element.. 
> 
> Sidenote: the patch attachment 181096 [details] authored by Luboš Luňák -
> received by email - solves the issue. However a different patch got pushed
> at comment 24 for unknown reasons

Thank you for the steps. I can now reproduce the crash using your first
alternative.

I now understand why the patch in attachment 181096 was not used: it makes a
copy of the bitmap in memory. It fixes the crashing, but it would require a lot
more memory and frequently copying of bitmaps.

I added the debug patch in attachment 184138 and I noticed the following debug
output immediately before the crash:

debug:2178:56744: XXX:0x600003e71e00 709x464*2R::1418x928::2::244x232@(399,156)
798,312,488,464::5672::6 2::6 2
debug:2178:56744: XXX:0x600003e71e00 709x464*2R::1418x928::2::200x145@(509,319)
1018,638,400,290::5672::6 2::6 22022-12-14 08:57:10.358900-0500
soffice[2178:56744] [org.libreoffice.script] copy_read_only: vm_copy failed:
status 1.

Note that the first line doesn't crash and the second one crashes. Both are
taking a small subarea of the same bitmap. The difference is that the subarea
in the second one aligns with the bottom, right edges of the bitmap.

>From the above, I think that Luboš Luňák's "HACK for tdf#145843" in
vcl/skia/osx/gdiimpl.cxx now makes sense to me. His fix is just missing cases
like this.

I will see if I am able to expand his fix to handle this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to