https://bugs.documentfoundation.org/show_bug.cgi?id=152591
Bug ID: 152591
Summary: Deprecate css::text::XTextDocument::reformat(), and
document that it does nothing
Product: LibreOffice
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: sdk
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: mikekagan...@hotmail.com
CC: sberg...@redhat.com
css::text::XTextDocument::reformat is documented [1] to "reformat the contents
of the document". However, the implementation of the method [2] does nothing
except for boilerplate check that the object is still valid. This has been so
since the initial import (commit 7b0b5cdfeed656b279bc32cd929630d5fc25878b,
2000-09-18).
css::text::XTextDocument inherits from css::frame::XModel; and the latter has a
'refresh' method [3], which implementation in SwXTextDocument calls
SwViewShell::Reformat [4].
It seems that (a) the original idea of css::text::XTextDocument::reformat is to
do the same as what css::frame::XModel::refresh does; and (b) that it makes no
sense to implement it now, and a better fix wuld be to just deprecate it and
update its documentation.
[1]
https://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/text/XTextDocument.idl?r=5687eba4#38
[2]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/uno/unotxdoc.cxx?r=c2bcbd36#462
[3]
https://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/xforms/XModel.idl?r=5687eba4#49
[4]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/uno/unotxdoc.cxx?r=c2bcbd36#2172
--
You are receiving this mail because:
You are the assignee for the bug.
