https://bugs.documentfoundation.org/show_bug.cgi?id=145936
Caolán McNamara <caol...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Regression By|Caolán McNamara |
--- Comment #8 from Caolán McNamara <caol...@redhat.com> ---
caolanm->raal: I think that bisect doesn't really help. In the version without
that fix add an initial set of adding a single character to the document before
following the other steps (this sets the document to "modified"). Then after
that, format page, and set height to 5cm, and ok and the same behavior is seen
without that commit which just faithfully recognized that there was a
modification done to the document by changing a page style.
If I bisect with that extra step then I get the result of:
commit c927ea4c5d8a9ede979e17c09c2303854ccdebec
Author: Muhammet Kara <muhammet.k...@collabora.com>
Date: Mon Jun 24 01:46:42 2019 +0300
Sync page orientation of Endnote page
Description:
When changing the default page style to have a different orientation,
end-notes are placed on a page with a custom ‘Endnote’ page style.
This style does not inherit its orientation from the default style.
Repro:
Create a blank document, insert→End Note, Format→Page in the first page,
select the Page tab, and alter the Orientation to Landscape, ‘Ok’.
The End-note page should update its orientation too.
NB. If the Endnote page style is manually set to a different value
in a document template it will remain in the selected orientation.
After this patch, Default style and the Endnote style have their
orientations synced after each run of the Format > Page dialog.
Ideally, this should be solved by resolving tdf#41316 on master:
Page styles should support hierarchical parent-child relationships
(like paragraph or character styles)
Change-Id: I255b470d1aebb897f50a4a74b8678b771ffbab28
Reviewed-on: https://gerrit.libreoffice.org/79869
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
Reviewed-by: Andras Timar <andras.ti...@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/82173
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.k...@collabora.com>
If I go back to the oldest version I have, and manually toggle the "endnote"
page style from portrait to landscape then I think I get the odd behavior too.
So the change of the endnote orientation along with the default page style
orientation was deliberate, and not in itself a bad idea, but the result is
unsatisfactory I guess.
One possible tweak might be to only do the "syncEndnoteOrientation" if the
default page style paper size matches the endnote page style paper size?
--
You are receiving this mail because:
You are the assignee for the bug.
