https://bugs.documentfoundation.org/show_bug.cgi?id=156776

--- Comment #17 from Lionel Elie Mamane <lio...@mamane.lu> ---
(In reply to prrvchr from comment #16)
> (In reply to Lionel Elie Mamane from comment #15)
>> I think it would be nice to do the "resynchronisation" in one go rather than
>> adding the new member functions one by one as we keep "discovering" the need
>> for them.

> I am ready to make all the necessary changes.
> If I understood you correctly, this would be done through a new interface
> com.sun.star.sdbc.XConnection2 inheriting from the interface
> com.sun.star.sdbc.XConnection and having the following methods:

> - string getSchema()
> - void setSchema(string Schema)

If these are the only missing in LibreOffice's css::sdbc::XConnection when
compared to Java's java.sql.Connection, then yes. Else, please add in one go
all missing ones in the new css::sdbc::XConnection2

Thanks!

> Maybe we should also consider:

> - Any setSavepoint(string Name)
> - void releaseSavepoint(Any Savepoint)
> - void rollbackToSavepoint(Any Savepoint)

Well, you give examples yourself of other things missing, so please add them
all. My point was to _not_ only add "get/setSchema" because we need them now,
and then in 3 months or 3 years, we want set/release/rollbackToSavepoint and we
create css::sdbc::XConnection3 for those. I would prefer we create _now_
css::sdbc::XConnection2 with get/setSchema, set/release/rollbackToSavepoint and
anything else missing in LibreOffice's SDBC(X) when compared to the last
version of JDBC (according to Wikipedia that's JDBC 4.3 present since Java 9,
and wouldn't have changed since then in newer versions of Java).

> 
> And I also thought of adding access to the underlying database logging with:
> - com.sun.star.logger.XLogger getLogger()
> Or maybe this should be added to the com.sun.star.sdbc/x.XDriver as it is
> done with Java ?
> 
> Surely I forgot things?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to