https://bugs.documentfoundation.org/show_bug.cgi?id=153689
Michael Stahl (allotropia) <michael.st...@allotropia.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kelem...@ubuntu.com
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Michael Stahl (allotropia) <michael.st...@allotropia.de> ---
seems to be fixed.
although these pathological numbers of footnotes in tables probably still
aren't going to be very reliable... see other docs like the ones in the commit
message...
commit c303981cfd95ce1c3881366023d5495ae2edce97
Author: Michael Stahl <michael.st...@allotropia.de>
AuthorDate: Wed Aug 23 15:50:59 2023 +0200
Commit: Michael Stahl <michael.st...@allotropia.de>
CommitDate: Thu Aug 24 12:43:25 2023 +0200
tdf#156724 sw: layout: fix tables not splitting due to footnotes
differently
Revert commit 610c6f02b11b4b4c555a78b0feb2a1eb35159e39 and
and 61a78a523a6131ff98b5d846368e5626fe58d99c instead do the
opposite: never calc content frames in FormatLayout().
There were a few cases where documents looked worse with the fix, such
as the somewhat pathological tdf120139-1.odt and tdf124474-1.odt, but
typically these went from a bad layout to a worse layout, e.g.
--convert-to pdf tdf120139-1.odt went from 11 minutes to 33 minutes
(dbgutil) with twice as many more half-empty pages.
Worse is that the previous fix appears to prevent tdf#128437 from
working.
It should also be less risky to never calc content frames in
FormatLayout(), because with IsPaintLocked() check that used to be done
led to doing it only for pages which were visible when loading the
document, so any regressions with this new approach would appear on few
pages at the start of the document, instead of many pages at the end.
Note that without the previous commit, this would cause
* CppunitTest_sw_core_layout CPPUNIT_TEST_NAME="testTablePrintAreaLeft"
to fail
* tdf#137523 SwLayoutWriter3 testTdf137523 to fail,
*only* on the last text frame
This also appears to fix tdf#125749.
Change-Id: I3d72f8e9d2b89aa3738e554308fd9dce12e92238
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155988
Tested-by: Michael Stahl <michael.st...@allotropia.de>
Reviewed-by: Michael Stahl <michael.st...@allotropia.de>
--
You are receiving this mail because:
You are the assignee for the bug.
