https://bugs.documentfoundation.org/show_bug.cgi?id=157159

Stéphane Guillou (stragu) <stephane.guil...@libreoffice.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bibisected, bisected,
                   |                            |regression
      Regression By|                            |Noel Grandin
            Summary|Text in comments has a      |Text in comments has a
                   |white highlight depending   |white highlight /
                   |on Hardware Acceleration    |background
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
         Whiteboard|                            |target:24.2.0
                 CC|                            |momonas...@gmail.com,
                   |                            |noelgran...@gmail.com,
                   |                            |stephane.guillou@libreoffic
                   |                            |e.org
            Version|7.4.0.0 alpha0+             |7.6.0.0 alpha1+

--- Comment #11 from Stéphane Guillou (stragu) 
<stephane.guil...@libreoffice.org> ---
For me, this started in 7.6. I can see that Rainer is seeing something
different, but I'll stick to what I think Faisal and [redacted] are seeing.
(Rainer, maybe you should add your findings to bug 146516.)

Bibisected with linux-64-7.6 repo to first bad commit
dcdb8e6aaf9b50159b151afe5ac8b2b3b61c1142 with points to core commit:

commit  89b1d41e0d2cd16a4088e095de0f673807c4adac
author  Noel Grandin Thu Jan 05 12:32:32 2023 +0200
committer       Noel Grandin Fri Jan 06 11:34:20 2023 +0000
use std::optional for SALCOLOR_NONE
instead of re-using an actual real color value, because it will totally
not work when I convert vcl to use alpha instead of transparency
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145075

... but then, interestingly, got fixed in 24.2 with the implementation of
comment styles by Maxim:

commit  9474ff4cc0abbd16f91ea582050c2332bdad88a3
author  Maxim Monastirsky Wed May 31 21:59:06 2023 +0300
committer       Maxim Monastirsky Thu Jun 15 22:37:16 2023 +0200
tdf#103064 editeng: fix handling of char highlighting
Transparency should be set to false if a color is present, but not
with COL_TRANSPARENT. Compare with what is done for shape text in
VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153107

Good to see this fixed in master, but is it possible to get a fix for 7.6 as
well somehow?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to