On Mon, Oct 11, 2010 at 4:48 AM, Noel Power <nopo...@novell.com> wrote: > Hi Ruben, > > Thanks for hacking LibreOffice and thanks for the patch, it's mostly > committed, > On Sun, 2010-10-10 at 13:10 +0200, Rubén Jáñez wrote: >> This patch removes bogus comments found in Base. > just be careful of removing any comment that reference openoffice > issuezilla bugs ( there is useful context there ) e.g. something like > "// #i15113#" the '#i' is normally indicative of an issuezilla bug > number. E.g. the previous example would have info like > http://qa.openoffice.org/issues/show_bug.cgi?id=15113 >> I've added some "GERMAN comments" to mark some comments because I don't know >> german > Ah nice idea but unfortunately I think it could really annoy others who > are already mid-way creating patches ( this would break their context ) > Perhaps others might have a different opinion but anyway I didn't > include those hunks in the commit.
FWIW, that is why I didn't merge that one this WE. I agree with you, but I wasn't sure... Norbert > > Anyway thanks again for the patch > ( > http://cgit.freedesktop.org/libreoffice/base/commit/?id=1362e62f0c9510d74e853ec26ff303b0223817f7 > ) > > Noel > > _______________________________________________ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice