Hey Jordan, On Thu, 2010-12-02 at 13:29 -0600, Jordan Ayers wrote: > I'm not a perl expert, just have had to learn it on the job over > the last few years. Since I'm also not very familiar with all the > details the installer is handling, I've been focusing on incremental > cleanup items. (Although in this case, I suspect that re-deriving the > program would be faster, if someone had enough familiarity with the > install process to do so.)
I think agree with you about the latter - re-deriving it is almost certainly the way to get the speed up to snuff. I think also, though, that would be a very hard task with the code in its current state - the incremental clean-up would actually help simplify things a lot and actually make that more fundamental task easier (whether it was re-derived into Perl or some other language) by exposing the logic that matters. I think pretty much all of installer::converter could benefit from the type of cleanup you already submitted, although better would be removing the use of it entirely. Things like installer::remover look extremely cookie-cutter, and then there's stuff like calls out to shell for chmod/mkdir etc. when there's already installer::systemactions. It might be worth trying to break this down into specific refactorings which can be pushed bit by bit; it worries me that there's a lot of subtle stuff going on that's not necessarily deliberate and there's some stuff in there that looks pretty fragile as a result :/ Maybe it deserves a wiki page on its own? Cheers Alex. -- This message was scanned by Better Hosted and is believed to be clean. http://www.betterhosted.com _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
