More simple cpp check clean ups.
Andy
>From ddd64b735bc5dfecb8a7a2838072003e2b36bb26 Mon Sep 17 00:00:00 2001
From: Andy Holder <andy.m.hol...@gmail.com>
Date: Sat, 29 Jan 2011 16:55:22 +0000
Subject: [PATCH] cppcheck: Prefer prefix ++/-- operators
---
vcl/win/source/gdi/salgdi3.cxx | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vcl/win/source/gdi/salgdi3.cxx b/vcl/win/source/gdi/salgdi3.cxx
index 5f005ad..93fa079 100644
--- a/vcl/win/source/gdi/salgdi3.cxx
+++ b/vcl/win/source/gdi/salgdi3.cxx
@@ -213,7 +213,7 @@ ImplFontAttrCache::~ImplFontAttrCache()
aCacheFile.WriteByteStringLine( rDFA.maStyleName, RTL_TEXTENCODING_UTF8 );
- aIter++;
+ ++aIter;
}
// EOF Marker
String aEmptyStr;
--
1.7.3.5
>From 750415f3ae3d59204bb120bf72ac3bf34d2a8af0 Mon Sep 17 00:00:00 2001
From: Andy Holder <andy.m.hol...@gmail.com>
Date: Sat, 29 Jan 2011 17:37:53 +0000
Subject: [PATCH] cppcheck: remove unused variable
---
sw/source/ui/dbui/mmaddressblockpage.cxx | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sw/source/ui/dbui/mmaddressblockpage.cxx b/sw/source/ui/dbui/mmaddressblockpage.cxx
index 528a349..617cc14 100644
--- a/sw/source/ui/dbui/mmaddressblockpage.cxx
+++ b/sw/source/ui/dbui/mmaddressblockpage.cxx
@@ -1067,8 +1067,6 @@ SwAssignFieldsControl::SwAssignFieldsControl(
m_aPreviews.push_back(pNewPreview);
}
ListBox* pBottomBox = m_aMatches[rHeaders.Count() -1];
- long nYBottom = pBottomBox->GetPosPixel().Y();
- nYBottom += pBottomBox->GetDropDownPosSizePixel().GetHeight();
m_aVScroll.SetRange(Range(0, rHeaders.Count()));
m_aVScroll.SetPageSize((aOutputSize.Height() - nHBHeight - m_nLBStartTopPos)/ m_nYOffset);
m_aVScroll.EnableDrag();
--
1.7.3.5
>From 98714b55983e8b8258855bc0fd79aea446864d51 Mon Sep 17 00:00:00 2001
From: Andy Holder <andy.m.hol...@gmail.com>
Date: Sat, 29 Jan 2011 17:23:44 +0000
Subject: [PATCH] cppcheck: variable never used
---
.../source/win32/customactions/reg64/reg64.cxx | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/setup_native/source/win32/customactions/reg64/reg64.cxx b/setup_native/source/win32/customactions/reg64/reg64.cxx
index ea05475..2eb3f7f 100644
--- a/setup_native/source/win32/customactions/reg64/reg64.cxx
+++ b/setup_native/source/win32/customactions/reg64/reg64.cxx
@@ -207,7 +207,6 @@ bool IsInstallForAllUsers( MSIHANDLE hMSI )
wchar_t* GetBasisInstallLocation( MSIHANDLE hMSI )
{
OutputDebugStringFormat(L"GetBasisInstallLocation - START\n" );
- bool bResult = FALSE;
wchar_t* pVal = NULL;
GetMsiProp( hMSI, L"INSTALLLOCATION", &pVal);
--
1.7.3.5
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
