On Tue, Mar 15, 2011 at 01:10:58PM +0100, Xisco Faulí wrote: > Hello, > > > It's the first time I do it so I searched for previous commits in order to > get a referent. i couldn't find any example for String.AssignAscii so I > replace it with OUStringBuffer.appendAscii.
Yeah, that is good. I only added RTL_CONSTASCII_STRINGPARAM around string literals. I also replaced occurrences of aStr.equals(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("foo"))) by aStr.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("foo")) (similarly for equalsIgnoreAsciiCase and equalsIgnoreAsciiCaseAsciiL) and aStr.getLen() in conditions by !aStr.isEmpty(). D. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice