> The attached patch fixes lots of cppcheck warnings in the components > repository.
Thanks! All of those are good points. Just small nitpicking (cui/source/dialogs/thesdlg.cxx) -- I did the following change to your patch: - (aLookUpHistory.empty() == 0 || aLookUpText != aLookUpHistory.top())) + (aLookUpHistory.empty() || aLookUpText != aLookUpHistory.top())) ie. it is OK to use just empty(), as aLookUpHistory is std::stack and this call returns bool. No need to additionally compare it to zero. > By the way, did anybody review my latest pyuno patch update? Or am I not > patient enough :) Nope, or so it seems. As a person in charge of integrating patches this week, I didn't spot it, because I usually look for [PATCH] keyword in e-mail subject. Sorry about that. Someone speaking Python will have look at it in due course. Keep up good work! :) B. -- \\\\\ Katarina Machalkova \\\\\\\__o LibO developer __\\\\\\\'/_ & hedgehog painter
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
