Radek Doulík píše v Út 12. 07. 2011 v 12:09 +0200: > Hi all, > > I am looking for 1 review to include the patch in 3-4 branch. It fixes > ppt export and possibly more areas where the code use SvGlobalName class > and < operator. > > It is regression in "#i101100# strict-alias clean" changes. > > The original code (before strict alias clean) was using beginning of > pImp->szData in comparison > > - else if( *(USHORT *)&pImp->szData[ 4 ] == *(USHORT *)&rObj.pImp->szData[ > 4 ] ) > - return *(UINT32 *)pImp->szData < *(UINT32 *)rObj.pImp->szData; > > The fix is here > > http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=345dc7961bc142f167a1b8e5f43f4439e8234f06
Makes perfect sense. I see that Caolan already signed if off and pushed to the 3-4 branch. Best Regards, Petr _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
