accessibility/source/extended/AccessibleToolPanelDeck.cxx | 2 - accessibility/source/extended/AccessibleToolPanelDeckTabBar.cxx | 4 +- accessibility/source/extended/AccessibleToolPanelDeckTabBarItem.cxx | 2 - accessibility/source/extended/textwindowaccessibility.cxx | 5 ++- animations/source/animcore/animcore.cxx | 4 +- chart2/source/view/charttypes/GL3DBarChart.cxx | 16 +++++----- 6 files changed, 18 insertions(+), 15 deletions(-)
New commits: commit 21773f6d9a06012634716f3af5ccc74b6204a569 Author: Caolán McNamara <caol...@redhat.com> Date: Sat May 2 14:16:44 2015 +0100 cppcheck: noExplicitConstructor Change-Id: I0b1cac50f9e158004f8c1b8294b7a1b9f21f9628 diff --git a/accessibility/source/extended/AccessibleToolPanelDeck.cxx b/accessibility/source/extended/AccessibleToolPanelDeck.cxx index 85ce154..e1fb62f 100644 --- a/accessibility/source/extended/AccessibleToolPanelDeck.cxx +++ b/accessibility/source/extended/AccessibleToolPanelDeck.cxx @@ -106,7 +106,7 @@ namespace accessibility class MethodGuard { public: - MethodGuard( AccessibleToolPanelDeck_Impl& i_rImpl ) + explicit MethodGuard( AccessibleToolPanelDeck_Impl& i_rImpl ) :m_aGuard() { i_rImpl.checkDisposed(); diff --git a/accessibility/source/extended/AccessibleToolPanelDeckTabBar.cxx b/accessibility/source/extended/AccessibleToolPanelDeckTabBar.cxx index 50b9cea..11dc730 100644 --- a/accessibility/source/extended/AccessibleToolPanelDeckTabBar.cxx +++ b/accessibility/source/extended/AccessibleToolPanelDeckTabBar.cxx @@ -68,7 +68,7 @@ namespace accessibility class AccessibleWrapper : public AccessibleWrapper_Base { public: - AccessibleWrapper( const Reference< XAccessibleContext >& i_rContext ) + explicit AccessibleWrapper( const Reference< XAccessibleContext >& i_rContext ) :m_xContext( i_rContext ) { } @@ -258,7 +258,7 @@ namespace accessibility class MethodGuard { public: - MethodGuard( AccessibleToolPanelTabBar_Impl& i_rImpl ) + explicit MethodGuard( AccessibleToolPanelTabBar_Impl& i_rImpl ) :m_aGuard() { i_rImpl.checkDisposed(); diff --git a/accessibility/source/extended/AccessibleToolPanelDeckTabBarItem.cxx b/accessibility/source/extended/AccessibleToolPanelDeckTabBarItem.cxx index b8058d6..644b3fa 100644 --- a/accessibility/source/extended/AccessibleToolPanelDeckTabBarItem.cxx +++ b/accessibility/source/extended/AccessibleToolPanelDeckTabBarItem.cxx @@ -221,7 +221,7 @@ namespace accessibility class ItemMethodGuard { public: - ItemMethodGuard( AccessibleToolPanelDeckTabBarItem_Impl& i_rImpl ) + explicit ItemMethodGuard( AccessibleToolPanelDeckTabBarItem_Impl& i_rImpl ) :m_aGuard() { i_rImpl.checkDisposed(); diff --git a/accessibility/source/extended/textwindowaccessibility.cxx b/accessibility/source/extended/textwindowaccessibility.cxx index fbe72a0..1a391ce 100644 --- a/accessibility/source/extended/textwindowaccessibility.cxx +++ b/accessibility/source/extended/textwindowaccessibility.cxx @@ -982,7 +982,10 @@ Document::retrieveCharacterBounds(Paragraph const * pParagraph, struct IndexCompare { const css::beans::PropertyValue* pValues; - IndexCompare( const css::beans::PropertyValue* pVals ) : pValues(pVals) {} + explicit IndexCompare(const css::beans::PropertyValue* pVals) + : pValues(pVals) + { + } bool operator() ( const sal_Int32& a, const sal_Int32& b ) const { return pValues[a].Name < pValues[b].Name; diff --git a/animations/source/animcore/animcore.cxx b/animations/source/animcore/animcore.cxx index 3fbad43..6a1d338 100644 --- a/animations/source/animcore/animcore.cxx +++ b/animations/source/animcore/animcore.cxx @@ -129,8 +129,8 @@ public: class AnimationNode : public AnimationNodeBase { public: - AnimationNode( sal_Int16 nNodeType ); - AnimationNode( const AnimationNode& rNode ); + explicit AnimationNode(sal_Int16 nNodeType); + explicit AnimationNode(const AnimationNode& rNode); virtual ~AnimationNode(); // XInterface commit 5c4955ed4593f529fd902cdf3afab3c8150b3214 Author: Caolán McNamara <caol...@redhat.com> Date: Sat May 2 14:07:15 2015 +0100 cppcheck: unusedScopedObject Change-Id: If627c5300b3b4acc8351177857fc8fa70e76df00 diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx b/chart2/source/view/charttypes/GL3DBarChart.cxx index ad79ed5..6377202 100644 --- a/chart2/source/view/charttypes/GL3DBarChart.cxx +++ b/chart2/source/view/charttypes/GL3DBarChart.cxx @@ -589,7 +589,7 @@ GL3DBarChart::~GL3DBarChart() { if (mbBenchMarkMode) { - SharedResourceAccess(maCond1, maCond2); + SharedResourceAccess aResGuard(maCond1, maCond2); osl::MutexGuard aGuard(maMutex); mbRenderDie = true; } @@ -603,7 +603,7 @@ GL3DBarChart::~GL3DBarChart() void GL3DBarChart::create3DShapes(const boost::ptr_vector<VDataSeries>& rDataSeriesContainer, ExplicitCategoriesProvider& rCatProvider) { - SharedResourceAccess(maCond1, maCond2); + SharedResourceAccess aResGuard(maCond1, maCond2); osl::MutexGuard aGuard(maMutex); if(mnSelectBarId) { @@ -897,7 +897,7 @@ void GL3DBarChart::moveToDefault() return; { - SharedResourceAccess(maCond1, maCond2); + SharedResourceAccess aResGuard(maCond1, maCond2); osl::MutexGuard aGuard(maMutex); maRenderEvent = EVENT_MOVE_TO_DEFAULT; } @@ -947,7 +947,7 @@ void GL3DBarChart::clickedAt(const Point& rPos, sal_uInt16 nButtons) return; { - SharedResourceAccess(maCond1, maCond2); + SharedResourceAccess aResGuard(maCond1, maCond2); osl::MutexGuard aGuard(maMutex); maClickPos = rPos; mnPreSelectBarId = mnSelectBarId; @@ -1032,7 +1032,7 @@ void GL3DBarChart::renderFrame() void GL3DBarChart::mouseDragMove(const Point& rStartPos, const Point& rEndPos, sal_uInt16 ) { long nDirection = rEndPos.X() - rStartPos.X(); - SharedResourceAccess(maCond1, maCond2); + SharedResourceAccess aResGuard(maCond1, maCond2); osl::ClearableGuard<osl::Mutex> aGuard(maMutex); if ((maRenderEvent == EVENT_NONE) || (maRenderEvent == EVENT_SHOW_SCROLL) || (maRenderEvent == EVENT_AUTO_FLY) || (maRenderEvent == EVENT_SHOW_SELECT)) @@ -1107,7 +1107,7 @@ void GL3DBarChart::moveToCorner() void GL3DBarChart::scroll(long nDelta) { { - SharedResourceAccess(maCond1, maCond2); + SharedResourceAccess aResGuard(maCond1, maCond2); osl::MutexGuard aGuard(maMutex); if ((maRenderEvent != EVENT_NONE) && (maRenderEvent != EVENT_SHOW_SCROLL) && (maRenderEvent != EVENT_AUTO_FLY) && (maRenderEvent != EVENT_SHOW_SELECT)) @@ -1128,7 +1128,7 @@ void GL3DBarChart::scroll(long nDelta) void GL3DBarChart::contextDestroyed() { - SharedResourceAccess(maCond1, maCond2); + SharedResourceAccess aResGuard(maCond1, maCond2); osl::MutexGuard aGuard(maMutex); mbValidContext = false; } @@ -1178,7 +1178,7 @@ int GL3DBarChart::calcTimeInterval(TimeValue &startTime, TimeValue &endTime) void GL3DBarChart::updateScreenText() { - SharedResourceAccess(maCond1, maCond2); + SharedResourceAccess aResGuard(maCond1, maCond2); osl::MutexGuard aGuard(maMutex); maScreenTextShapes.clear(); mpRenderer->ReleaseScreenTextShapes();
_______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits