https://bugs.documentfoundation.org/show_bug.cgi?id=66754
--- Comment #4 from Taylor <taylorlee...@gmail.com> --- bavincen, I think your solution is a step in the right direction. I find 'sub create_directory' in the following 4 files: setup_native/scripts/admin.pl solenv/bin/modules/installer/systemactions.pm solenv/bin/modules/par2script/systemactions.pm solenv/bin/modules/pre2par/systemactions.pm The last 2 files don't seem to need make_path as there is no implementation of recursive directory creation; mkdir seems sufficient. In the first 2 files, I think it makes sense to replace the contents of create_directory() with make_path and some error detection as was implemented in create_directory_with_privileges(). I argue that there are many calls to installer::systemactions::create_directory($var), so does changing all calls to "make_path($var, {mode=0775})" make sense? Maybe having mode in a central function is a good thing? Not sure. > egrep -ciIR installer::systemactions::create_directory | egrep -v ':0$' solenv/bin/modules/installer.pm:6 solenv/bin/modules/installer/parameter.pm:2 solenv/bin/modules/installer/worker.pm:6 solenv/bin/modules/installer/windows/mergemodule.pm:3 solenv/bin/modules/installer/windows/idtglobal.pm:2 solenv/bin/modules/installer/windows/strip.pm:1 solenv/bin/modules/installer/windows/update.pm:1 solenv/bin/modules/installer/windows/msp.pm:7 solenv/bin/modules/installer/windows/admin.pm:2 solenv/bin/modules/installer/strip.pm:1 solenv/bin/modules/installer/profiles.pm:1 solenv/bin/modules/installer/simplepackage.pm:9 solenv/bin/modules/installer/archivefiles.pm:2 solenv/bin/modules/installer/scpzipfiles.pm:2 solenv/bin/modules/installer/download.pm:1 solenv/bin/modules/installer/copyproject.pm:1 -- You are receiving this mail because: You are on the CC list for the bug.
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice