On 07/08/2015 05:33 PM, Rishabh Kumar wrote:
commit cc43153f466135b959605add37ccd9443852c185
Author: Rishabh Kumar <kris.kr...@gmail.com>
Date:   Fri Jun 19 18:55:43 2015 +0530

     tdf#87702: Addition of Shadow sidebar tab

     Change-Id: I75b368c0a8088926c765dbc46c6a4ce7c9d8b9f0
     Reviewed-on: https://gerrit.libreoffice.org/16375
     Reviewed-by: Caolán McNamara <caol...@redhat.com>
     Tested-by: Caolán McNamara <caol...@redhat.com>

diff --git a/cui/source/tabpages/tpshadow.cxx b/cui/source/tabpages/tpshadow.cxx
index 67abb5d..dd6db29 100644
--- a/cui/source/tabpages/tpshadow.cxx
+++ b/cui/source/tabpages/tpshadow.cxx
@@ -41,7 +41,10 @@ const sal_uInt16 SvxShadowTabPage::pShadowRanges[] =
      SDRATTR_SHADOWCOLOR,
      SDRATTR_SHADOWTRANSPARENCE,
      SID_ATTR_FILL_SHADOW,
-    SID_ATTR_FILL_SHADOW,
+    SID_ATTR_SHADOW_COLOR,
+    SID_ATTR_SHADOW_TRANSPARENCE,
+    SID_ATTR_SHADOW_XDISTANCE,
+    SID_ATTR_SHADOW_YDISTANCE,

Doesn't this look odd, given pShadowRanges presumably shall consist of begin/end pairs?

      0
  };

diff --git a/include/svx/svxids.hrc b/include/svx/svxids.hrc
index 81cecff..f59e3e4 100644
--- a/include/svx/svxids.hrc
+++ b/include/svx/svxids.hrc
@@ -1008,8 +1008,12 @@
  #define SID_PARASPACE_DECREASE                          ( SID_SVX_START + 
1146 )

  #define SID_OBJECT_CROP                                 ( SID_SVX_START + 
1147 )
+#define SID_ATTR_SHADOW_TRANSPARENCE                    ( SID_SVX_START + 1148 
)
+#define SID_ATTR_SHADOW_COLOR                           ( SID_SVX_START + 1149 
)
+#define SID_ATTR_SHADOW_XDISTANCE                       ( SID_SVX_START + 1150 
)
+#define SID_ATTR_SHADOW_YDISTANCE                       ( SID_SVX_START + 1151 
)

-#define SID_EDIT_POSTIT                                 ( SID_SVX_START + 1148 
)
+#define SID_EDIT_POSTIT                                 ( SID_SVX_START + 1152 
)

  // IMPORTANT NOTE: adjust SID_SVX_FIRSTFREE, when adding new slot id
  #define SID_SVX_FIRSTFREE                               (SID_EDIT_POSTIT + 1)
[...]
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to