Hi Eike,

I see a lot of sal_uInt64 in the code. Is that supported for Windows? As far as I know at least the MSVC Express has only 4Byte long.

Kind regards
Regina

Eike Rathke schrieb:
Hi Korrawit,

On Tuesday, 2011-09-06 21:52:46 +0700, Korrawit Pruegsanusak wrote:

And please s/interger/integer ;)

Did that in the commit.

Also, it seems that you haven't check the range of ishift yet, whether
it is between -48 and 48 (from your description), or it isn't
necessary? I don't have knowledge on this.

Actually those don't have to be restricted and I implemented another
algorithm to support larger values.

My last nitpick, what about the strings capitalization?

Also did that.

   Eike




_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to