I've always considered gerrit to be the place to review code! Chris
Sent from my iPhone > On 23 Feb 2016, at 4:36 PM, Khaled Hosny <khaledho...@eglug.org> wrote: > > The patch does not really fix the issue, it makes it even worse. I think > she is just asking for pointers to further work on the issue, so > submitting a patch to gerrit might not be the best course of action. > > Regards, > Khaled > >> On Mon, Feb 22, 2016 at 10:21:27AM +0100, jan iversen wrote: >> Hi >> >> Thanks for the work, but please submit the patch via gerrit. >> >> Take a loook at: >> https://wiki.documentfoundation.org/Development/GetInvolved >> >> rgds >> jan i. >> >> >> Sent from my iPad, please excuse any misspellings >> >>> On 22 Feb 2016, at 08:10, noseeba Al kindi <nosee...@gmail.com> wrote: >>> >>> Hi, >>> >>> I add some changes in the code and now line breaking cut the word >>> (character by character) in the different script depending on the >>> available space in the line. I attached the patch so please review and >>> give me your comments and ideas to solve the issue. >>> >>> regards, >>> Nusaiba >>> >>>> On Mon, Feb 1, 2016 at 9:42 AM, Mark Hung <mark...@gmail.com> wrote: >>>> Hi Nusaiba, >>>> >>>> You might have to understand how layout is done. >>>> FYR: >>>> https://wiki.openoffice.org/wiki/Writer/Core_And_Layout >>>> https://wiki.openoffice.org/wiki/Writer/Text_Formatting >>>> >>>> Multiportion can contain multiple lines in one single portion. >>>> For example, SwRubyPortion is used by CJK script for asian phonetic guide, >>>> where phonetic guide ( aka ruby text ) are placed above the base text. >>>> SwDoublePortion can contain two lines in one portion. >>>> >>>> Best Regards >>>> >>>> 2016-02-01 13:10 GMT+08:00 noseeba Al kindi <nosee...@gmail.com>: >>>>> >>>>> Dear, >>>>> >>>>> I am interested in solving this bug [56408]: >>>>> >>>>> https://bugs.documentfoundation.org/show_bug.cgi?id=56408 >>>>> >>>>> when i go through the classes there was part talking about single and >>>>> multi portion that I didn't understand it, so if anyone could explain >>>>> what is a portion exactly? and what is the the different between >>>>> single and multi portion? >>>>> >>>>> BTW, I welcome any suggestion that could help in solving this issue. >>>>> >>>>> regards >>>>> Nusaiba >>>>> _______________________________________________ >>>>> LibreOffice mailing list >>>>> LibreOffice@lists.freedesktop.org >>>>> http://lists.freedesktop.org/mailman/listinfo/libreoffice >>>> >>>> >>>> >>>> >>>> -- >>>> Mark Hung >>> <Bug56408.patch> >>> <After modification.png> >>> <Before modification.png> >>> _______________________________________________ >>> LibreOffice mailing list >>> LibreOffice@lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/libreoffice > >> _______________________________________________ >> LibreOffice mailing list >> LibreOffice@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/libreoffice > > _______________________________________________ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/libreoffice _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice