cui/source/customize/cfg.cxx | 4 ++--
cui/source/dialogs/cuicharmap.cxx | 4 ++--
cui/source/dialogs/iconcdlg.cxx | 3 +--
cui/source/inc/cfg.hxx | 3 +--
cui/source/inc/cuicharmap.hxx | 2 +-
cui/source/inc/iconcdlg.hxx | 4 ++--
cui/source/options/connpoolconfig.cxx | 4 ++--
cui/source/options/connpoolsettings.cxx | 4 ++--
cui/source/options/connpoolsettings.hxx | 4 ++--
cui/source/tabpages/borderconn.cxx | 19 ++++++++-----------
10 files changed, 23 insertions(+), 28 deletions(-)
New commits:
commit e17b95b9deaa2414c372b88a86db8f20cfc452fa
Author: Noel Grandin <n...@peralex.com>
Date: Thu Mar 17 15:11:16 2016 +0200
loplugin:constantparam in cui
Change-Id: Iccba51d7b1d11ae5b309e380fd396be796992d7e
diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index 6aa6838..c8e5ba3 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -4698,10 +4698,10 @@ IMPL_LINK_NOARG_TYPED( SvxToolbarConfigPage,
AddFunctionHdl, SvxScriptSelectorDi
}
void SvxToolbarConfigPage::AddFunction(
- SvTreeListEntry* pTarget, bool bFront, bool bAllowDuplicates )
+ SvTreeListEntry* pTarget, bool bFront )
{
SvTreeListEntry* pNewLBEntry =
- SvxConfigPage::AddFunction( pTarget, bFront, bAllowDuplicates );
+ SvxConfigPage::AddFunction( pTarget, bFront, true/*bAllowDuplicates*/
);
SvxConfigEntry* pEntry =
static_cast<SvxConfigEntry*>(pNewLBEntry->GetUserData());
diff --git a/cui/source/dialogs/cuicharmap.cxx
b/cui/source/dialogs/cuicharmap.cxx
index ded9588..dc582d6 100644
--- a/cui/source/dialogs/cuicharmap.cxx
+++ b/cui/source/dialogs/cuicharmap.cxx
@@ -173,10 +173,10 @@ short SvxCharacterMap::Execute()
// class SvxShowText =====================================================
-SvxShowText::SvxShowText(vcl::Window* pParent, bool bCenter)
+SvxShowText::SvxShowText(vcl::Window* pParent)
: Control(pParent)
, mnY(0)
- , mbCenter(bCenter)
+ , mbCenter(false)
{}
VCL_BUILDER_FACTORY(SvxShowText)
diff --git a/cui/source/dialogs/iconcdlg.cxx b/cui/source/dialogs/iconcdlg.cxx
index 859dc9a..66d042d 100644
--- a/cui/source/dialogs/iconcdlg.cxx
+++ b/cui/source/dialogs/iconcdlg.cxx
@@ -281,8 +281,7 @@ SvxIconChoiceCtrlEntry* IconChoiceDialog::AddTabPage(
)
{
IconChoicePageData* pData = new IconChoicePageData ( nId, pCreateFunc,
- nullptr,
-
false/*bItemsOnDemand*/ );
+ nullptr );
maPageList.push_back( pData );
pData->fnGetRanges = nullptr;
diff --git a/cui/source/inc/cfg.hxx b/cui/source/inc/cfg.hxx
index abc9280..104f2e5 100644
--- a/cui/source/inc/cfg.hxx
+++ b/cui/source/inc/cfg.hxx
@@ -581,8 +581,7 @@ public:
virtual void dispose() override;
void AddFunction( SvTreeListEntry* pTarget = nullptr,
- bool bFront = false,
- bool bAllowDuplicates = true );
+ bool bFront = false );
void MoveEntry( bool bMoveUp ) override;
diff --git a/cui/source/inc/cuicharmap.hxx b/cui/source/inc/cuicharmap.hxx
index 9e1efa9..a59a209 100644
--- a/cui/source/inc/cuicharmap.hxx
+++ b/cui/source/inc/cuicharmap.hxx
@@ -39,7 +39,7 @@ namespace svx
class SvxShowText : public Control
{
public:
- SvxShowText(vcl::Window* pParent, bool bCenter = false);
+ SvxShowText(vcl::Window* pParent);
void SetFont( const vcl::Font& rFont );
void SetText( const OUString& rText ) override;
diff --git a/cui/source/inc/iconcdlg.hxx b/cui/source/inc/iconcdlg.hxx
index b343adb..d97b03b 100644
--- a/cui/source/inc/iconcdlg.hxx
+++ b/cui/source/inc/iconcdlg.hxx
@@ -51,12 +51,12 @@ struct IconChoicePageData
bool bRefresh; ///< Flag: page has to be newly initialized
// constructor
- IconChoicePageData( sal_uInt16 Id, CreatePage fnPage, GetPageRanges
fnRanges, bool bDemand )
+ IconChoicePageData( sal_uInt16 Id, CreatePage fnPage, GetPageRanges
fnRanges )
: nId ( Id ),
fnCreatePage ( fnPage ),
fnGetRanges ( fnRanges ),
pPage ( nullptr ),
- bOnDemand ( bDemand ),
+ bOnDemand ( false ),
bRefresh ( false )
{}
};
diff --git a/cui/source/options/connpoolconfig.cxx
b/cui/source/options/connpoolconfig.cxx
index 56ff7d3b..31423f5 100644
--- a/cui/source/options/connpoolconfig.cxx
+++ b/cui/source/options/connpoolconfig.cxx
@@ -93,7 +93,7 @@ namespace offapp
++aLoopDrivers
)
{
- aSettings.push_back(DriverPooling(*aLoopDrivers, false, 120));
+ aSettings.push_back(DriverPooling(*aLoopDrivers, 120));
}
// then look for which of them settings are stored in the configuration
@@ -121,7 +121,7 @@ namespace offapp
if (aLookup == aSettings.end())
{ // do not know the driver - add it
- aSettings.push_back(DriverPooling(sThisDriverName, false,
120));
+ aSettings.push_back(DriverPooling(sThisDriverName, 120));
// and the position of the new entry
aLookup = aSettings.end();
diff --git a/cui/source/options/connpoolsettings.cxx
b/cui/source/options/connpoolsettings.cxx
index de64d35..7eb2d8e 100644
--- a/cui/source/options/connpoolsettings.cxx
+++ b/cui/source/options/connpoolsettings.cxx
@@ -23,9 +23,9 @@
namespace offapp
{
- DriverPooling::DriverPooling( const OUString& _rName, bool _bEnabled,
const sal_Int32 _nTimeout )
+ DriverPooling::DriverPooling( const OUString& _rName, const sal_Int32
_nTimeout )
:sName(_rName)
- ,bEnabled(_bEnabled)
+ ,bEnabled(false)
,nTimeoutSeconds(_nTimeout)
{
}
diff --git a/cui/source/options/connpoolsettings.hxx
b/cui/source/options/connpoolsettings.hxx
index 8353f45..6cb1b0d 100644
--- a/cui/source/options/connpoolsettings.hxx
+++ b/cui/source/options/connpoolsettings.hxx
@@ -34,10 +34,10 @@ namespace offapp
struct DriverPooling
{
OUString sName;
- bool bEnabled;
+ bool bEnabled;
sal_Int32 nTimeoutSeconds;
- DriverPooling( const OUString& _rName, bool _bEnabled, const sal_Int32
_nTimeout );
+ DriverPooling( const OUString& _rName, const sal_Int32 _nTimeout );
bool operator == (const DriverPooling& _rR) const;
bool operator != (const DriverPooling& _rR) const { return !operator
==(_rR); }
diff --git a/cui/source/tabpages/borderconn.cxx
b/cui/source/tabpages/borderconn.cxx
index ce94e50..3f5019a 100644
--- a/cui/source/tabpages/borderconn.cxx
+++ b/cui/source/tabpages/borderconn.cxx
@@ -165,14 +165,12 @@ class MarginConnection : public
sfx::ItemControlConnection< MarginItemWrapper, M
public:
explicit MarginConnection( const SfxItemSet& rItemSet,
MetricField& rMfLeft, MetricField& rMfRight,
- MetricField& rMfTop, MetricField& rMfBottom,
- sfx::ItemConnFlags nFlags = sfx::ITEMCONN_DEFAULT
);
+ MetricField& rMfTop, MetricField& rMfBottom );
};
MarginConnection::MarginConnection( const SfxItemSet& rItemSet,
- MetricField& rMfLeft, MetricField& rMfRight, MetricField& rMfTop,
MetricField& rMfBottom,
- sfx::ItemConnFlags nFlags ) :
- ItemControlConnectionType( SID_ATTR_ALIGN_MARGIN, new
MarginControlsWrapper( rMfLeft, rMfRight, rMfTop, rMfBottom ), nFlags )
+ MetricField& rMfLeft, MetricField& rMfRight, MetricField& rMfTop,
MetricField& rMfBottom ) :
+ ItemControlConnectionType( SID_ATTR_ALIGN_MARGIN, new
MarginControlsWrapper( rMfLeft, rMfRight, rMfTop, rMfBottom ),
sfx::ITEMCONN_DEFAULT )
{
mxCtrlWrp->SetDefaultValue( maItemWrp.GetDefaultItem( rItemSet ) );
}
@@ -252,13 +250,12 @@ class ShadowConnection : public
sfx::ItemControlConnection< ShadowItemWrapper, S
{
public:
explicit ShadowConnection( const SfxItemSet& rItemSet,
- ValueSet& rVsPos, MetricField& rMfSize,
ColorListBox& rLbColor,
- sfx::ItemConnFlags nFlags =
sfx::ITEMCONN_DEFAULT );
+ ValueSet& rVsPos, MetricField& rMfSize,
ColorListBox& rLbColor );
};
ShadowConnection::ShadowConnection( const SfxItemSet& rItemSet,
- ValueSet& rVsPos, MetricField& rMfSize, ColorListBox& rLbColor,
sfx::ItemConnFlags nFlags ) :
- ItemControlConnectionType( SID_ATTR_BORDER_SHADOW, new
ShadowControlsWrapper( rVsPos, rMfSize, rLbColor ), nFlags )
+ ValueSet& rVsPos, MetricField& rMfSize, ColorListBox& rLbColor ) :
+ ItemControlConnectionType( SID_ATTR_BORDER_SHADOW, new
ShadowControlsWrapper( rVsPos, rMfSize, rLbColor ), sfx::ITEMCONN_DEFAULT )
{
mxCtrlWrp->SetDefaultValue( maItemWrp.GetDefaultItem( rItemSet ) );
}
@@ -274,13 +271,13 @@ sfx::ItemConnectionBase* CreateMarginConnection( const
SfxItemSet& rItemSet,
MetricField& rMfLeft, MetricField& rMfRight,
MetricField& rMfTop, MetricField& rMfBottom )
{
- return new MarginConnection( rItemSet, rMfLeft, rMfRight, rMfTop,
rMfBottom, sfx::ITEMCONN_DEFAULT );
+ return new MarginConnection( rItemSet, rMfLeft, rMfRight, rMfTop,
rMfBottom );
}
sfx::ItemConnectionBase* CreateShadowConnection( const SfxItemSet& rItemSet,
ValueSet& rVsPos, MetricField& rMfSize, ColorListBox& rLbColor )
{
- return new ShadowConnection( rItemSet, rVsPos, rMfSize, rLbColor,
sfx::ITEMCONN_DEFAULT );
+ return new ShadowConnection( rItemSet, rVsPos, rMfSize, rLbColor );
}
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
