Hey, On Fri, Apr 22, 2016 at 11:58 AM, Xisco Faulí <aniste...@gmail.com> wrote:
> Hi Markus, > > 2016-04-20 20:46 GMT+02:00 Markus Mohrhard <markus.mohrh...@googlemail.com > >: > >> Hey Xisco, >> >> On Wed, Apr 20, 2016 at 3:55 PM, Xisco Faulí <aniste...@gmail.com> wrote: >> >>> Hi Caolan, >>> >>> Noob question, should the crash testing detect failures like this one: >>> https://bugs.documentfoundation.org/show_bug.cgi?id=76115 >>> >> >> >> No, it is not a crash and just a normal rejected document. It would show >> up if we would for example hit an assert while loading the file but not as >> long as we just reject the file during loading. Also the crash testing has >> a timeout for any document which currently means that crashes in documents >> taking minutes to open will not be discovered. >> >> > In test-bugzilla-files.py, I see that when a timeout is reached, it's just > printed in console, do you think it would be a good idea to at least print > the rejected documents into a file so we can keep track of them over the > time to see if the number of them is increasing or decreasing? > I used to export them to a file as well but it turned out to be completely useless. There are many documents that are just at the border and it depends so much on the condition of the VM. Also any small performance change will result in many documents moving around. If you feel like it is something that helps you just add a patch and we can of course add it. > > Another noob question: Even if download pdfs use lot of space in disk, > don't you think it would be worth it to test wether they crash at > import/export time? Right now it's disabled: > https://cgit.freedesktop.org/libreoffice/core/tree/bin/get-bugzilla-attachments-by-mimetype#n501 > We have around 10k pdf files on the server. So there are already quite a number that we use for the crash testing. Based on the file names it seems that I have downloaded them quite some time ago. Also we have quite a bit more documents than are downloaded by the script. Regards, Markus > > >> Regards >> Markus >> >> >>> >>> Best Regards, >>> Xisco >>> >>> _______________________________________________ >>> LibreOffice mailing list >>> LibreOffice@lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/libreoffice >>> >>> >> >
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
