Has anybody had a chance to review this patch? I'm really interested in writing some tests for basic and I'd like to make sure that these types of changes are on the right track.
August Sodora aug...@gmail.com (201) 280-8138 On Tue, Oct 4, 2011 at 3:48 PM, August Sodora <aug...@gmail.com> wrote: > I've attached a revised patch that should fix the pLine issue. The > assignment to pLine is now redundant and all the checks in pLine can > probably be more appropriately expressed in terms of aLine anyway. I'm > not sure how ToUpperAscii affects this patch, do you mind explaining a > little further? > > August Sodora > aug...@gmail.com > (201) 280-8138 > > > > On Tue, Oct 4, 2011 at 6:27 AM, Caolán McNamara <caol...@redhat.com> wrote: >> On Tue, 2011-10-04 at 10:57 +0200, Jan Holesovsky wrote: >>> BTW, another horror in the original code is: >>> >>> > ch1 = aSym.ToUpperAscii().GetBuffer()[0]; >>> >>> ie. we convert the entire string to upper case, and then throw all that >>> away but the first char. >> >> [Byte]String::ToUpperAscii, see tools/source/string/strimp.cxx, modifies >> the string it operates on and returns a reference to *this, i.e. >> >> aSym = "hello"; >> aSym.ToUpperAscii();; >> //aSym contains "HELLO" now >> >> I mean, it doesn't return an uppercased copy, but returns itself, which >> has been uppercased. >> >> C. >> >> > _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
