Hi Markus,

On Tuesday, 2011-11-01 22:45:57 +0100, Markus Mohrhard wrote:

> http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0dd2113527ba0a601c5c59de7f7f44da161d21

Taking a second look, that patch would break handling of the case when
the matrix is a valid 2D matrix with more than one column and more than
one row. See implementation of ValidColRowReplicated(), which is not
meant to be used in such a context, but to determine whether a col/row
needs to be replicated in case the matrix is only a vector. If at all,
the intended behavior could be realized using ValidColRowOrReplicated()
instead, however, I currently don't remember why all Is*() methods don't
use it whereas all Get*() methods do.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpEX6JraInH1.pgp
Description: PGP signature

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to