Attached patch solves (according to user report on master daily build)
fdo#36555, a severity "critical" bug which keeps users from connecting
to ADO / OLE DB datasources. In particular, it keeps user from
connecting to MS Access (.mdb) files in the most natural way; that is,
by creating a new ODB file by wizard, selecting "connect to existing
database" and then "MS Access" in the drop-down list.
It does not completely solve the bug in *my* testing (in master), but
that may be specific to my local setup and/or the MinGW build.
However, I would like to have that patch already applied to the
libreoffice-3-4 branch since:
- It completely solves the bug at least for some
(see https://bugs.freedesktop.org/show_bug.cgi?id=36555#c42)
- It is "obviously" correct, independent of the bug.
--
Lionel
>From d270baa6b49f18b7b84cc2d3bacf31074c142a77 Mon Sep 17 00:00:00 2001
From: Lionel Elie Mamane <lionel.mam...@gestman.lu>
Date: Tue, 22 Nov 2011 14:25:10 +0100
Subject: [PATCH 3/3] fdo#36555: pImplementationName is not a compile-time
constant
---
connectivity/source/drivers/ado/Aservices.cxx | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/connectivity/source/drivers/ado/Aservices.cxx b/connectivity/source/drivers/ado/Aservices.cxx
index 68600ba..69bd7c6 100644
--- a/connectivity/source/drivers/ado/Aservices.cxx
+++ b/connectivity/source/drivers/ado/Aservices.cxx
@@ -59,7 +59,7 @@ struct ProviderRequest
sal_Char const* pImplementationName
)
: xServiceManager(reinterpret_cast<XMultiServiceFactory*>(pServiceManager))
- , sImplementationName(OUString(RTL_CONSTASCII_USTRINGPARAM(pImplementationName)))
+ , sImplementationName(OUString::createFromAscii(pImplementationName))
{
}
--
1.7.7.3
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
