sc/source/core/inc/interpre.hxx | 2 +-
sc/source/core/tool/interpr1.cxx | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit f6d7bd1f525d3930c48b61abb2e91418f2c66ca5
Author: Julien Nabet <serval2...@yahoo.fr>
Date: Tue May 16 23:50:46 2017 +0200
tdf#107892: fix negative values case with maxifs
std::numeric_limits<double>::min() returns positive value for float/double
so use std::numeric_limits<double>::lowest()
(see
http://stackoverflow.com/questions/17070351/why-does-numeric-limitsmin-return-a-negative-value-for-int-but-positive-values)
Change-Id: I0afce2d38c6936aeff26923182bcafd2f0008d9e
Reviewed-on: https://gerrit.libreoffice.org/37693
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Eike Rathke <er...@redhat.com>
(cherry picked from commit 20d3a60b41bda2513723c145d919f584840b1056)
Reviewed-on: https://gerrit.libreoffice.org/37730
diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx
index fe860eba7120..636f2ecd62d1 100644
--- a/sc/source/core/inc/interpre.hxx
+++ b/sc/source/core/inc/interpre.hxx
@@ -69,7 +69,7 @@ struct ParamIfsResult
double mfMem = 0.0;
double mfCount = 0.0;
double mfMin = std::numeric_limits<double>::max();
- double mfMax = std::numeric_limits<double>::min();
+ double mfMax = std::numeric_limits<double>::lowest();
};
}
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 9a02b624df22..f005b26e4635 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -5780,7 +5780,7 @@ void ScInterpreter::ScMaxIfs_MS()
sc::ParamIfsResult aRes;
IterateParametersIfs(aRes);
- PushDouble((aRes.mfMax > std::numeric_limits<double>::min()) ? aRes.mfMax
: 0.0);
+ PushDouble((aRes.mfMax > std::numeric_limits<double>::lowest()) ?
aRes.mfMax : 0.0);
}
void ScInterpreter::ScLookup()
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
