sc/inc/scmatrix.hxx | 10 +++++----- sc/source/ui/app/inputhdl.cxx | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-)
New commits: commit 27c5f2586821546ee8281bafb8b5f478ae015ac1 Author: Eike Rathke <er...@redhat.com> Date: Thu Jun 8 20:39:00 2017 +0200 Add '~' reference union/list operator to range finder delimiters ... so formula expressions using it actually get the ranges highlighted. Change-Id: Ibb0d2b49101e62b1f219a14d1669a501a450aaf4 diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index 3647a5633502..dfbd1c43bbb3 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -299,7 +299,7 @@ void ScInputHandler::InitRangeFinder( const OUString& rFormula ) ScDocument& rDoc = pDocSh->GetDocument(); const sal_Unicode cSheetSep = lcl_getSheetSeparator(&rDoc); - OUString aDelimiters = ScEditUtil::ModifyDelimiters(" !\""); + OUString aDelimiters = ScEditUtil::ModifyDelimiters(" !~\""); // delimiters (in addition to ScEditUtil): only characters that are // allowed in formulas next to references and the quotation mark (so // string constants can be skipped) commit 5ac74f15dcdf85faa2ac1cb7317ea77e31fbcd50 Author: Eike Rathke <er...@redhat.com> Date: Thu Jun 8 18:13:49 2017 +0200 Remove a TODO and explain Change-Id: Ic648fd2b0a1424aa5ae5d924b29dfd2cb8dddbf9 diff --git a/sc/inc/scmatrix.hxx b/sc/inc/scmatrix.hxx index 886bbd86840a..553c09f0e416 100644 --- a/sc/inc/scmatrix.hxx +++ b/sc/inc/scmatrix.hxx @@ -133,11 +133,11 @@ public: /** * When adding all numerical matrix elements for a scalar result such as * summation, the interpreter wants to separate the first non-zero value - * with the rest of the summed values. - * - * TODO: Find out if we still need to do this. If not, we can re-write - * ScInterpreter::IterateParameters() to make it simpler and remove this - * struct. + * with the rest of the summed values. This is necessary for better + * numerical stability, unless we sort all by absolute values before + * summing (not really an option) or use another algorithm, e.g. Kahan's + * summation algorithm, + * https://en.wikipedia.org/wiki/Kahan_summation_algorithm */ struct IterateResult { _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits