Hello Noel,
Looking at Coverity scan report, it seems nScreen should be initialized.
Indeed, either it's really unused and nScreen should be completely
removed or it's used and its initialization should stay.
If it's first option, I didn't see another patch in gerrit review
concerning vcl part.
Are you sure about loplugin:unusedfields or did I miss something?
Julien
-------- Forwarded Message --------
Subject: New Defects reported by Coverity Scan for LibreOffice
Date: Sat, 17 Jun 2017 21:35:05 -0700
From: scan-ad...@coverity.com
To: serval2...@yahoo.fr
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1412875: Uninitialized members (UNINIT_CTOR)
/vcl/unx/generic/gdi/cairo_xlib_cairo.cxx: 70 in
cairo::X11SysData::X11SysData(const SystemGraphicsData &)()
________________________________________________________________________________________________________
*** CID 1412875: Uninitialized members (UNINIT_CTOR)
/vcl/unx/generic/gdi/cairo_xlib_cairo.cxx: 70 in
cairo::X11SysData::X11SysData(const SystemGraphicsData &)()
64 pRenderFormat(nullptr)
65 {}
66
67 X11SysData::X11SysData( const SystemGraphicsData& pSysDat ) :
68 hDrawable(pSysDat.hDrawable),
69 pRenderFormat(pSysDat.pXRenderFormat)
CID 1412875: Uninitialized members (UNINIT_CTOR)
Non-static class member "nScreen" is not initialized in this constructor
nor in any functions that it calls.
70 {}
71
72 X11SysData::X11SysData( const SystemEnvData& pSysDat ) :
73 pDisplay(pSysDat.pDisplay),
74 hDrawable(pSysDat.aWindow),
75 pVisual(pSysDat.pVisual),
...
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
