cui/source/dialogs/screenshotannotationdlg.cxx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
New commits: commit 4be3f2b3a9294c22de68b586d84328ec08906b84 Author: Olivier Hallot <olivier.hal...@libreoffice.org> Date: Fri Jun 16 16:21:44 2017 -0300 Fix screenshot missing quotes in code snippet The code snippet suggested has no quotes in atttributes values. Change-Id: I604fb34827da3bebf3f6759b491d719a96854754 Reviewed-on: https://gerrit.libreoffice.org/38895 Tested-by: Jenkins <c...@libreoffice.org> Reviewed-by: Katarina Behrens <katarina.behr...@cib.de> diff --git a/cui/source/dialogs/screenshotannotationdlg.cxx b/cui/source/dialogs/screenshotannotationdlg.cxx index 398458df5887..8913b871be41 100644 --- a/cui/source/dialogs/screenshotannotationdlg.cxx +++ b/cui/source/dialogs/screenshotannotationdlg.cxx @@ -54,7 +54,7 @@ namespace OUString lcl_AltDescr() { - OUString aTempl = OUString("<alt xml-lang=en-US id=%1>" + OUString aTempl = OUString("<alt xml-lang=\"en-US\" id=\"%1\">" " " //FIXME real dialog title or something "</alt>"); aTempl = aTempl.replaceFirst( "%1", lcl_genRandom("alt_id") ); @@ -64,8 +64,8 @@ namespace OUString lcl_Image( const OUString& rScreenshotId, const Size& rSize ) { - OUString aTempl = OUString("<image id=%1 src=media/screenshots/%2.png" - " width=%3cm height=%4cm>" + OUString aTempl = OUString("<image id=\"%1\" src=\"media/screenshots/%2.png\"" + " width=\"%3cm\" height=\"%4cm\">" "%5" "</image>"); aTempl = aTempl.replaceFirst( "%1", lcl_genRandom("img_id") ); @@ -79,7 +79,7 @@ namespace OUString lcl_ParagraphWithImage( const OUString& rScreenshotId, const Size& rSize ) { - OUString aTempl = OUString( "<paragraph id=%1 role=\"paragraph\" xml-lang=en-US>%2" + OUString aTempl = OUString( "<paragraph id=\"%1\" role=\"paragraph\" xml-lang=\"en-US\">%2" "</paragraph>" SAL_NEWLINE_STRING ); aTempl = aTempl.replaceFirst( "%1", lcl_genRandom("par_id") ); aTempl = aTempl.replaceFirst( "%2", lcl_Image(rScreenshotId, rSize) ); @@ -90,7 +90,7 @@ namespace OUString lcl_Bookmark( const OUString& rWidgetId ) { OUString aTempl = "<!-- Bookmark for widget %1 -->" SAL_NEWLINE_STRING - "<bookmark xml-lang=en-US branch=hid/%2 id=%3 localize=\"false\"/>" SAL_NEWLINE_STRING; + "<bookmark xml-lang=\"en-US\" branch=\"hid/%2\" id=\"%3\" localize=\"false\"/>" SAL_NEWLINE_STRING; aTempl = aTempl.replaceFirst( "%1", rWidgetId ); aTempl = aTempl.replaceFirst( "%2", rWidgetId ); aTempl = aTempl.replaceFirst( "%3", lcl_genRandom("bm_id") ); _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits