-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi
Em 13-12-2011 06:04, Ivan Timofeev escreveu: > Hi Olivier, > > 13.12.2011 05:08, Olivier Hallot пишет: >> Please find attached a partial fix for Easy Hack FDO43460 >> >> Part VII >> Module >> comphelper > > Not sure whether this improves readability: > > +++ b/comphelper/source/misc/storagehelper.cxx > @@ -522,7 +522,7 @@ sal_Bool OStorageHelper::PathHasSegment( const > ::rtl::OUString& aPath, const ::r > const sal_Int32 nPathLen = aPath.getLength(); > const sal_Int32 nSegLen = aSegment.getLength(); > > - if ( nSegLen && nPathLen >= nSegLen ) > + if ( !aSegment.isEmpty() && nPathLen >= nSegLen ) > { > ::rtl::OUString aEndSegment( RTL_CONSTASCII_USTRINGPARAM( "/" ) ); > aEndSegment += aSegment; > > and in the script this is described as false positive. So I dropped this > change and pushed: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=00a67c0f9056729695e6004707d64b448756fa6f Thanks. I agree it was a bit weird, so I tossed a coin and changed it at the end. > > > This easy hack is not so easy due to its enormous monotony. ;) Thank you > for doing this! I know, and that is why I'm doing it in parts and slowly. Thanks for reviewing and pushing it. - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJO5w7TAAoJEJp3R7nH3vLxG4UIAK/5pA5cXutbLqtUvVmkz9Bj /Kwpwr8mG6cHaq31/Do73l2sDb2qe0zsNYXY1bnIFx3/b23jURDTj0Up5IzNbDJ2 5Ob1q6DiH+L2YkMagYx5hMTCvBwJ3o9KcUP8BSQUB4k855ejk+QupumLlzIT0yGA hRhuTlIH1/ORfO1Sxkfc2zZ78eU+7ph3HLYGfEr+PD5xUfi4dSVkQZaAzxGWkcRv 4eLOSmUsuhzsJHKVeVDu99W5cWD6rUHmQXtQnOdB8LoKsTjfA+72bS58qI3ENtBY RXLAn6pWI274pCOual5Po2UDzZR76nAGu0TmqUV6KctHzE/1CxHsqfphMWcZiqM= =7lgO -----END PGP SIGNATURE----- _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice