Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
4 new defect(s) introduced to LibreOffice found with Coverity Scan.
9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1426315: Control flow issues (DEADCODE)
/sw/source/core/layout/flylay.cxx: 720 in SwFlyLayFrame::Modify(const
SfxPoolItem *, const SfxPoolItem *)()
________________________________________________________________________________________________________
*** CID 1426315: Control flow issues (DEADCODE)
/sw/source/core/layout/flylay.cxx: 720 in SwFlyLayFrame::Modify(const
SfxPoolItem *, const SfxPoolItem *)()
714 void SwFlyLayFrame::Modify( const SfxPoolItem* pOld, const SfxPoolItem
*pNew )
715 {
716 const SwFormatAnchor *pAnch = nullptr;
717
718 if (pNew)
719 {
>>> CID 1426315: Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "0" inside this statement:
>>> "nWhich = (pNew ? pNew->Whic...".
720 const sal_uInt16 nWhich = pNew ? pNew->Which() : 0;
721 if( RES_ATTRSET_CHG == nWhich && SfxItemState::SET ==
722 static_cast<const
SwAttrSetChg*>(pNew)->GetChgSet()->GetItemState( RES_ANCHOR, false,
723 reinterpret_cast<const SfxPoolItem**>(&pAnch) ))
724 ; // GetItemState sets the anchor pointer!
725
** CID 1426314: Resource leaks (RESOURCE_LEAK)
/vcl/unx/generic/plugadapt/salplug.cxx: 130 in tryInstance(const rtl::OUString
&, bool)()
________________________________________________________________________________________________________
*** CID 1426314: Resource leaks (RESOURCE_LEAK)
/vcl/unx/generic/plugadapt/salplug.cxx: 130 in tryInstance(const rtl::OUString
&, bool)()
124 }
125 else
126 {
127 SAL_INFO("vcl.plugadapt", "could not load shared object " <<
aModule);
128 }
129
>>> CID 1426314: Resource leaks (RESOURCE_LEAK)
>>> Variable "aMod" going out of scope leaks the storage it points to.
130 return pInst;
131 }
132
133 #if !defined(ANDROID)
134
135 namespace {
** CID 1426313: Error handling issues (CHECKED_RETURN)
/vcl/source/window/builder.cxx: 1645 in VclBuilder::makeObject(vcl::Window *,
const rtl::OString &, const rtl::OString &, std::map<rtl::OString,
rtl::OUString, std::less<rtl::OString>, std::allocator<std::pair<const
rtl::OString, rtl::OUString>>> &)()
________________________________________________________________________________________________________
*** CID 1426313: Error handling issues (CHECKED_RETURN)
/vcl/source/window/builder.cxx: 1645 in VclBuilder::makeObject(vcl::Window *,
const rtl::OString &, const rtl::OString &, std::map<rtl::OString,
rtl::OUString, std::less<rtl::OString>, std::allocator<std::pair<const
rtl::OString, rtl::OUString>>> &)()
1639 pModule->loadRelative(&thisModule, sMergedModule);
1640 if (!pModule->getFunctionSymbol(sFunction))
1641 {
1642 pModule->loadRelative(&thisModule, sModule);
1643 }
1644 #else
>>> CID 1426313: Error handling issues (CHECKED_RETURN)
>>> Calling "loadRelative" without checking return value (as is done
>>> elsewhere 4 out of 5 times).
1645 pModule->loadRelative(&thisModule, sModule);
1646 #endif
1647 aI = m_aModuleMap.insert(std::make_pair(sModule,
std::unique_ptr<osl::Module>(pModule))).first;
1648 }
1649 customMakeWidget pFunction =
reinterpret_cast<customMakeWidget>(aI->second->getFunctionSymbol(sFunction));
1650 #else
** CID 1426312: Error handling issues (CHECKED_RETURN)
/desktop/source/deployment/gui/dp_gui_updateinstalldialog.cxx: 600 in
dp_gui::UpdateInstallDialog::Thread::download(const rtl::OUString &,
dp_gui::UpdateData &)()
________________________________________________________________________________________________________
*** CID 1426312: Error handling issues (CHECKED_RETURN)
/desktop/source/deployment/gui/dp_gui_updateinstalldialog.cxx: 600 in
dp_gui::UpdateInstallDialog::Thread::download(const rtl::OUString &,
dp_gui::UpdateData &)()
594 destFolder += "_";
595
596 ::ucbhelper::Content destFolderContent;
597 dp_misc::create_folder( &destFolderContent, destFolder,
m_updateCmdEnv.get() );
598
599 ::ucbhelper::Content sourceContent;
>>> CID 1426312: Error handling issues (CHECKED_RETURN)
>>> Calling "create_ucb_content" without checking return value (as is done
>>> elsewhere 5 out of 6 times).
600 dp_misc::create_ucb_content( &sourceContent, sDownloadURL,
m_updateCmdEnv.get() );
601
602 const OUString sTitle( StrTitle::getTitle( sourceContent ) );
603
604 if (destFolderContent.transferContent(
605 sourceContent, ::ucbhelper::InsertOperation::Copy,
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy9pa4iwSL8PLY3tc4tmEy7PxST-2B7VOWxY6aIbCZW01nlU98qIYl0AWIuF3AUv6H86Flc-2B84p081oY-2BXchhYVL0Mtr151D-2FVRl1-2FnbvQQ2yGL5H1P84fmLCqrjz51XX1PIWfjl4r-2FqfGYzgt-2ByOQi8Smta9LOLsPC-2FWhikMFKDe5I-3D
To manage Coverity Scan email notifications for
"libreoffice@lists.freedesktop.org", click
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5lwWgMDuK-2FivqaohkU3M9kT-2Fww10Qt2GoaCJAOQCa0Wv4ijH4oV8jCt0XXa7QeAwh_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy9pa4iwSL8PLY3tc4tmEy7HZffY0Snfpb9KEXtUKQGJt5U3FWQ4VTG1mHVRNZxPD-2BWE1hTnNwMGu41tGn8zPIOscAGdYOaQ615xiXNXQrtTpVjl-2BBRDjZEddZaAON2QzLkIqzsVXra4cQxaJGPLOnWn4yT5K9vEFg-2BBMj-2B5MSLMg-3D
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
