Hi Christina,

Nice find. Just to mention that this

> +    SAL_DLLPRIVATE Color ImplDrawModeToColor( Color );
> +Color OutputDevice::ImplDrawModeToColor( const Color rColor )

not only should be a const method as Stephan mentioned, but also should
get passed a   const Color& rColor   reference instead, otherwise an
unnecessary temporary copy of the Color object would be created as
argument. Muthu already changed that in the commit.

Thanks
  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpVymLOJwztV.pgp
Description: PGP signature

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to