svl/source/notify/listener.cxx | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit d02d57d5c2bbe38722f848460a02511749e50957
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Tue Oct 2 12:25:42 2018 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Tue Oct 2 15:09:34 2018 +0200
fix bug in SvtListener copy constructor
it was copying maBroadcasters, without actually starting to listen to
those broadcasters, which means if we __did__ call StartListening, that
method would have just returned early.
Since nothing seems to need this functionality, and it's not obvious
what the correct behaviour would be, just don't do the copy.
Change-Id: If5865fa3449839758a43ac537475e0a474f39078
Reviewed-on: https://gerrit.libreoffice.org/61239
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/svl/source/notify/listener.cxx b/svl/source/notify/listener.cxx
index c668397baa47..6a54f6465c75 100644
--- a/svl/source/notify/listener.cxx
+++ b/svl/source/notify/listener.cxx
@@ -31,8 +31,7 @@ sal_uInt16 SvtListener::QueryBase::getId() const
SvtListener::SvtListener() {}
-SvtListener::SvtListener( const SvtListener &r ) :
- maBroadcasters(r.maBroadcasters) {}
+SvtListener::SvtListener( const SvtListener & ) {}
SvtListener::~SvtListener() COVERITY_NOEXCEPT_FALSE
{
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
