sc/IwyuFilter_sc.yaml | 7 +++----
sc/inc/AccessibleFilterMenu.hxx | 6 ------
sc/inc/column.hxx | 3 ---
sc/inc/datamapper.hxx | 1 -
sc/inc/dpresfilter.hxx | 1 -
sc/inc/dpshttab.hxx | 4 ----
sc/inc/dptabdat.hxx | 4 ----
sc/inc/dptabsrc.hxx | 3 ---
sc/inc/formulacell.hxx | 1 -
sc/inc/interpretercontext.hxx | 6 +++++-
sc/inc/listenercalls.hxx | 3 ---
sc/inc/markdata.hxx | 1 -
sc/inc/scmatrix.hxx | 2 --
sc/inc/token.hxx | 6 ------
sc/inc/validat.hxx | 1 -
sc/source/core/tool/chartlis.cxx | 1 +
sc/source/core/tool/interpretercontext.cxx | 2 +-
sc/source/filter/inc/externallinkfragment.hxx | 2 --
sc/source/filter/inc/sheetdatabuffer.hxx | 2 +-
sc/source/filter/inc/xiescher.hxx | 2 --
20 files changed, 11 insertions(+), 47 deletions(-)
New commits:
commit 7513af89362a7d54e0210049d3644db5818950a5
Author: Gabor Kelemen <kelem...@ubuntu.com>
AuthorDate: Wed Oct 24 01:43:47 2018 +0200
Commit: Miklos Vajna <vmik...@collabora.co.uk>
CommitDate: Wed Oct 31 09:05:24 2018 +0100
tdf#42949 Fix IWYU warnings in sc/inc; sc/source/filter/inc/
Found with bin/find-unneeded-includes after recent improvements
- remove UNO headers from blacklist
- remove newly found unneeded fw declarations
- fix up some not self contained headers
Change-Id: I605656bc98a64640a78d2ff4de9c7c37326033cf
Reviewed-on: https://gerrit.libreoffice.org/62264
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmik...@collabora.co.uk>
diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 0b8fff456db7..e3c0a348db21 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -10,9 +10,6 @@ blacklist:
sc/inc/AccessibleFilterMenuItem.hxx:
# base class has to be a complete type
- com/sun/star/accessibility/XAccessibleAction.hpp
- sc/inc/address.hxx:
- # base class has to be a complete type
- - com/sun/star/uno/Sequence.hxx
sc/inc/addruno.hxx:
# base class has to be a complete type
- com/sun/star/beans/XPropertySet.hpp
@@ -79,6 +76,8 @@ blacklist:
sc/inc/conditio.hxx:
# base class has to be a complete type
- tools/link.hxx
+ # Used as type for a boost::optional variable
+ - tools/color.hxx
sc/inc/dapiuno.hxx:
# base class has to be a complete type
- com/sun/star/container/XEnumerationAccess.hpp
@@ -202,6 +201,7 @@ blacklist:
- memory
# needed for conditionally enabled code path
- struct ScFormulaCellGroup
+ - namespace osl { class File; }
sc/inc/formulaparserpool.hxx:
# base class has to be a complete type
- com/sun/star/sheet/XFormulaParser.hpp
@@ -215,7 +215,6 @@ blacklist:
- com/sun/star/sheet/XFunctionAccess.hpp
sc/inc/global.hxx:
# base class has to be a complete type
- - com/sun/star/uno/Reference.hxx
- tools/ref.hxx
sc/inc/linkuno.hxx:
# base class has to be a complete type
diff --git a/sc/inc/AccessibleFilterMenu.hxx b/sc/inc/AccessibleFilterMenu.hxx
index f5ede6e03f81..878c27a637c3 100644
--- a/sc/inc/AccessibleFilterMenu.hxx
+++ b/sc/inc/AccessibleFilterMenu.hxx
@@ -28,12 +28,6 @@
#include <vector>
-namespace com { namespace sun { namespace star {
- namespace accessibility {
- struct AccessibleEventObject;
- }
-}}}
-
class ScMenuFloatingWindow;
typedef ::cppu::ImplHelper1<
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index ffa43e12ea94..bdaeccde0afe 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -40,7 +40,6 @@ namespace formula { struct VectorRefArray; }
namespace sc {
-struct FormulaGroupContext;
struct FormulaGroupEntry;
class StartListeningContext;
class EndListeningContext;
@@ -49,7 +48,6 @@ class CopyToClipContext;
class CopyToDocContext;
class MixDocContext;
class ColumnSpanSet;
-struct ColumnBlockPosition;
class SingleColumnSpanSet;
struct RefUpdateContext;
struct RefUpdateInsertTabContext;
@@ -64,7 +62,6 @@ struct RowSpan;
class RowHeightContext;
class CompileFormulaContext;
struct SetFormulaDirtyContext;
-class RefMovedHint;
enum class MatrixEdge;
class ColumnIterator;
diff --git a/sc/inc/datamapper.hxx b/sc/inc/datamapper.hxx
index 27bb011521cf..d54e1a81c2ed 100644
--- a/sc/inc/datamapper.hxx
+++ b/sc/inc/datamapper.hxx
@@ -24,7 +24,6 @@ namespace sc {
class ScDBDataManager;
class DataProvider;
-class ScDBDataManager;
class DataTransformation;
class SC_DLLPUBLIC ExternalDataSource
diff --git a/sc/inc/dpresfilter.hxx b/sc/inc/dpresfilter.hxx
index 7fed71374dd4..a66a8469f987 100644
--- a/sc/inc/dpresfilter.hxx
+++ b/sc/inc/dpresfilter.hxx
@@ -58,7 +58,6 @@ public:
private:
struct MemberNode;
- struct DimensionNode;
typedef std::map<OUString, std::shared_ptr<MemberNode> > MembersType;
struct DimensionNode
diff --git a/sc/inc/dpshttab.hxx b/sc/inc/dpshttab.hxx
index 9d2cc6e4697d..3b15cefd117e 100644
--- a/sc/inc/dpshttab.hxx
+++ b/sc/inc/dpshttab.hxx
@@ -28,10 +28,6 @@
#include <unordered_set>
#include <vector>
-namespace com { namespace sun { namespace star { namespace sheet {
- struct DataPilotFieldFilter;
-}}}}
-
class ScDPDimensionSaveData;
/**
diff --git a/sc/inc/dptabdat.hxx b/sc/inc/dptabdat.hxx
index b0dc99031dfa..3df053e36da8 100644
--- a/sc/inc/dptabdat.hxx
+++ b/sc/inc/dptabdat.hxx
@@ -28,10 +28,6 @@
#include <unordered_set>
#include <vector>
-namespace com { namespace sun { namespace star { namespace sheet {
- struct DataPilotFieldFilter;
-}}}}
-
#define SC_DAPI_HIERARCHY_FLAT 0
#define SC_DAPI_HIERARCHY_QUARTER 1
#define SC_DAPI_HIERARCHY_WEEK 2
diff --git a/sc/inc/dptabsrc.hxx b/sc/inc/dptabsrc.hxx
index 3d5d9778da90..4c222f13edc1 100644
--- a/sc/inc/dptabsrc.hxx
+++ b/sc/inc/dptabsrc.hxx
@@ -55,9 +55,6 @@ namespace com { namespace sun { namespace star {
struct DataPilotFieldFilter;
struct MemberResult;
}
- namespace table {
- struct CellAddress;
- }
}}}
class ScDPResultMember;
diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx
index d0842e8e0a3e..3af68fbbfadc 100644
--- a/sc/inc/formulacell.hxx
+++ b/sc/inc/formulacell.hxx
@@ -32,7 +32,6 @@
namespace sc {
-class CompiledFormula;
class StartListeningContext;
class EndListeningContext;
struct RefUpdateContext;
diff --git a/sc/inc/interpretercontext.hxx b/sc/inc/interpretercontext.hxx
index 2855370e7b09..b12bf17410a4 100644
--- a/sc/inc/interpretercontext.hxx
+++ b/sc/inc/interpretercontext.hxx
@@ -11,9 +11,13 @@
#define INCLUDED_SC_INC_INTERPRETERCONTEXT_HXX
#include <vector>
-#include <formula/token.hxx>
#include "types.hxx"
+namespace formula
+{
+class FormulaToken;
+}
+
#define TOKEN_CACHE_SIZE 8
class ScDocument;
diff --git a/sc/inc/listenercalls.hxx b/sc/inc/listenercalls.hxx
index d9f1a476af6c..6e71be294335 100644
--- a/sc/inc/listenercalls.hxx
+++ b/sc/inc/listenercalls.hxx
@@ -28,9 +28,6 @@ namespace com { namespace sun { namespace star {
namespace util {
class XModifyListener;
}
- namespace lang {
- struct EventObject;
- }
} } }
struct ScUnoListenerEntry
diff --git a/sc/inc/markdata.hxx b/sc/inc/markdata.hxx
index c4497da322d6..ca1443a5ace0 100644
--- a/sc/inc/markdata.hxx
+++ b/sc/inc/markdata.hxx
@@ -30,7 +30,6 @@
namespace sc {
-struct RowSpan;
struct ColRowSpan;
}
diff --git a/sc/inc/scmatrix.hxx b/sc/inc/scmatrix.hxx
index 7b08d5e0eb6d..4b58cd19217b 100644
--- a/sc/inc/scmatrix.hxx
+++ b/sc/inc/scmatrix.hxx
@@ -39,8 +39,6 @@ class SvNumberFormatter;
class ScMatrixImpl;
enum class FormulaError : sal_uInt16;
-namespace formula { class DoubleVectorRefToken; }
-
namespace sc {
struct Compare;
diff --git a/sc/inc/token.hxx b/sc/inc/token.hxx
index c55230223b1f..e0507eb93ad9 100644
--- a/sc/inc/token.hxx
+++ b/sc/inc/token.hxx
@@ -33,12 +33,6 @@
// Matrix token constants.
#define MATRIX_TOKEN_HAS_RANGE 1
-namespace sc {
-
-struct RangeMatrix;
-
-}
-
class ScJumpMatrix;
class ScMatrix;
diff --git a/sc/inc/validat.hxx b/sc/inc/validat.hxx
index a37df6a00127..f9e24adba552 100644
--- a/sc/inc/validat.hxx
+++ b/sc/inc/validat.hxx
@@ -23,7 +23,6 @@
#include "conditio.hxx"
#include "scdllapi.h"
-namespace vcl { class Window; }
namespace weld { class Window; }
namespace sc {
diff --git a/sc/source/core/tool/chartlis.cxx b/sc/source/core/tool/chartlis.cxx
index 80a974e382a4..8ef3edfc1c3d 100644
--- a/sc/source/core/tool/chartlis.cxx
+++ b/sc/source/core/tool/chartlis.cxx
@@ -24,6 +24,7 @@
#include <brdcst.hxx>
#include <document.hxx>
#include <reftokenhelper.hxx>
+#include <formula/token.hxx>
#include <com/sun/star/chart/XChartDataChangeEventListener.hpp>
using namespace com::sun::star;
diff --git a/sc/source/core/tool/interpretercontext.cxx
b/sc/source/core/tool/interpretercontext.cxx
index 35e77694a50d..e7fe0fef6593 100644
--- a/sc/source/core/tool/interpretercontext.cxx
+++ b/sc/source/core/tool/interpretercontext.cxx
@@ -18,7 +18,7 @@
*/
#include <interpretercontext.hxx>
-
+#include <formula/token.hxx>
#include <lookupcache.hxx>
ScInterpreterContext::~ScInterpreterContext()
diff --git a/sc/source/filter/inc/externallinkfragment.hxx
b/sc/source/filter/inc/externallinkfragment.hxx
index ec82be81affe..e2964c961401 100644
--- a/sc/source/filter/inc/externallinkfragment.hxx
+++ b/sc/source/filter/inc/externallinkfragment.hxx
@@ -26,8 +26,6 @@
namespace oox {
namespace xls {
-class ExternalLink;
-
/** This class implements importing the sheetData element in external sheets.
The sheetData element embedded in the externalBook element contains cached
diff --git a/sc/source/filter/inc/sheetdatabuffer.hxx
b/sc/source/filter/inc/sheetdatabuffer.hxx
index 1cd4b1db7488..3b4354421b5b 100644
--- a/sc/source/filter/inc/sheetdatabuffer.hxx
+++ b/sc/source/filter/inc/sheetdatabuffer.hxx
@@ -26,6 +26,7 @@
#include "richstring.hxx"
#include "worksheethelper.hxx"
+#include "addressconverter.hxx"
namespace com { namespace sun { namespace star {
namespace util { struct DateTime; }
@@ -151,7 +152,6 @@ public:
const ScAddress& rCellAddr,
const ApiTokenSequence& rTokens );
private:
- struct XfIdRowRange;
/** Creates a formula token array representing the shared formula with the
passed identifier. */
diff --git a/sc/source/filter/inc/xiescher.hxx
b/sc/source/filter/inc/xiescher.hxx
index f984725ef4df..f9e8d007724e 100644
--- a/sc/source/filter/inc/xiescher.hxx
+++ b/sc/source/filter/inc/xiescher.hxx
@@ -46,8 +46,6 @@ class XclImpChart;
class XclImpDffConverter;
class XclImpDrawing;
-struct SdrObjectFreeOp;
-
// Drawing objects ============================================================
class XclImpDrawObjBase;
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
