[Libreoffice-commits] core.git: include/sax

[Mike Kaganski (via logerrit)]

 include/sax/fshelper.hxx |   44 --------------------------------------------
 1 file changed, 44 deletions(-)

New commits:
commit cab700c69edc4a0b66a60e80b2852380217163cd
Author:     Mike Kaganski <mike.kagan...@collabora.com>
AuthorDate: Fri Apr 19 00:20:36 2019 +0200
Commit:     Mike Kaganski <mike.kagan...@collabora.com>
CommitDate: Fri Apr 19 06:12:46 2019 +0200

    Remove redundant functions from FastSerializerHelper
    
    They are identical to what compiler autogenerates from templated overload
    
    Change-Id: I0b1361a5dae7e6520a1ec21d735fdebbe0c9a76e
    Reviewed-on: https://gerrit.libreoffice.org/70959
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com>

diff --git a/include/sax/fshelper.hxx b/include/sax/fshelper.hxx
index e46a1fab60b7..c5148dcd0b00 100644
--- a/include/sax/fshelper.hxx
+++ b/include/sax/fshelper.hxx
@@ -63,23 +63,12 @@ public:
             pushAttributeValue(attribute, value);
         startElement(elementTokenId, std::forward<Args>(args)...);
     }
-    void startElement(sal_Int32 elementTokenId, sal_Int32 attribute, const 
char* value, FSEND_t)
-    {
-        if (value)
-            pushAttributeValue(attribute, value);
-        startElement(elementTokenId, FSEND);
-    }
     template<typename... Args>
     void startElement(sal_Int32 elementTokenId, sal_Int32 attribute, const 
OString& value, Args &&... args)
     {
         pushAttributeValue(attribute, value);
         startElement(elementTokenId, std::forward<Args>(args)...);
     }
-    void startElement(sal_Int32 elementTokenId, sal_Int32 attribute, const 
OString& value, FSEND_t)
-    {
-        pushAttributeValue(attribute, value);
-        startElement(elementTokenId, FSEND);
-    }
     void startElement(sal_Int32 elementTokenId, FSEND_t);
 
     /// Start an element. After the first two arguments there can be a number 
of (attribute, value) pairs.
@@ -90,23 +79,12 @@ public:
             pushAttributeValue(attribute, value);
         startElementNS(namespaceTokenId, elementTokenId, 
std::forward<Args>(args)...);
     }
-    void startElementNS(sal_Int32 namespaceTokenId, sal_Int32 elementTokenId, 
sal_Int32 attribute, const char* value, FSEND_t)
-    {
-        if (value)
-            pushAttributeValue(attribute, value);
-        startElementNS(namespaceTokenId, elementTokenId, FSEND);
-    }
     template<typename... Args>
     void startElementNS(sal_Int32 namespaceTokenId, sal_Int32 elementTokenId, 
sal_Int32 attribute, const OString& value, Args &&... args)
     {
         pushAttributeValue(attribute, value);
         startElementNS(namespaceTokenId, elementTokenId, 
std::forward<Args>(args)...);
     }
-    void startElementNS(sal_Int32 namespaceTokenId, sal_Int32 elementTokenId, 
sal_Int32 attribute, const OString& value, FSEND_t)
-    {
-        pushAttributeValue(attribute, value);
-        startElementNS(namespaceTokenId, elementTokenId, FSEND);
-    }
     void startElementNS(sal_Int32 namespaceTokenId, sal_Int32 elementTokenId, 
FSEND_t)
     {
         startElement(FSNS(namespaceTokenId, elementTokenId), FSEND);
@@ -120,23 +98,12 @@ public:
             pushAttributeValue(attribute, value);
         singleElement(elementTokenId, std::forward<Args>(args)...);
     }
-    void singleElement(sal_Int32 elementTokenId, sal_Int32 attribute, const 
char* value, FSEND_t)
-    {
-        if (value)
-            pushAttributeValue(attribute, value);
-        singleElement(elementTokenId, FSEND);
-    }
     template<typename... Args>
     void singleElement(sal_Int32 elementTokenId, sal_Int32 attribute, const 
OString& value, Args &&... args)
     {
         pushAttributeValue(attribute, value);
         singleElement(elementTokenId, std::forward<Args>(args)...);
     }
-    void singleElement(sal_Int32 elementTokenId, sal_Int32 attribute, const 
OString& value, FSEND_t)
-    {
-        pushAttributeValue(attribute, value);
-        singleElement(elementTokenId, FSEND);
-    }
     void singleElement(sal_Int32 elementTokenId, FSEND_t);
 
     /// Create a single element. After the first two arguments there can be a 
number of (attribute, value) pairs.
@@ -147,23 +114,12 @@ public:
             pushAttributeValue(attribute, value);
         singleElementNS(namespaceTokenId, elementTokenId, 
std::forward<Args>(args)...);
     }
-    void singleElementNS(sal_Int32 namespaceTokenId, sal_Int32 elementTokenId, 
sal_Int32 attribute, const char* value, FSEND_t)
-    {
-        if (value)
-            pushAttributeValue(attribute, value);
-        singleElementNS(namespaceTokenId, elementTokenId, FSEND);
-    }
     template<typename... Args>
     void singleElementNS(sal_Int32 namespaceTokenId, sal_Int32 elementTokenId, 
sal_Int32 attribute, const OString& value, Args &&... args)
     {
         pushAttributeValue(attribute, value);
         singleElementNS(namespaceTokenId, elementTokenId, 
std::forward<Args>(args)...);
     }
-    void singleElementNS(sal_Int32 namespaceTokenId, sal_Int32 elementTokenId, 
sal_Int32 attribute, const OString& value, FSEND_t)
-    {
-        pushAttributeValue(attribute, value);
-        singleElementNS(namespaceTokenId, elementTokenId, FSEND);
-    }
     void singleElementNS(sal_Int32 namespaceTokenId, sal_Int32 elementTokenId, 
FSEND_t)
     {
         singleElement(FSNS(namespaceTokenId, elementTokenId), FSEND);
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits