cui/uiconfig/ui/assigncomponentdialog.ui | 6 ++++
cui/uiconfig/ui/blackorwhitelistentrydialog.ui | 37 +++++++++++++++++++++++--
cui/uiconfig/ui/breaknumberoption.ui | 26 ++++++++++++++---
cui/uiconfig/ui/storedwebconnectiondialog.ui | 6 ++++
cui/uiconfig/ui/tsaurldialog.ui | 6 ++++
solenv/sanitizers/ui/cui.suppr | 17 -----------
6 files changed, 75 insertions(+), 23 deletions(-)
New commits:
commit 885ae69174cf717edd00526e5cf8f1585c505c95
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Fri Aug 2 09:16:36 2019 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Fri Aug 2 10:13:32 2019 +0200
fix some accessibility warnings
Change-Id: I18f9a71ac4e2ef5c159e13bc3cb0e36cf7c550a5
Reviewed-on: https://gerrit.libreoffice.org/76834
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/cui/uiconfig/ui/assigncomponentdialog.ui
b/cui/uiconfig/ui/assigncomponentdialog.ui
index 9fbfcb538a6a..4c77b44f330c 100644
--- a/cui/uiconfig/ui/assigncomponentdialog.ui
+++ b/cui/uiconfig/ui/assigncomponentdialog.ui
@@ -93,6 +93,9 @@
<property name="can_focus">False</property>
<property name="halign">start</property>
<property name="label" translatable="yes"
context="assigncomponentdialog|label1">Component method name:</property>
+ <accessibility>
+ <relation type="label-for" target="methodEntry"/>
+ </accessibility>
</object>
<packing>
<property name="expand">False</property>
@@ -106,6 +109,9 @@
<property name="can_focus">True</property>
<property name="hexpand">True</property>
<property name="activates_default">True</property>
+ <accessibility>
+ <relation type="labelled-by" target="label1"/>
+ </accessibility>
</object>
<packing>
<property name="expand">False</property>
diff --git a/cui/uiconfig/ui/blackorwhitelistentrydialog.ui
b/cui/uiconfig/ui/blackorwhitelistentrydialog.ui
index 3336f28a835f..485957da7b4b 100644
--- a/cui/uiconfig/ui/blackorwhitelistentrydialog.ui
+++ b/cui/uiconfig/ui/blackorwhitelistentrydialog.ui
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated with glade 3.18.3 -->
+<!-- Generated with glade 3.22.1 -->
<interface domain="cui">
<requires lib="gtk+" version="3.18"/>
<object class="GtkListStore" id="os-liststore">
@@ -31,8 +31,11 @@
<object class="GtkDialog" id="BlackOrWhiteListEntryDialog">
<property name="can_focus">False</property>
<property name="border_width">6</property>
- <property name="title" translatable="no">dummy</property>
+ <property name="title">dummy</property>
<property name="type_hint">dialog</property>
+ <child>
+ <placeholder/>
+ </child>
<child internal-child="vbox">
<object class="GtkBox" id="dialog-vbox1">
<property name="can_focus">False</property>
@@ -126,6 +129,9 @@
<property name="can_focus">False</property>
<property name="hexpand">True</property>
<property name="model">os-liststore</property>
+ <accessibility>
+ <relation type="labelled-by" target="label4"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">1</property>
@@ -138,6 +144,9 @@
<property name="can_focus">True</property>
<property name="hexpand">True</property>
<property name="width_chars">22</property>
+ <accessibility>
+ <relation type="labelled-by" target="label5"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">1</property>
@@ -150,6 +159,9 @@
<property name="can_focus">True</property>
<property name="hexpand">True</property>
<property name="width_chars">12</property>
+ <accessibility>
+ <relation type="labelled-by" target="label6"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">1</property>
@@ -162,6 +174,9 @@
<property name="can_focus">True</property>
<property name="hexpand">True</property>
<property name="width_chars">22</property>
+ <accessibility>
+ <relation type="labelled-by" target="label7"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">1</property>
@@ -174,6 +189,9 @@
<property name="can_focus">True</property>
<property name="hexpand">True</property>
<property name="width_chars">22</property>
+ <accessibility>
+ <relation type="labelled-by" target="label8"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">1</property>
@@ -187,6 +205,9 @@
<property name="halign">end</property>
<property name="label" translatable="yes"
context="blackorwhitelistentrydialog|label4">Operating system:</property>
<property name="use_underline">True</property>
+ <accessibility>
+ <relation type="label-for" target="os"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">0</property>
@@ -200,6 +221,9 @@
<property name="halign">end</property>
<property name="label" translatable="yes"
context="blackorwhitelistentrydialog|label5">Version:</property>
<property name="use_underline">True</property>
+ <accessibility>
+ <relation type="label-for" target="osversion"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">0</property>
@@ -213,6 +237,9 @@
<property name="halign">end</property>
<property name="label" translatable="yes"
context="blackorwhitelistentrydialog|label6">OpenCL vendor:</property>
<property name="use_underline">True</property>
+ <accessibility>
+ <relation type="label-for"
target="platformvendor"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">0</property>
@@ -226,6 +253,9 @@
<property name="halign">end</property>
<property name="label" translatable="yes"
context="blackorwhitelistentrydialog|label7">Device:</property>
<property name="use_underline">True</property>
+ <accessibility>
+ <relation type="label-for" target="device"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">0</property>
@@ -239,6 +269,9 @@
<property name="halign">end</property>
<property name="label" translatable="yes"
context="blackorwhitelistentrydialog|label8">Driver version:</property>
<property name="use_underline">True</property>
+ <accessibility>
+ <relation type="label-for"
target="driverversion"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">0</property>
diff --git a/cui/uiconfig/ui/breaknumberoption.ui
b/cui/uiconfig/ui/breaknumberoption.ui
index 0f60f687762d..c2cae417ec2f 100644
--- a/cui/uiconfig/ui/breaknumberoption.ui
+++ b/cui/uiconfig/ui/breaknumberoption.ui
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated with glade 3.20.4 -->
+<!-- Generated with glade 3.22.1 -->
<interface domain="cui">
<requires lib="gtk+" version="3.18"/>
<object class="GtkAdjustment" id="adjustment1">
@@ -17,6 +17,9 @@
<property name="default_width">0</property>
<property name="default_height">0</property>
<property name="type_hint">dialog</property>
+ <child>
+ <placeholder/>
+ </child>
<child internal-child="vbox">
<object class="GtkBox" id="dialog-vbox1">
<property name="can_focus">False</property>
@@ -88,6 +91,9 @@
<property name="halign">start</property>
<property name="activates_default">True</property>
<property name="adjustment">adjustment1</property>
+ <accessibility>
+ <relation type="labelled-by" target="beforelabel"/>
+ </accessibility>
</object>
</child>
</object>
@@ -100,6 +106,9 @@
<attributes>
<attribute name="weight" value="bold"/>
</attributes>
+ <accessibility>
+ <relation type="label-for" target="beforebreak"/>
+ </accessibility>
</object>
</child>
</object>
@@ -127,6 +136,9 @@
<property name="halign">start</property>
<property name="activates_default">True</property>
<property name="adjustment">adjustment1</property>
+ <accessibility>
+ <relation type="labelled-by" target="afterlabel"/>
+ </accessibility>
</object>
</child>
</object>
@@ -139,6 +151,9 @@
<attributes>
<attribute name="weight" value="bold"/>
</attributes>
+ <accessibility>
+ <relation type="label-for" target="afterbreak"/>
+ </accessibility>
</object>
</child>
</object>
@@ -166,6 +181,9 @@
<property name="halign">start</property>
<property name="activates_default">True</property>
<property name="adjustment">adjustment1</property>
+ <accessibility>
+ <relation type="labelled-by" target="minimallabel"/>
+ </accessibility>
</object>
</child>
</object>
@@ -178,6 +196,9 @@
<attributes>
<attribute name="weight" value="bold"/>
</attributes>
+ <accessibility>
+ <relation type="label-for" target="wordlength"/>
+ </accessibility>
</object>
</child>
</object>
@@ -199,8 +220,5 @@
<action-widget response="-5">ok</action-widget>
<action-widget response="-6">cancel</action-widget>
</action-widgets>
- <child>
- <placeholder/>
- </child>
</object>
</interface>
diff --git a/cui/uiconfig/ui/storedwebconnectiondialog.ui
b/cui/uiconfig/ui/storedwebconnectiondialog.ui
index 69f2c30b9b79..e61d6ac0aa43 100644
--- a/cui/uiconfig/ui/storedwebconnectiondialog.ui
+++ b/cui/uiconfig/ui/storedwebconnectiondialog.ui
@@ -80,6 +80,9 @@
<property name="can_focus">False</property>
<property name="label" translatable="yes"
context="storedwebconnectiondialog|label1">Web login information (passwords are
never shown)</property>
<property name="xalign">0</property>
+ <accessibility>
+ <relation type="label-for" target="logins"/>
+ </accessibility>
</object>
<packing>
<property name="left_attach">0</property>
@@ -133,6 +136,9 @@
</child>
</object>
</child>
+ <accessibility>
+ <relation type="labelled-by" target="label1"/>
+ </accessibility>
</object>
</child>
</object>
diff --git a/cui/uiconfig/ui/tsaurldialog.ui b/cui/uiconfig/ui/tsaurldialog.ui
index 3d005f3faa22..67d247c0037b 100644
--- a/cui/uiconfig/ui/tsaurldialog.ui
+++ b/cui/uiconfig/ui/tsaurldialog.ui
@@ -148,6 +148,9 @@
<property name="max_width_chars">60</property>
<property name="xalign">0</property>
<property name="yalign">0</property>
+ <accessibility>
+ <relation type="label-for" target="urls"/>
+ </accessibility>
</object>
<packing>
<property name="expand">False</property>
@@ -186,6 +189,9 @@
</child>
</object>
</child>
+ <accessibility>
+ <relation type="labelled-by" target="label2"/>
+ </accessibility>
</object>
</child>
</object>
diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr
index c40300cd77b3..db4378b943c3 100644
--- a/solenv/sanitizers/ui/cui.suppr
+++ b/solenv/sanitizers/ui/cui.suppr
@@ -12,8 +12,6 @@
cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='singlestartex'] orphan-lab
cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='singleendex']
orphan-label
cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='doublestartex']
orphan-label
cui/uiconfig/ui/applylocalizedpage.ui://GtkLabel[@id='doubleendex']
orphan-label
-cui/uiconfig/ui/assigncomponentdialog.ui://GtkLabel[@id='label1'] orphan-label
-cui/uiconfig/ui/assigncomponentdialog.ui://GtkEntry[@id='methodEntry']
no-labelled-by
cui/uiconfig/ui/backgroundpage.ui://GtkLabel[@id='fileft'] orphan-label
cui/uiconfig/ui/backgroundpage.ui://GtkLabel[@id='unlinkedft'] orphan-label
cui/uiconfig/ui/backgroundpage.ui://GtkLabel[@id='findgraphicsft'] orphan-label
@@ -26,23 +24,10 @@
cui/uiconfig/ui/baselinksdialog.ui://GtkLabel[@id='FULL_TYPE_NAME'] orphan-label
cui/uiconfig/ui/bitmaptabpage.ui://GtkLabel[@id='label4'] orphan-label
cui/uiconfig/ui/bitmaptabpage.ui://GtkLabel[@id='label9'] orphan-label
cui/uiconfig/ui/bitmaptabpage.ui://GtkSpinButton[@id='tileoffmtr']
no-labelled-by
-cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkComboBox[@id='os']
no-labelled-by
-cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='osversion']
no-labelled-by
-cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='platformvendor']
no-labelled-by
-cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='device']
no-labelled-by
-cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkEntry[@id='driverversion']
no-labelled-by
-cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='label4']
orphan-label
-cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='label5']
orphan-label
-cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='label6']
orphan-label
-cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='label7']
orphan-label
-cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='label8']
orphan-label
cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='bledittitle']
orphan-label
cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='bladdtitle']
orphan-label
cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='wledittitle']
orphan-label
cui/uiconfig/ui/blackorwhitelistentrydialog.ui://GtkLabel[@id='wladdtitle']
orphan-label
-cui/uiconfig/ui/breaknumberoption.ui://GtkSpinButton[@id='beforebreak']
no-labelled-by
-cui/uiconfig/ui/breaknumberoption.ui://GtkSpinButton[@id='afterbreak']
no-labelled-by
-cui/uiconfig/ui/breaknumberoption.ui://GtkSpinButton[@id='wordlength']
no-labelled-by
cui/uiconfig/ui/cellalignment.ui://GtkLabel[@id='labelSTR_BOTTOMLOCK']
orphan-label
cui/uiconfig/ui/cellalignment.ui://GtkLabel[@id='labelSTR_TOPLOCK']
orphan-label
cui/uiconfig/ui/cellalignment.ui://GtkLabel[@id='labelSTR_CELLLOCK']
orphan-label
@@ -371,7 +356,6 @@ cui/uiconfig/ui/spellingdialog.ui://GtkLabel[@id='explain']
orphan-label
cui/uiconfig/ui/spellingdialog.ui://GtkLabel[@id='resumeft'] orphan-label
cui/uiconfig/ui/spellingdialog.ui://GtkLabel[@id='nosuggestionsft']
orphan-label
cui/uiconfig/ui/spellingdialog.ui://GtkLabel[@id='alttitleft'] orphan-label
-cui/uiconfig/ui/storedwebconnectiondialog.ui://GtkLabel[@id='label1']
orphan-label
cui/uiconfig/ui/textanimtabpage.ui://GtkLabel[@id='FT_COUNT'] orphan-label
cui/uiconfig/ui/textanimtabpage.ui://GtkLabel[@id='FT_AMOUNT'] orphan-label
cui/uiconfig/ui/textanimtabpage.ui://GtkLabel[@id='FT_DELAY'] orphan-label
@@ -379,7 +363,6 @@
cui/uiconfig/ui/textflowpage.ui://GtkLabel[@id='labelOrphan'] orphan-label
cui/uiconfig/ui/textflowpage.ui://GtkLabel[@id='labelWidow'] orphan-label
cui/uiconfig/ui/thesaurus.ui://GtkButton[@id='left'] button-no-label
cui/uiconfig/ui/thesaurus.ui://GtkLabel[@id='notfound'] orphan-label
-cui/uiconfig/ui/tsaurldialog.ui://GtkLabel[@id='label2'] orphan-label
cui/uiconfig/ui/tsaurldialog.ui://GtkLabel[@id='enteraurl'] orphan-label
cui/uiconfig/ui/twolinespage.ui://GtkLabel[@id='label29'] orphan-label
cui/uiconfig/ui/twolinespage.ui://GtkLabel[@id='label30'] orphan-label
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
