On 27/02/12 23:51, Riccardo Magliocchetti wrote: > Hello, > > Il 27/02/2012 23:22, willubuntu ha scritto: >> Hello guys, > >> >> I took also the opportunity to fix some indentation to get a consistent look >> in code. > > Usually is better to separate the behaviour changes from the whitespace > cleanup othwerwise it is difficult to see what you have actually changed > :) So if you could respin your patch fixing the bugs first it'll help > people reviewing your code.
indeed, and that is _especially_ true if you want your fix backported to a release branch; William, please post a no-whitespace fix for review. regards, michael _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
