compilerplugins/clang/virtualdead.unusedparams.results | 3 --- include/xmloff/txtimp.hxx | 2 +- sw/source/filter/xml/xmlimp.cxx | 2 +- sw/source/filter/xml/xmltbli.cxx | 4 ++-- sw/source/filter/xml/xmltexti.cxx | 3 +-- sw/source/filter/xml/xmltexti.hxx | 2 +- xmloff/source/text/XMLIndexTOCContext.cxx | 4 ++-- xmloff/source/text/XMLSectionImportContext.cxx | 4 ++-- xmloff/source/text/txtimp.cxx | 2 +- 9 files changed, 11 insertions(+), 15 deletions(-)
New commits: commit 8e4b0329dd49d79359d89d7c0209fba4072caeef Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Thu Oct 17 16:08:35 2019 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Sun Oct 20 20:09:37 2019 +0200 loplugin:virtualdead unused param in RedlineAdjustStartNodeCursor Change-Id: Ic8eaad705b0cf8289035f7eee3ad01439fc24ee7 Reviewed-on: https://gerrit.libreoffice.org/81155 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results index 6a2cf9cc55f4..a22567d37cea 100644 --- a/compilerplugins/clang/virtualdead.unusedparams.results +++ b/compilerplugins/clang/virtualdead.unusedparams.results @@ -217,9 +217,6 @@ include/vcl/task.hxx:71 include/vcl/treelist.hxx:304 void SvListView::ModelIsMoving(class SvTreeListEntry *,class SvTreeListEntry *,unsigned long,) 100 -include/xmloff/txtimp.hxx:677 - void XMLTextImportHelper::RedlineAdjustStartNodeCursor(_Bool,) - 0 include/xmloff/xmlimp.hxx:244 class SvXMLImportContext * SvXMLImport::CreateDocumentContext(const unsigned short,const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::xml::sax::XAttributeList> &,) 110 diff --git a/include/xmloff/txtimp.hxx b/include/xmloff/txtimp.hxx index 0a9108cab66c..f2db2826cf2d 100644 --- a/include/xmloff/txtimp.hxx +++ b/include/xmloff/txtimp.hxx @@ -674,7 +674,7 @@ public: /// range is not within <text:p> bool bIsOutsideOfParagraph); - virtual void RedlineAdjustStartNodeCursor( bool bStart ); + virtual void RedlineAdjustStartNodeCursor(); virtual void SetShowChanges( bool bShowChanges ); virtual void SetRecordChanges( bool bRecordChanges ); virtual void SetChangesProtectionKey( diff --git a/sw/source/filter/xml/xmlimp.cxx b/sw/source/filter/xml/xmlimp.cxx index f940c8eb3ff1..c198632b2261 100644 --- a/sw/source/filter/xml/xmlimp.cxx +++ b/sw/source/filter/xml/xmlimp.cxx @@ -903,7 +903,7 @@ void SwXMLImport::endDocument() /* Was called too early. Moved from SwXMLBodyContext_Impl::EndElement */ - GetTextImport()->RedlineAdjustStartNodeCursor( false ); + GetTextImport()->RedlineAdjustStartNodeCursor(); if( (getImportFlags() & SvXMLImportFlags::CONTENT) || ((getImportFlags() & SvXMLImportFlags::MASTERSTYLES) && IsStylesOnlyMode()) ) diff --git a/sw/source/filter/xml/xmltbli.cxx b/sw/source/filter/xml/xmltbli.cxx index ed0049353326..b7807e0e87d6 100644 --- a/sw/source/filter/xml/xmltbli.cxx +++ b/sw/source/filter/xml/xmltbli.cxx @@ -1337,7 +1337,7 @@ SwXMLTableContext::SwXMLTableContext( SwXMLImport& rImport, GetImport().GetTextImport()->SetCursor( xText->createTextCursor() ); // take care of open redlines for tables - GetImport().GetTextImport()->RedlineAdjustStartNodeCursor(true); + GetImport().GetTextImport()->RedlineAdjustStartNodeCursor(); } if( pXTable ) { @@ -1388,7 +1388,7 @@ SwXMLTableContext::~SwXMLTableContext() m_pRows.reset(); // close redlines on table end nodes - GetImport().GetTextImport()->RedlineAdjustStartNodeCursor(false); + GetImport().GetTextImport()->RedlineAdjustStartNodeCursor(); } SvXMLImportContextRef SwXMLTableContext::CreateChildContext( sal_uInt16 nPrefix, diff --git a/sw/source/filter/xml/xmltexti.cxx b/sw/source/filter/xml/xmltexti.cxx index 9d8fe1fdcd52..788bec5c2d47 100644 --- a/sw/source/filter/xml/xmltexti.cxx +++ b/sw/source/filter/xml/xmltexti.cxx @@ -1005,8 +1005,7 @@ void SwXMLTextImportHelper::RedlineSetCursor( // else: ignore redline (wasn't added before, else we'd have a helper) } -void SwXMLTextImportHelper::RedlineAdjustStartNodeCursor( - bool /*bStart*/) +void SwXMLTextImportHelper::RedlineAdjustStartNodeCursor() { OUString rId = GetOpenRedlineId(); if ((nullptr != pRedlineHelper) && !rId.isEmpty()) diff --git a/sw/source/filter/xml/xmltexti.hxx b/sw/source/filter/xml/xmltexti.hxx index 61b9d6cd0a5a..1aefcfe641e0 100644 --- a/sw/source/filter/xml/xmltexti.hxx +++ b/sw/source/filter/xml/xmltexti.hxx @@ -98,7 +98,7 @@ public: const OUString& rId, /// ID used to RedlineAdd() call bool bStart, /// start or end Cursor bool bIsOutsideOfParagraph) override; - virtual void RedlineAdjustStartNodeCursor( bool bStart) override; + virtual void RedlineAdjustStartNodeCursor() override; virtual void SetShowChanges( bool bShowChanges ) override; virtual void SetRecordChanges( bool bRecordChanges ) override; virtual void SetChangesProtectionKey( diff --git a/xmloff/source/text/XMLIndexTOCContext.cxx b/xmloff/source/text/XMLIndexTOCContext.cxx index f505ed3e0e84..1fe7f134193b 100644 --- a/xmloff/source/text/XMLIndexTOCContext.cxx +++ b/xmloff/source/text/XMLIndexTOCContext.cxx @@ -228,7 +228,7 @@ void XMLIndexTOCContext::StartElement( // finally, check for redlines that should start at // the section start node if( bValid ) - GetImport().GetTextImport()->RedlineAdjustStartNodeCursor(true); + GetImport().GetTextImport()->RedlineAdjustStartNodeCursor(); if (pStyle != nullptr) { @@ -269,7 +269,7 @@ void XMLIndexTOCContext::EndElement() "", true); // check for Redlines on our end node - GetImport().GetTextImport()->RedlineAdjustStartNodeCursor(false); + GetImport().GetTextImport()->RedlineAdjustStartNodeCursor(); } } diff --git a/xmloff/source/text/XMLSectionImportContext.cxx b/xmloff/source/text/XMLSectionImportContext.cxx index 42e93478dd5d..e7754047aacd 100644 --- a/xmloff/source/text/XMLSectionImportContext.cxx +++ b/xmloff/source/text/XMLSectionImportContext.cxx @@ -212,7 +212,7 @@ void XMLSectionImportContext::StartElement( // finally, check for redlines that should start at // the section start node - rHelper->RedlineAdjustStartNodeCursor(true); // start ??? + rHelper->RedlineAdjustStartNodeCursor(); // start ??? // xml:id for RDF metadata GetImport().SetXmlId(xIfc, sXmlId); @@ -322,7 +322,7 @@ void XMLSectionImportContext::EndElement() "", true); // check for redlines to our endnode - rHelper->RedlineAdjustStartNodeCursor(false); + rHelper->RedlineAdjustStartNodeCursor(); } SvXMLImportContextRef XMLSectionImportContext::CreateChildContext( diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx index fc02dff34a05..7dc6152ae6d8 100644 --- a/xmloff/source/text/txtimp.cxx +++ b/xmloff/source/text/txtimp.cxx @@ -2842,7 +2842,7 @@ void XMLTextImportHelper::RedlineSetCursor( // dummy implementation: do nothing } -void XMLTextImportHelper::RedlineAdjustStartNodeCursor(bool) +void XMLTextImportHelper::RedlineAdjustStartNodeCursor() { // dummy implementation: do nothing } _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits