cypress_test/integration_tests/mobile/writer/shape_properties_spec.js | 26
++++------
1 file changed, 12 insertions(+), 14 deletions(-)
New commits:
commit c211ce95e2264f0b1973fdb88bcb6634d23a86bb
Author: Tamás Zolnai <tamas.zol...@collabora.com>
AuthorDate: Thu Feb 20 12:31:24 2020 +0100
Commit: Tamás Zolnai <tamas.zol...@collabora.com>
CommitDate: Thu Feb 20 13:14:38 2020 +0100
cypress: mobile: enable some shape related test which are stable now.
First issue was rendering the mobile wizard twice by
opening. I added a workaround for this issue:
20b5825ce59345e3ad769d83cb63734a1cf5b0e5
The second issue was with the animation when moving
one level down in the mobile wizard. Checking the next
level content makes these tests more stable.
Change-Id: I3f3c90e5975747f833e9560140cabb6c310dfe57
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89087
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zol...@collabora.com>
diff --git
a/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
b/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
index 3411ec597..59217ebba 100644
--- a/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
+++ b/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
@@ -139,11 +139,6 @@ describe('Change shape properties via mobile wizard.',
function() {
});
it('Vertical mirroring', function() {
- // TODO: The sidebar's content is send twice when opening the
mobile
- // wizard.
- if (Cypress.env('LO_CORE_VERSION') === 'master')
- return;
-
// Open mobile wizard
cy.get('#tb_actionbar_item_mobile_wizard')
.click();
@@ -152,6 +147,10 @@ describe('Change shape properties via mobile wizard.',
function() {
cy.get('#PosSizePropertyPanel')
.click();
+ cy.get('.ui-content.level-0.mobile-wizard')
+ .should('be.visible')
+ .wait(100);
+
cy.get('#FlipVertical')
.click();
@@ -160,10 +159,6 @@ describe('Change shape properties via mobile wizard.',
function() {
});
it('Horizontal mirroring', function() {
- // TODO: The sidebar's content is send twice when opening the
mobile
- // wizard.
- if (Cypress.env('LO_CORE_VERSION') === 'master')
- return;
// Open mobile wizard
cy.get('#tb_actionbar_item_mobile_wizard')
@@ -173,6 +168,10 @@ describe('Change shape properties via mobile wizard.',
function() {
cy.get('#PosSizePropertyPanel')
.click();
+ cy.get('.ui-content.level-0.mobile-wizard')
+ .should('be.visible')
+ .wait(100);
+
cy.get('#FlipHorizontal')
.click();
@@ -181,11 +180,6 @@ describe('Change shape properties via mobile wizard.',
function() {
});
it('Trigger moving backward / forward', function() {
- // TODO: The sidebar's content is send twice when opening the
mobile
- // wizard.
- if (Cypress.env('LO_CORE_VERSION') === 'master')
- return;
-
// Open mobile wizard
cy.get('#tb_actionbar_item_mobile_wizard')
.click();
@@ -193,6 +187,10 @@ describe('Change shape properties via mobile wizard.',
function() {
cy.get('#PosSizePropertyPanel')
.click();
+ cy.get('.ui-content.level-0.mobile-wizard')
+ .should('be.visible')
+ .wait(100);
+
// We can't test the result, so we just trigger
// the events to catch crashes, consoler errors.
cy.get('#BringToFront')
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
