toolkit/inc/controls/eventcontainer.hxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 6e31ddbe83115dd5283c5b0f31d92396290895ae
Author:     Samuel Mehrbrodt <samuel.mehrbr...@cib.de>
AuthorDate: Thu May 7 08:12:45 2020 +0200
Commit:     Samuel Mehrbrodt <samuel.mehrbr...@cib.de>
CommitDate: Thu May 7 09:24:28 2020 +0200

    Add comment about insertion order
    
    Change-Id: I650316c0c4bc31a861b3d96586a6a0aae57bd054
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93537
    Tested-by: Samuel Mehrbrodt <samuel.mehrbr...@cib.de>
    Reviewed-by: Samuel Mehrbrodt <samuel.mehrbr...@cib.de>

diff --git a/toolkit/inc/controls/eventcontainer.hxx 
b/toolkit/inc/controls/eventcontainer.hxx
index 396578432fd1..beca65e3e38f 100644
--- a/toolkit/inc/controls/eventcontainer.hxx
+++ b/toolkit/inc/controls/eventcontainer.hxx
@@ -43,6 +43,9 @@ class ScriptEventContainer final : public 
::cppu::WeakImplHelper<
                                         css::container::XNameContainer,
                                         css::container::XContainer >
 {
+    // The map needs to keep the insertion order, otherwise Macro signatures 
would get broken
+    // if the order changes here (Dialog xml files are digitally signed too).
+    // Thus a std::map or std::unordered_map can't be used.
     NameContainerNameMap mHashMap;
     css::uno::Sequence< OUString > mNames;
     std::vector< css::uno::Any > mValues;
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Reply via email to