Hello there, On Sat, Mar 31, 2012 at 18:36, kud360 <kud...@gmail.com> wrote: > I think I got this one right : > I added help buttons to all the dialog boxes that did not have them , i used > git format-patch master stdout > helpbuttons.patch > > Here are the contents of the file :
I think you've done ./g format-patch, which isn't necessary, because you've made the changes in core repository only. And I'm not sure whether we really need 'stdout' in the command. What I usually use is: git format-patch HEAD~1 if you have done only one commit, a file name 0001-xxxx.patch will be produced the working directory. Also, you are recommended to do: git config --global user.name "your-firstname lastname" git config --global user.email "your-em...@sample.com" to properly have an author information in the commit message. Next, for submitting a patch, it's better to start an email subject with [PATCH] to catch an attention. :-) And if you're fixing a concrete bug, it would be good to mention a bug number in the commit message subject, in this case fdo#47864. Lastly, could you please send a blanket email confirming that this and your future contributions are licensed under MPL / LGPLv3+ ? Sorry for the long email, I hope you don't get bored yet :-) And, welcome to LibreOffice! :-) Best Regards, -- Korrawit Pruegsanusak _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice