compilerplugins/clang/unusedfields.only-used-in-constructor.results | 106 +++--- compilerplugins/clang/unusedfields.readonly.results | 86 ++--- compilerplugins/clang/unusedfields.untouched.results | 68 +--- compilerplugins/clang/unusedfields.writeonly.results | 168 +++++----- include/vcl/edit.hxx | 4 include/vcl/toolkit/button.hxx | 6 vcl/source/control/button.cxx | 10 vcl/source/control/edit.cxx | 41 -- 8 files changed, 230 insertions(+), 259 deletions(-)
New commits: commit bb7b0511bbb6d2237b7b765c31727324b4183a85 Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Mon Jul 20 15:28:36 2020 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Tue Jul 21 08:30:34 2020 +0200 loplugin:unusedfields Change-Id: I933d9a82bb6ad5f5b946e28abcc2dae30126c720 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results index 65ba46ffa01d..620901b860b1 100644 --- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results +++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results @@ -1,6 +1,6 @@ -avmedia/source/vlc/vlcframegrabber.hxx:35 +avmedia/source/vlc/vlcframegrabber.hxx:34 avmedia::vlc::VLCFrameGrabber mInstance wrapper::Instance -avmedia/source/vlc/vlcframegrabber.hxx:36 +avmedia/source/vlc/vlcframegrabber.hxx:35 avmedia::vlc::VLCFrameGrabber mMedia wrapper::Media avmedia/source/vlc/wrapper/Types.hxx:38 libvlc_event_t p_obj void * @@ -52,31 +52,31 @@ connectivity/source/drivers/evoab2/EApi.h:122 (anonymous) address_format char * connectivity/source/drivers/evoab2/EApi.h:126 (anonymous) ext char * -connectivity/source/drivers/evoab2/NStatement.hxx:57 +connectivity/source/drivers/evoab2/NStatement.hxx:55 connectivity::evoab::FieldSort bAscending _Bool -connectivity/source/inc/component/CResultSet.hxx:44 +connectivity/source/inc/component/CResultSet.hxx:42 connectivity::component::OComponentResultSet m_bBookmarkable _Bool -connectivity/source/inc/dbase/DResultSet.hxx:43 +connectivity/source/inc/dbase/DResultSet.hxx:41 connectivity::dbase::ODbaseResultSet m_bBookmarkable _Bool -connectivity/source/inc/file/FStatement.hxx:87 +connectivity/source/inc/file/FStatement.hxx:85 connectivity::file::OStatement_Base m_aCursorName class rtl::OUString -connectivity/source/inc/file/FStatement.hxx:88 +connectivity/source/inc/file/FStatement.hxx:86 connectivity::file::OStatement_Base m_nMaxFieldSize sal_Int32 -connectivity/source/inc/file/FStatement.hxx:89 +connectivity/source/inc/file/FStatement.hxx:87 connectivity::file::OStatement_Base m_nMaxRows sal_Int32 -connectivity/source/inc/file/FStatement.hxx:90 +connectivity/source/inc/file/FStatement.hxx:88 connectivity::file::OStatement_Base m_nQueryTimeOut sal_Int32 -connectivity/source/inc/file/FStatement.hxx:91 +connectivity/source/inc/file/FStatement.hxx:89 connectivity::file::OStatement_Base m_nFetchSize sal_Int32 -connectivity/source/inc/file/FStatement.hxx:92 +connectivity/source/inc/file/FStatement.hxx:90 connectivity::file::OStatement_Base m_nResultSetType sal_Int32 -connectivity/source/inc/file/FStatement.hxx:93 +connectivity/source/inc/file/FStatement.hxx:91 connectivity::file::OStatement_Base m_nFetchDirection sal_Int32 -connectivity/source/inc/file/FStatement.hxx:94 +connectivity/source/inc/file/FStatement.hxx:92 connectivity::file::OStatement_Base m_nResultSetConcurrency sal_Int32 -connectivity/source/inc/file/FStatement.hxx:95 +connectivity/source/inc/file/FStatement.hxx:93 connectivity::file::OStatement_Base m_bEscapeProcessing _Bool -connectivity/source/inc/flat/EResultSet.hxx:42 +connectivity/source/inc/flat/EResultSet.hxx:40 connectivity::flat::OFlatResultSet m_bBookmarkable _Bool connectivity/source/inc/java/lang/Object.hxx:38 connectivity::SDBThreadAttach m_aGuard jvmaccess::class VirtualMachine::AttachGuard @@ -128,17 +128,17 @@ cppu/source/uno/check.cxx:134 (anonymous namespace)::Char3 c3 char cppu/source/uno/check.cxx:138 (anonymous namespace)::Char4 chars struct (anonymous namespace)::Char3 -cui/source/dialogs/AdditionsDialog.cxx:53 +cui/source/dialogs/AdditionsDialog.cxx:82 (anonymous namespace)::AdditionInfo sDescription class rtl::OUString -cui/source/dialogs/AdditionsDialog.cxx:55 +cui/source/dialogs/AdditionsDialog.cxx:84 (anonymous namespace)::AdditionInfo sReleaseVersion class rtl::OUString -cui/source/dialogs/AdditionsDialog.cxx:59 +cui/source/dialogs/AdditionsDialog.cxx:88 (anonymous namespace)::AdditionInfo sRating class rtl::OUString -cui/source/dialogs/AdditionsDialog.cxx:61 +cui/source/dialogs/AdditionsDialog.cxx:90 (anonymous namespace)::AdditionInfo sDownloadURL class rtl::OUString -cui/source/dialogs/colorpicker.cxx:737 +cui/source/dialogs/colorpicker.cxx:736 cui::(anonymous namespace)::ColorPickerDialog m_aColorPrevious class cui::(anonymous namespace)::ColorPreviewControl -cui/source/factory/dlgfact.cxx:1408 +cui/source/factory/dlgfact.cxx:1410 (anonymous namespace)::SvxMacroAssignDialog m_aItems class SfxItemSet cui/source/inc/cfgutil.hxx:241 SvxScriptSelectorDialog m_aStylesInfo struct SfxStylesInfo_Impl @@ -178,15 +178,15 @@ dbaccess/source/core/dataaccess/connection.hxx:102 dbaccess::OConnection m_nInAppend std::atomic<std::size_t> dbaccess/source/core/inc/databasecontext.hxx:85 dbaccess::ODatabaseContext m_aBasicDLL class BasicDLL -drawinglayer/inc/texture/texture3d.hxx:61 +drawinglayer/inc/texture/texture3d.hxx:57 drawinglayer::texture::GeoTexSvxBitmapEx maBitmap class Bitmap -drawinglayer/inc/texture/texture3d.hxx:63 +drawinglayer/inc/texture/texture3d.hxx:59 drawinglayer::texture::GeoTexSvxBitmapEx maTransparence class Bitmap drawinglayer/source/tools/emfphelperdata.hxx:198 emfplushelper::EmfPlusHelperData mnFrameRight sal_Int32 drawinglayer/source/tools/emfphelperdata.hxx:199 emfplushelper::EmfPlusHelperData mnFrameBottom sal_Int32 -editeng/source/editeng/impedit.hxx:468 +editeng/source/editeng/impedit.hxx:515 ImpEditEngine aSelFuncSet class EditSelFunctionSet extensions/source/bibliography/datman.cxx:403 (anonymous namespace)::DBChangeDialog_Impl aConfig class DBChangeDialogConfig_Impl @@ -214,7 +214,7 @@ include/LibreOfficeKit/LibreOfficeKitGtk.h:33 _LOKDocView aDrawingArea GtkDrawingArea include/LibreOfficeKit/LibreOfficeKitGtk.h:38 _LOKDocViewClass parent_class GtkDrawingAreaClass -include/oox/export/shapes.hxx:101 +include/oox/export/shapes.hxx:102 oox::drawingml::ShapeExport maShapeMap oox::drawingml::ShapeExport::ShapeHashMap include/registry/registry.hxx:34 Registry_Api acquire void (*)(RegHandle) @@ -330,10 +330,10 @@ include/sfx2/msg.hxx:145 SfxType16 pType const std::type_info * include/sfx2/msg.hxx:146 SfxType17 pType const std::type_info * -include/sfx2/msg.hxx:146 - SfxType17 createSfxPoolItemFunc std::function<SfxPoolItem *(void)> include/sfx2/msg.hxx:146 SfxType17 aAttrib struct SfxTypeAttrib [17] +include/sfx2/msg.hxx:146 + SfxType17 createSfxPoolItemFunc std::function<SfxPoolItem *(void)> include/sfx2/msg.hxx:146 SfxType17 nAttribs sal_uInt16 include/sfx2/msg.hxx:147 @@ -358,7 +358,7 @@ include/vcl/commandevent.hxx:311 CommandGestureData mfY const double include/vcl/commandevent.hxx:315 CommandGestureData meOrientation const enum PanningOrientation -include/vcl/font/Feature.hxx:102 +include/vcl/font/Feature.hxx:100 vcl::font::Feature m_eType enum vcl::font::FeatureType include/vcl/NotebookBarAddonsMerger.hxx:37 NotebookBarAddonsItem aImage class Image @@ -408,7 +408,7 @@ oox/source/drawingml/diagram/layoutnodecontext.cxx:92 oox::drawingml::(anonymous namespace)::AlgorithmContext mnRevision sal_Int32 oox/source/drawingml/diagram/layoutnodecontext.cxx:134 oox::drawingml::(anonymous namespace)::ChooseContext msName class rtl::OUString -oox/source/drawingml/hyperlinkcontext.hxx:42 +oox/source/drawingml/hyperlinkcontext.hxx:41 oox::drawingml::HyperLinkContext maProperties class oox::PropertyMap & oox/source/ppt/timenodelistcontext.cxx:199 oox::ppt::(anonymous namespace)::MediaNodeContext mbIsNarration _Bool @@ -438,6 +438,8 @@ pyuno/source/module/pyuno_impl.hxx:237 pyuno::stRuntimeImpl ob_base PyObject reportdesign/source/core/api/ReportDefinition.cxx:236 reportdesign::(anonymous namespace)::OStyle m_aSize awt::Size +reportdesign/source/filter/xml/xmlExport.cxx:1230 + sal_Int32 sal/qa/osl/condition/osl_Condition.cxx:72 osl_Condition::ctors bRes1 _Bool sal/qa/osl/condition/osl_Condition.cxx:202 @@ -512,7 +514,7 @@ sc/source/filter/html/htmlpars.cxx:3018 (anonymous namespace)::CSSHandler::MemStr mn size_t sc/source/filter/inc/htmlpars.hxx:613 ScHTMLQueryParser mnUnusedId ScHTMLTableId -sc/source/filter/inc/sheetdatacontext.hxx:52 +sc/source/filter/inc/sheetdatacontext.hxx:51 oox::xls::SheetDataContext aReleaser class SolarMutexReleaser sc/source/filter/inc/XclImpChangeTrack.hxx:56 XclImpChangeTrack xInStrm tools::SvRef<SotStorageStream> @@ -536,8 +538,6 @@ sc/source/filter/xml/xmlexternaltabi.hxx:111 ScXMLExternalRefCellContext mnCellType sal_Int16 sc/source/filter/xml/xmltransformationi.hxx:155 ScXMLDateTimeContext aType class rtl::OUString -sc/source/ui/docshell/docfunc.cxx:1550 - const class ScDPCollection *& sc/source/ui/inc/acredlin.hxx:50 ScAcceptChgDlg aReOpenIdle class Idle sc/source/ui/inc/msgpool.hxx:35 @@ -570,7 +570,7 @@ sccomp/source/solver/DifferentialEvolution.hxx:35 DifferentialEvolutionAlgorithm maRandomDevice std::random_device sccomp/source/solver/ParticelSwarmOptimization.hxx:56 ParticleSwarmOptimizationAlgorithm maRandomDevice std::random_device -scripting/source/stringresource/stringresource.cxx:1291 +scripting/source/stringresource/stringresource.cxx:1279 stringresource::(anonymous namespace)::BinaryInput m_aData Sequence<sal_Int8> sd/inc/anminfo.hxx:52 SdAnimationInfo maSecondSoundFile class rtl::OUString @@ -644,7 +644,7 @@ sfx2/source/dialog/basedlgs.cxx:47 SfxModelessDialog_Impl aMoveIdle class Idle sfx2/source/doc/doctempl.cxx:102 DocTempl::(anonymous namespace)::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock -slideshow/source/engine/animationnodes/animationbasenode.hxx:89 +slideshow/source/engine/animationnodes/animationbasenode.hxx:88 slideshow::internal::AnimationBaseNode mpSubsetManager slideshow::internal::SubsettableShapeManagerSharedPtr slideshow/source/engine/opengl/TransitionImpl.cxx:1992 (anonymous namespace)::ThreeFloats y GLfloat @@ -672,7 +672,7 @@ starmath/inc/view.hxx:216 SmViewShell maGraphicController class SmGraphicController starmath/source/accessibility.hxx:270 SmEditSource rEditAcc class SmEditAccessible & -svgio/inc/svgcharacternode.hxx:89 +svgio/inc/svgcharacternode.hxx:85 svgio::svgreader::SvgTextPosition maY ::std::vector<double> svl/source/crypto/cryptosign.cxx:124 (anonymous namespace)::Extension extnID SECItem @@ -726,7 +726,7 @@ svx/source/stbctrls/zoomctrl.cxx:59 (anonymous namespace)::ZoomPopup_Impl m_aBuilder class VclBuilder svx/source/svdraw/svdcrtv.cxx:48 ImplConnectMarkerOverlay maObjects sdr::overlay::OverlayObjectList -svx/source/svdraw/svdmrkv.cxx:131 +svx/source/svdraw/svdmrkv.cxx:132 MarkingSubSelectionOverlay maObjects sdr::overlay::OverlayObjectList svx/source/tbxctrls/extrusioncontrols.hxx:66 svx::ExtrusionDirectionWindow maImgDirection class Image [9] @@ -734,11 +734,13 @@ svx/source/xml/xmleohlp.cxx:68 OutputStorageWrapper_Impl aTempFile class utl::TempFile svx/source/xml/xmlgrhlp.cxx:87 (anonymous namespace)::GraphicInputStream maTempFile utl::TempFile +sw/inc/tox.hxx:57 + sw::FindContentFrameHint m_isReadOnlyAvailable const _Bool sw/inc/unosett.hxx:145 SwXNumberingRules m_pImpl ::sw::UnoImplPtr<Impl> sw/qa/core/test_ToxTextGenerator.cxx:140 (anonymous namespace)::ToxTextGeneratorWithMockedChapterField mChapterFieldType class SwChapterFieldType -sw/qa/extras/uiwriter/uiwriter.cxx:4222 +sw/qa/extras/uiwriter/uiwriter.cxx:4224 (anonymous namespace)::IdleTask maIdle class Idle sw/source/core/crsr/crbm.cxx:64 (anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState @@ -770,8 +772,6 @@ sw/source/uibase/inc/uivwimp.hxx:93 SwView_Impl xTmpSelDocSh class SfxObjectShellLock sw/source/uibase/inc/unodispatch.hxx:45 SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard class SolarMutexGuard -sw/source/uibase/sidebar/WriterInspectorTextPanel.hxx:51 - sw::sidebar::WriterInspectorTextPanel maCharStyle sfx2::sidebar::ControllerItem toolkit/source/awt/stylesettings.cxx:94 toolkit::(anonymous namespace)::StyleMethodGuard m_aGuard class SolarMutexGuard ucb/source/ucp/gio/gio_mount.hxx:74 @@ -786,9 +786,9 @@ ucb/source/ucp/gio/gio_mount.hxx:80 OOoMountOperationClass _gtk_reserved4 void (*)(void) vcl/headless/svpgdi.cxx:397 (anonymous namespace)::BitmapHelper aTmpBmp class SvpSalBitmap -vcl/inc/canvasbitmap.hxx:42 +vcl/inc/canvasbitmap.hxx:40 vcl::unotools::VclCanvasBitmap m_aAlpha ::Bitmap -vcl/inc/graphic/Manager.hxx:41 +vcl/inc/graphic/Manager.hxx:39 vcl::graphic::Manager maSwapOutTimer class Timer vcl/inc/opengl/RenderList.hxx:29 Vertex color glm::vec4 @@ -804,11 +804,11 @@ vcl/inc/salmenu.hxx:43 SalMenuButtonItem maImage class Image vcl/inc/salmenu.hxx:44 SalMenuButtonItem maToolTipText class rtl::OUString -vcl/inc/salvtables.hxx:561 +vcl/inc/salvtables.hxx:559 SalInstanceEntry m_aTextFilter class WeldTextFilter vcl/inc/salvtables.hxx:935 SalInstanceComboBoxWithEdit m_aTextFilter class WeldTextFilter -vcl/inc/svimpbox.hxx:127 +vcl/inc/svimpbox.hxx:121 SvImpLBox m_aFctSet class ImpLBSelEng vcl/inc/unx/i18n_ic.hxx:40 SalI18N_InputContext maPreeditStartCallback XIMCallback @@ -838,11 +838,11 @@ vcl/source/gdi/jobset.cxx:37 (anonymous namespace)::ImplOldJobSetupData cDeviceName char [32] vcl/source/gdi/jobset.cxx:38 (anonymous namespace)::ImplOldJobSetupData cPortName char [32] -vcl/source/gdi/pdfbuildin_fonts.hxx:34 +vcl/source/gdi/pdfbuildin_fonts.hxx:32 vcl::pdf::BuildinFont m_nAscent const int -vcl/source/gdi/pdfbuildin_fonts.hxx:35 +vcl/source/gdi/pdfbuildin_fonts.hxx:33 vcl::pdf::BuildinFont m_nDescent const int -vcl/source/gdi/pdfbuildin_fonts.hxx:42 +vcl/source/gdi/pdfbuildin_fonts.hxx:40 vcl::pdf::BuildinFont m_aWidths const int [256] vcl/unx/gtk3/a11y/atkwrapper.hxx:47 AtkObjectWrapper aParent AtkObject @@ -854,19 +854,19 @@ vcl/unx/gtk3/gtk3gloactiongroup.cxx:27 (anonymous namespace)::GLOAction parent_instance GObject vcl/unx/gtk3/gtk3glomenu.cxx:14 GLOMenu parent_instance const GMenuModel -vcl/unx/gtk3/gtk3gtkinst.cxx:4778 +vcl/unx/gtk3/gtk3gtkinst.cxx:4806 (anonymous namespace)::GtkInstanceAssistant m_pButtonBox GtkButtonBox * -vcl/unx/gtk3/gtk3gtkinst.cxx:5151 +vcl/unx/gtk3/gtk3gtkinst.cxx:5179 (anonymous namespace)::CrippledViewport viewport GtkViewport -vcl/unx/gtk3/gtk3gtkinst.cxx:5294 +vcl/unx/gtk3/gtk3gtkinst.cxx:5322 (anonymous namespace)::CustomCellRendererSurface parent GtkCellRendererText -vcl/unx/gtk3/gtk3gtkinst.cxx:5302 +vcl/unx/gtk3/gtk3gtkinst.cxx:5330 (anonymous namespace)::CustomCellRendererSurfaceClass parent_class GtkCellRendererTextClass -vcl/unx/gtk3/gtk3gtkinst.cxx:12866 +vcl/unx/gtk3/gtk3gtkinst.cxx:13056 (anonymous namespace)::GtkInstanceComboBox m_pOverlay GtkOverlay * -vcl/unx/gtk3/gtk3gtkinst.cxx:12872 +vcl/unx/gtk3/gtk3gtkinst.cxx:13062 (anonymous namespace)::GtkInstanceComboBox m_pMenuTextRenderer GtkCellRenderer * -writerfilter/source/dmapper/PropertyMap.hxx:220 +writerfilter/source/dmapper/PropertyMap.hxx:219 writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32 xmloff/source/chart/transporttypes.hxx:149 CustomLabelField sRuns std::vector<OUString> diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results index 333d6b4385ae..3d37f77855a6 100644 --- a/compilerplugins/clang/unusedfields.readonly.results +++ b/compilerplugins/clang/unusedfields.readonly.results @@ -58,15 +58,15 @@ codemaker/source/javamaker/classfile.cxx:508 uint32Bytes sal_uInt32 codemaker/source/javamaker/classfile.cxx:540 uint64Bytes sal_uInt64 -connectivity/inc/sdbcx/VCatalog.hxx:67 +connectivity/inc/sdbcx/VCatalog.hxx:65 connectivity::sdbcx::OCatalog m_pViews std::unique_ptr<OCollection> -connectivity/inc/sdbcx/VCatalog.hxx:68 +connectivity/inc/sdbcx/VCatalog.hxx:66 connectivity::sdbcx::OCatalog m_pGroups std::unique_ptr<OCollection> -connectivity/inc/sdbcx/VGroup.hxx:54 +connectivity/inc/sdbcx/VGroup.hxx:52 connectivity::sdbcx::OGroup m_pUsers std::unique_ptr<OUsers> -connectivity/inc/sdbcx/VKey.hxx:71 +connectivity/inc/sdbcx/VKey.hxx:69 connectivity::sdbcx::OKey m_pColumns std::unique_ptr<OCollection> -connectivity/inc/sdbcx/VUser.hxx:54 +connectivity/inc/sdbcx/VUser.hxx:52 connectivity::sdbcx::OUser m_pGroups std::unique_ptr<OGroups> connectivity/qa/connectivity/resource/sharedresources_test.cxx:53 connectivity_test::SharedResourcesTest m_aResource ::connectivity::SharedResources @@ -82,13 +82,13 @@ connectivity/source/drivers/evoab2/EApi.h:130 (anonymous) code char * connectivity/source/drivers/evoab2/EApi.h:131 (anonymous) country char * -connectivity/source/drivers/firebird/Driver.hxx:52 +connectivity/source/drivers/firebird/Driver.hxx:47 connectivity::firebird::FirebirdDriver m_firebirdTMPDirectory ::utl::TempFile -connectivity/source/drivers/firebird/Driver.hxx:53 +connectivity/source/drivers/firebird/Driver.hxx:48 connectivity::firebird::FirebirdDriver m_firebirdLockDirectory ::utl::TempFile -connectivity/source/inc/dbase/DIndexIter.hxx:36 +connectivity/source/inc/dbase/DIndexIter.hxx:34 connectivity::dbase::OIndexIterator m_pOperator file::OBoolOperator * -connectivity/source/inc/dbase/DIndexIter.hxx:37 +connectivity/source/inc/dbase/DIndexIter.hxx:35 connectivity::dbase::OIndexIterator m_pOperand const file::OOperand * connectivity/source/inc/FDatabaseMetaDataResultSet.hxx:110 connectivity::ODatabaseMetaDataResultSet m_aEmptyValue class connectivity::ORowSetValue @@ -106,7 +106,7 @@ connectivity/source/inc/OColumn.hxx:48 connectivity::OColumn m_DefinitelyWritable _Bool connectivity/source/inc/TConnection.hxx:55 connectivity::OMetaConnection m_aResources class connectivity::SharedResources -connectivity/source/inc/writer/WTable.hxx:65 +connectivity/source/inc/writer/WTable.hxx:44 connectivity::writer::OWriterTable m_nStartCol sal_Int32 cppcanvas/source/mtfrenderer/textaction.cxx:1649 cppcanvas::internal::(anonymous namespace)::OutlineAction maTextFillColor const ::Color @@ -186,11 +186,11 @@ dbaccess/source/ui/inc/directsql.hxx:69 dbaui::DirectSQLDialog m_aColorConfig const svtools::ColorConfig dbaccess/source/ui/inc/WCopyTable.hxx:259 dbaui::OCopyTableWizard m_aLocale css::lang::Locale -drawinglayer/inc/processor3d/defaultprocessor3d.hxx:89 +drawinglayer/inc/processor3d/defaultprocessor3d.hxx:87 drawinglayer::processor3d::DefaultProcessor3D maDrawinglayerOpt const class SvtOptionsDrawinglayer drawinglayer/source/processor2d/vclprocessor2d.hxx:77 drawinglayer::processor2d::VclProcessor2D maDrawinglayerOpt const class SvtOptionsDrawinglayer -editeng/source/editeng/impedit.hxx:457 +editeng/source/editeng/impedit.hxx:504 ImpEditEngine maColorConfig svtools::ColorConfig embeddedobj/source/inc/commonembobj.hxx:104 OCommonEmbeddedObject m_aClassName class rtl::OUString @@ -244,7 +244,7 @@ framework/inc/dispatch/dispatchprovider.hxx:77 framework::DispatchProvider m_aProtocolHandlerCache class framework::HandlerCache framework/inc/helper/uiconfigelementwrapperbase.hxx:128 framework::UIConfigElementWrapperBase m_bConfigListening _Bool -framework/inc/xml/menudocumenthandler.hxx:188 +framework/inc/xml/menudocumenthandler.hxx:187 framework::OReadMenuPopupHandler m_bMenuMode _Bool framework/source/fwe/classes/addonsoptions.cxx:344 framework::AddonsOptions_Impl m_aEmptyAddonToolBar Sequence<Sequence<struct com::sun::star::beans::PropertyValue> > @@ -262,19 +262,19 @@ include/basic/sbstar.hxx:50 StarBASIC aErrorHdl Link<class StarBASIC *, _Bool> include/basic/sbstar.hxx:51 StarBASIC aBreakHdl Link<class StarBASIC *, enum BasicDebugFlags> -include/comphelper/interfacecontainer3.hxx:232 +include/comphelper/interfacecontainer3.hxx:222 comphelper::OInterfaceContainerHelper3::NotifySingleListener m_pMethod const comphelper::OInterfaceContainerHelper3::NotifySingleListener::NotificationMethod -include/comphelper/parallelsort.hxx:164 +include/comphelper/parallelsort.hxx:163 comphelper::(anonymous namespace)::Binner maLabels uint8_t [mnMaxStaticSize] include/connectivity/DriversConfig.hxx:75 connectivity::DriversConfig m_aNode connectivity::DriversConfig::OSharedConfigNode -include/connectivity/sdbcx/VDescriptor.hxx:53 +include/connectivity/sdbcx/VDescriptor.hxx:51 connectivity::sdbcx::ODescriptor m_aCase comphelper::UStringMixEqual -include/connectivity/sdbcx/VTable.hxx:78 +include/connectivity/sdbcx/VTable.hxx:77 connectivity::sdbcx::OTable m_xColumns rtl::Reference<OCollection> -include/connectivity/sdbcx/VTable.hxx:79 +include/connectivity/sdbcx/VTable.hxx:78 connectivity::sdbcx::OTable m_xIndexes rtl::Reference<OCollection> -include/connectivity/sqlparse.hxx:109 +include/connectivity/sqlparse.hxx:103 connectivity::OSQLParser_Data aErrors ::connectivity::SQLError include/editeng/brushitem.hxx:51 SvxBrushItem maSecOptions class SvtSecurityOptions @@ -286,9 +286,9 @@ include/filter/msfilter/svdfppt.hxx:878 ImplPPTParaPropSet nDontKnow2 sal_uInt32 include/filter/msfilter/svdfppt.hxx:879 ImplPPTParaPropSet nDontKnow2bit06 sal_uInt16 -include/oox/core/contexthandler2.hxx:217 +include/oox/core/contexthandler2.hxx:216 oox::core::ContextHandler2Helper mnRootStackSize size_t -include/oox/ole/axbinarywriter.hxx:151 +include/oox/ole/axbinarywriter.hxx:150 oox::ole::AxBinaryPropertyWriter maStreamProps oox::ole::AxBinaryPropertyWriter::ComplexPropVector include/registry/refltype.hxx:65 RTUik m_Data1 sal_uInt32 @@ -322,9 +322,9 @@ include/svtools/editsyntaxhighlighter.hxx:32 MultiLineEditSyntaxHighlight m_aColorConfig svtools::ColorConfig include/svx/graphctl.hxx:52 GraphCtrl xVD ScopedVclPtrInstance<class VirtualDevice> -include/svx/sdr/overlay/overlayanimatedbitmapex.hxx:51 +include/svx/sdr/overlay/overlayanimatedbitmapex.hxx:49 sdr::overlay::OverlayAnimatedBitmapEx mbOverlayState _Bool -include/svx/sdr/overlay/overlaymanager.hxx:72 +include/svx/sdr/overlay/overlaymanager.hxx:70 sdr::overlay::OverlayManager maDrawinglayerOpt class SvtOptionsDrawinglayer include/svx/svdmark.hxx:141 SdrMarkList maPointName class rtl::OUString @@ -332,7 +332,7 @@ include/svx/svdmark.hxx:142 SdrMarkList maGluePointName class rtl::OUString include/svx/svdoedge.hxx:160 SdrEdgeObj mbBoundRectCalculationRunning _Bool -include/svx/svdpntv.hxx:160 +include/svx/svdpntv.hxx:154 SdrPaintView maDrawinglayerOpt class SvtOptionsDrawinglayer include/unoidl/unoidl.hxx:443 unoidl::ConstantValue union unoidl::ConstantValue::(anonymous at /home/noel/libo2/include/unoidl/unoidl.hxx:443:5) @@ -362,10 +362,12 @@ include/vcl/opengl/OpenGLContext.hxx:48 OpenGLCapabilitySwitch mbLimitedShaderRegisters _Bool include/vcl/opengl/OpenGLContext.hxx:167 OpenGLContext mpLastFramebuffer class OpenGLFramebuffer * -io/source/stm/odata.cxx:578 - io_stm::(anonymous namespace)::ODataOutputStream::writeDouble(double)::(anonymous union)::(anonymous) n2 sal_uInt32 -io/source/stm/odata.cxx:578 +include/vcl/toolkit/button.hxx:96 + CheckBox mbLegacyNoTextAlign _Bool +io/source/stm/odata.cxx:558 io_stm::(anonymous namespace)::ODataOutputStream::writeDouble(double)::(anonymous union)::(anonymous) n1 sal_uInt32 +io/source/stm/odata.cxx:558 + io_stm::(anonymous namespace)::ODataOutputStream::writeDouble(double)::(anonymous union)::(anonymous) n2 sal_uInt32 libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx:46 (anonymous namespace)::GtvLokDialogPrivate m_nChildKeyModifier guint32 libreofficekit/source/gtk/lokdocview.cxx:86 @@ -428,7 +430,7 @@ sc/source/filter/excel/xltoolbar.cxx:28 (anonymous namespace)::MSOExcelCommandConvertor msoToOOcmd IdToString sc/source/filter/excel/xltoolbar.cxx:29 (anonymous namespace)::MSOExcelCommandConvertor tcidToOOcmd IdToString -sc/source/filter/inc/commentsbuffer.hxx:42 +sc/source/filter/inc/commentsbuffer.hxx:41 oox::xls::CommentModel maAnchor css::awt::Rectangle sc/source/filter/inc/htmlexp.hxx:118 ScHTMLExport pFileNameMap ScHTMLExport::FileNameMapPtr @@ -438,13 +440,13 @@ sc/source/filter/inc/namebuff.hxx:81 RangeNameBufferWK3::Entry nAbsInd sal_uInt16 sc/source/filter/inc/qproform.hxx:55 QProToSc mnAddToken struct TokenId -sc/source/filter/inc/stylesbuffer.hxx:676 +sc/source/filter/inc/stylesbuffer.hxx:675 oox::xls::Dxf mxAlignment std::shared_ptr<Alignment> -sc/source/filter/inc/stylesbuffer.hxx:678 +sc/source/filter/inc/stylesbuffer.hxx:677 oox::xls::Dxf mxProtection std::shared_ptr<Protection> -sc/source/filter/inc/stylesbuffer.hxx:767 +sc/source/filter/inc/stylesbuffer.hxx:766 oox::xls::CellStyleBuffer maBuiltinStyles oox::xls::CellStyleBuffer::CellStyleVector -sc/source/filter/inc/stylesbuffer.hxx:768 +sc/source/filter/inc/stylesbuffer.hxx:767 oox::xls::CellStyleBuffer maUserStyles oox::xls::CellStyleBuffer::CellStyleVector sc/source/filter/inc/XclExpChangeTrack.hxx:348 XclExpChTrAction pAddAction std::unique_ptr<XclExpChTrAction> @@ -514,7 +516,7 @@ sdext/source/pdfimport/tree/style.hxx:43 pdfi::StyleContainer::Style Contents class rtl::OUString sfx2/source/appl/lnkbase2.cxx:99 sfx2::(anonymous namespace)::ImplDdeItem pLink class sfx2::SvBaseLink * -slideshow/source/engine/slideshowimpl.cxx:132 +slideshow/source/engine/slideshowimpl.cxx:133 (anonymous namespace)::FrameSynchronization maTimer canvas::tools::ElapsedTime sot/source/sdstor/ucbstorage.cxx:403 UCBStorageStream_Impl m_aKey class rtl::OString @@ -554,7 +556,7 @@ svtools/source/table/gridtablerenderer.cxx:71 svt::table::(anonymous namespace)::CachedSortIndicator m_sortAscending class BitmapEx svtools/source/table/gridtablerenderer.cxx:72 svt::table::(anonymous namespace)::CachedSortIndicator m_sortDescending class BitmapEx -svx/inc/sdr/overlay/overlayrectangle.hxx:43 +svx/inc/sdr/overlay/overlayrectangle.hxx:41 sdr::overlay::OverlayRectangle mbOverlayState _Bool svx/source/inc/datanavi.hxx:181 svxform::XFormsPage m_aMethodString class svxform::MethodString @@ -580,7 +582,7 @@ sw/inc/dpage.hxx:35 SwDPage pGridLst std::unique_ptr<SdrPageGridFrameList> sw/inc/hints.hxx:230 SwAttrSetChg m_bDelSet _Bool -sw/inc/shellio.hxx:153 +sw/inc/shellio.hxx:147 SwReader mpStg tools::SvRef<SotStorage> sw/inc/swevent.hxx:71 SwCallMouseEvent::(anonymous union)::(anonymous) pFormat const class SwFrameFormat * @@ -712,13 +714,13 @@ vcl/inc/ppdparser.hxx:130 psp::PPDParser::PPDConstraint m_pKey1 const class psp::PPDKey * vcl/inc/printerinfomanager.hxx:75 psp::PrinterInfoManager::SystemPrintQueue m_aComment class rtl::OUString -vcl/inc/salwtype.hxx:157 +vcl/inc/salwtype.hxx:162 SalWheelMouseEvent mbDeltaIsPixel _Bool -vcl/inc/salwtype.hxx:204 +vcl/inc/salwtype.hxx:209 SalSurroundingTextSelectionChangeEvent mnStart sal_uLong -vcl/inc/salwtype.hxx:205 +vcl/inc/salwtype.hxx:210 SalSurroundingTextSelectionChangeEvent mnEnd sal_uLong -vcl/inc/salwtype.hxx:211 +vcl/inc/salwtype.hxx:216 SalQueryCharPositionEvent mnCharPos sal_uLong vcl/inc/svdata.hxx:315 ImplSVNWFData mbMenuBarDockingAreaCommonBG _Bool @@ -1002,11 +1004,11 @@ vcl/unx/gtk3/gtk3glomenu.cxx:14 GLOMenu parent_instance const GMenuModel vcl/unx/gtk3/gtk3gtkinst.cxx:1613 out gpointer * -writerfilter/source/ooxml/OOXMLFactory.hxx:58 +writerfilter/source/ooxml/OOXMLFactory.hxx:57 writerfilter::ooxml::AttributeInfo m_nToken writerfilter::Token_t -writerfilter/source/ooxml/OOXMLFactory.hxx:59 +writerfilter/source/ooxml/OOXMLFactory.hxx:58 writerfilter::ooxml::AttributeInfo m_nResource enum writerfilter::ooxml::ResourceType -writerfilter/source/ooxml/OOXMLFactory.hxx:60 +writerfilter/source/ooxml/OOXMLFactory.hxx:59 writerfilter::ooxml::AttributeInfo m_nRef Id xmloff/inc/MultiPropertySetHelper.hxx:78 MultiPropertySetHelper aEmptyAny css::uno::Any diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results index e59e3599567c..6acb6fa82e35 100644 --- a/compilerplugins/clang/unusedfields.untouched.results +++ b/compilerplugins/clang/unusedfields.untouched.results @@ -22,33 +22,33 @@ canvas/source/vcl/impltools.hxx:115 vclcanvas::tools::LocalGuard aSolarGuard class SolarMutexGuard chart2/source/controller/inc/RangeSelectionListener.hxx:63 chart::RangeSelectionListener m_aControllerLockGuard class chart::ControllerLockGuardUNO -comphelper/source/container/enumerablemap.cxx:303 +comphelper/source/container/enumerablemap.cxx:297 comphelper::(anonymous namespace)::MapEnumeration m_xKeepMapAlive Reference<class com::sun::star::uno::XInterface> connectivity/source/drivers/evoab2/EApi.h:122 (anonymous) address_format char * connectivity/source/drivers/evoab2/EApi.h:126 (anonymous) ext char * -connectivity/source/drivers/evoab2/NStatement.hxx:57 +connectivity/source/drivers/evoab2/NStatement.hxx:55 connectivity::evoab::FieldSort bAscending _Bool -connectivity/source/drivers/mork/MDatabaseMetaData.hxx:30 +connectivity/source/drivers/mork/MDatabaseMetaData.hxx:28 connectivity::mork::ODatabaseMetaData m_pMetaDataHelper std::unique_ptr<MDatabaseMetaDataHelper> cppu/source/threadpool/threadpool.cxx:365 _uno_ThreadPool dummy sal_Int32 cppu/source/typelib/typelib.cxx:60 (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 -cui/source/dialogs/AdditionsDialog.cxx:53 +cui/source/dialogs/AdditionsDialog.cxx:82 (anonymous namespace)::AdditionInfo sDescription class rtl::OUString -cui/source/dialogs/AdditionsDialog.cxx:55 +cui/source/dialogs/AdditionsDialog.cxx:84 (anonymous namespace)::AdditionInfo sReleaseVersion class rtl::OUString -cui/source/dialogs/AdditionsDialog.cxx:59 +cui/source/dialogs/AdditionsDialog.cxx:88 (anonymous namespace)::AdditionInfo sRating class rtl::OUString -cui/source/dialogs/AdditionsDialog.cxx:61 +cui/source/dialogs/AdditionsDialog.cxx:90 (anonymous namespace)::AdditionInfo sDownloadURL class rtl::OUString dbaccess/source/core/inc/databasecontext.hxx:85 dbaccess::ODatabaseContext m_aBasicDLL class BasicDLL dbaccess/source/sdbtools/inc/connectiondependent.hxx:115 sdbtools::ConnectionDependentComponent::EntryGuard m_aMutexGuard ::osl::MutexGuard -emfio/source/emfuno/xemfparser.cxx:50 +emfio/source/emfuno/xemfparser.cxx:48 emfio::emfreader::(anonymous namespace)::XEmfParser context_ uno::Reference<uno::XComponentContext> extensions/source/scanner/scanner.hxx:43 ScannerManager maProtector osl::Mutex @@ -64,7 +64,7 @@ include/LibreOfficeKit/LibreOfficeKitGtk.h:33 _LOKDocView aDrawingArea GtkDrawingArea include/LibreOfficeKit/LibreOfficeKitGtk.h:38 _LOKDocViewClass parent_class GtkDrawingAreaClass -include/oox/vml/vmlshapecontext.hxx:116 +include/oox/vml/vmlshapecontext.hxx:115 oox::vml::ShapeTypeContext m_pShapeType std::shared_ptr<ShapeType> include/registry/registry.hxx:34 Registry_Api acquire void (*)(RegHandle) @@ -114,10 +114,10 @@ include/sfx2/msg.hxx:136 SfxType5 pType const std::type_info * include/sfx2/msg.hxx:137 SfxType6 nAttribs sal_uInt16 -include/sfx2/msg.hxx:137 - SfxType6 createSfxPoolItemFunc std::function<SfxPoolItem *(void)> include/sfx2/msg.hxx:137 SfxType6 aAttrib struct SfxTypeAttrib [6] +include/sfx2/msg.hxx:137 + SfxType6 createSfxPoolItemFunc std::function<SfxPoolItem *(void)> include/sfx2/msg.hxx:137 SfxType6 pType const std::type_info * include/sfx2/msg.hxx:138 @@ -130,20 +130,20 @@ include/sfx2/msg.hxx:138 SfxType7 pType const std::type_info * include/sfx2/msg.hxx:139 SfxType8 aAttrib struct SfxTypeAttrib [8] -include/sfx2/msg.hxx:139 - SfxType8 pType const std::type_info * include/sfx2/msg.hxx:139 SfxType8 nAttribs sal_uInt16 include/sfx2/msg.hxx:139 SfxType8 createSfxPoolItemFunc std::function<SfxPoolItem *(void)> +include/sfx2/msg.hxx:139 + SfxType8 pType const std::type_info * include/sfx2/msg.hxx:140 SfxType10 pType const std::type_info * include/sfx2/msg.hxx:140 SfxType10 createSfxPoolItemFunc std::function<SfxPoolItem *(void)> -include/sfx2/msg.hxx:140 - SfxType10 aAttrib struct SfxTypeAttrib [10] include/sfx2/msg.hxx:140 SfxType10 nAttribs sal_uInt16 +include/sfx2/msg.hxx:140 + SfxType10 aAttrib struct SfxTypeAttrib [10] include/sfx2/msg.hxx:141 SfxType11 nAttribs sal_uInt16 include/sfx2/msg.hxx:141 @@ -160,22 +160,22 @@ include/sfx2/msg.hxx:143 SfxType13 aAttrib struct SfxTypeAttrib [13] include/sfx2/msg.hxx:143 SfxType13 nAttribs sal_uInt16 -include/sfx2/msg.hxx:144 - SfxType14 pType const std::type_info * include/sfx2/msg.hxx:144 SfxType14 aAttrib struct SfxTypeAttrib [14] include/sfx2/msg.hxx:144 SfxType14 nAttribs sal_uInt16 +include/sfx2/msg.hxx:144 + SfxType14 pType const std::type_info * include/sfx2/msg.hxx:144 SfxType14 createSfxPoolItemFunc std::function<SfxPoolItem *(void)> -include/sfx2/msg.hxx:145 - SfxType16 nAttribs sal_uInt16 include/sfx2/msg.hxx:145 SfxType16 aAttrib struct SfxTypeAttrib [16] include/sfx2/msg.hxx:145 SfxType16 createSfxPoolItemFunc std::function<SfxPoolItem *(void)> include/sfx2/msg.hxx:145 SfxType16 pType const std::type_info * +include/sfx2/msg.hxx:145 + SfxType16 nAttribs sal_uInt16 include/sfx2/msg.hxx:146 SfxType17 pType const std::type_info * include/sfx2/msg.hxx:146 @@ -208,7 +208,7 @@ include/vcl/commandevent.hxx:315 CommandGestureData meOrientation const enum PanningOrientation include/vcl/filter/PngImageReader.hxx:31 vcl::PngImageReader mxStatusIndicator css::uno::Reference<css::task::XStatusIndicator> -include/vcl/font/Feature.hxx:102 +include/vcl/font/Feature.hxx:100 vcl::font::Feature m_eType enum vcl::font::FeatureType include/vcl/NotebookBarAddonsMerger.hxx:37 NotebookBarAddonsItem aImage class Image @@ -218,7 +218,7 @@ include/vcl/NotebookBarAddonsMerger.hxx:45 AddonsParams sControlType class rtl::OUString include/vcl/NotebookBarAddonsMerger.hxx:46 AddonsParams nWidth sal_uInt16 -include/vcl/uitest/uiobject.hxx:276 +include/vcl/uitest/uiobject.hxx:278 TabPageUIObject mxTabPage VclPtr<class TabPage> include/xmloff/formlayerexport.hxx:172 xmloff::OOfficeFormsExport m_pImpl std::unique_ptr<OFormsRootExport> @@ -260,6 +260,8 @@ pyuno/source/module/pyuno_impl.hxx:137 pyuno::(anonymous) ob_base PyObject pyuno/source/module/pyuno_impl.hxx:237 pyuno::stRuntimeImpl ob_base PyObject +reportdesign/source/filter/xml/xmlExport.cxx:1230 + sal_Int32 reportdesign/source/ui/inc/ReportWindow.hxx:52 rptui::OReportWindow m_pObjFac std::unique_ptr<DlgEdFactory, o3tl::default_delete<DlgEdFactory> > sal/qa/osl/condition/osl_Condition.cxx:72 @@ -320,10 +322,8 @@ sc/source/filter/html/htmlpars.cxx:3017 (anonymous namespace)::CSSHandler::MemStr mp const char * sc/source/filter/html/htmlpars.cxx:3018 (anonymous namespace)::CSSHandler::MemStr mn size_t -sc/source/filter/inc/sheetdatacontext.hxx:52 +sc/source/filter/inc/sheetdatacontext.hxx:51 oox::xls::SheetDataContext aReleaser class SolarMutexReleaser -sc/source/ui/docshell/docfunc.cxx:1550 - const class ScDPCollection *& sc/source/ui/inc/docsh.hxx:453 ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector> sc/source/ui/inc/PivotLayoutTreeListBase.hxx:48 @@ -388,10 +388,10 @@ svx/source/dialog/weldeditview.cxx:312 (anonymous namespace)::WeldEditSource m_rEditAcc class WeldEditAccessible & svx/source/inc/datanavi.hxx:189 svxform::XFormsPage m_aDropHelper class svxform::DataTreeDropTarget -svx/source/inc/svdpdf.hxx:104 - ImpSdrPdfImport mpPDFium std::shared_ptr<vcl::pdf::PDFium> svx/source/tbxctrls/layctrl.cxx:434 (anonymous namespace)::ColumnsWindow mxControl rtl::Reference<SvxColumnsToolBoxControl> +sw/inc/tox.hxx:57 + sw::FindContentFrameHint m_isReadOnlyAvailable const _Bool sw/source/core/crsr/crbm.cxx:64 (anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState sw/source/core/frmedt/fetab.cxx:75 @@ -408,8 +408,6 @@ sw/source/uibase/inc/uivwimp.hxx:93 SwView_Impl xTmpSelDocSh class SfxObjectShellLock sw/source/uibase/inc/unodispatch.hxx:45 SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard class SolarMutexGuard -sw/source/uibase/sidebar/WriterInspectorTextPanel.hxx:51 - sw::sidebar::WriterInspectorTextPanel maCharStyle sfx2::sidebar::ControllerItem toolkit/source/awt/stylesettings.cxx:94 toolkit::(anonymous namespace)::StyleMethodGuard m_aGuard class SolarMutexGuard unoidl/source/unoidlprovider.cxx:672 @@ -446,11 +444,11 @@ vcl/source/gdi/jobset.cxx:37 (anonymous namespace)::ImplOldJobSetupData cDeviceName char [32] vcl/source/gdi/jobset.cxx:38 (anonymous namespace)::ImplOldJobSetupData cPortName char [32] -vcl/source/gdi/pdfbuildin_fonts.hxx:34 +vcl/source/gdi/pdfbuildin_fonts.hxx:32 vcl::pdf::BuildinFont m_nAscent const int -vcl/source/gdi/pdfbuildin_fonts.hxx:35 +vcl/source/gdi/pdfbuildin_fonts.hxx:33 vcl::pdf::BuildinFont m_nDescent const int -vcl/source/gdi/pdfbuildin_fonts.hxx:42 +vcl/source/gdi/pdfbuildin_fonts.hxx:40 vcl::pdf::BuildinFont m_aWidths const int [256] vcl/source/graphic/VectorGraphicSearch.cxx:204 VectorGraphicSearch::Implementation mpPDFium std::shared_ptr<vcl::pdf::PDFium> @@ -460,13 +458,13 @@ vcl/unx/gtk3/a11y/gtk3atkhypertext.cxx:31 (anonymous namespace)::HyperLink atk_hyper_link const AtkHyperlink vcl/unx/gtk3/gtk3gloactiongroup.cxx:27 (anonymous namespace)::GLOAction parent_instance GObject -vcl/unx/gtk3/gtk3gtkinst.cxx:5151 +vcl/unx/gtk3/gtk3gtkinst.cxx:5179 (anonymous namespace)::CrippledViewport viewport GtkViewport -vcl/unx/gtk3/gtk3gtkinst.cxx:5294 +vcl/unx/gtk3/gtk3gtkinst.cxx:5322 (anonymous namespace)::CustomCellRendererSurface parent GtkCellRendererText -vcl/unx/gtk3/gtk3gtkinst.cxx:5302 +vcl/unx/gtk3/gtk3gtkinst.cxx:5330 (anonymous namespace)::CustomCellRendererSurfaceClass parent_class GtkCellRendererTextClass -writerfilter/source/ooxml/OOXMLStreamImpl.hxx:43 +writerfilter/source/ooxml/OOXMLStreamImpl.hxx:42 writerfilter::ooxml::OOXMLStreamImpl mxFastParser css::uno::Reference<css::xml::sax::XFastParser> xmloff/source/chart/transporttypes.hxx:149 CustomLabelField sRuns std::vector<OUString> diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results index 7c35c7102ec1..059c157ac567 100644 --- a/compilerplugins/clang/unusedfields.writeonly.results +++ b/compilerplugins/clang/unusedfields.writeonly.results @@ -12,7 +12,7 @@ basic/qa/cppunit/test_scanner.cxx:24 (anonymous namespace)::Symbol line sal_uInt16 basic/qa/cppunit/test_scanner.cxx:25 (anonymous namespace)::Symbol col1 sal_uInt16 -basic/source/inc/runtime.hxx:252 +basic/source/inc/runtime.hxx:253 SbiRuntime aRefSaved std::vector<SbxVariableRef> bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:56 Data pMethod sal_uInt64 @@ -80,11 +80,11 @@ canvas/source/cairo/cairo_spritedevicehelper.hxx:74 cairocanvas::SpriteDeviceHelper mbFullScreen _Bool canvas/source/cairo/cairo_spritehelper.hxx:99 cairocanvas::SpriteHelper mbTextureDirty _Bool -chart2/inc/ChartModel.hxx:142 +chart2/inc/ChartModel.hxx:143 chart::ChartModel m_aGraphicObjectVector std::vector<GraphicObject> -chart2/inc/ChartModel.hxx:469 +chart2/inc/ChartModel.hxx:473 chart::ChartModel mnStart sal_Int32 -chart2/inc/ChartModel.hxx:470 +chart2/inc/ChartModel.hxx:474 chart::ChartModel mnEnd sal_Int32 chart2/source/controller/dialogs/DialogModel.cxx:173 (anonymous namespace)::lcl_DataSeriesContainerAppend m_rDestCnt (anonymous namespace)::lcl_DataSeriesContainerAppend::tContainerType * @@ -106,8 +106,6 @@ codemaker/source/javamaker/classfile.cxx:508 floatBytes float codemaker/source/javamaker/classfile.cxx:540 doubleBytes double -comphelper/qa/container/comphelper_ifcontainer.cxx:44 - (anonymous namespace)::ContainerListener m_pStats struct (anonymous namespace)::ContainerStats *const comphelper/qa/unit/parallelsorttest.cxx:44 ParallelSortTest mnThreads size_t comphelper/source/misc/asyncnotification.cxx:86 @@ -150,11 +148,11 @@ connectivity/source/drivers/postgresql/pq_statics.hxx:191 pq_sdbc_driver::Statics KEY_COLUMN class rtl::OUString connectivity/source/drivers/postgresql/pq_statics.hxx:215 pq_sdbc_driver::Statics HELP_TEXT class rtl::OUString -connectivity/source/inc/calc/CConnection.hxx:52 +connectivity/source/inc/calc/CConnection.hxx:51 connectivity::calc::OCalcConnection::CloseVetoButTerminateListener m_pCloseListener std::unique_ptr<utl::CloseVeto> -connectivity/source/inc/odbc/OConnection.hxx:55 +connectivity/source/inc/odbc/OConnection.hxx:54 connectivity::odbc::OConnection m_sUser class rtl::OUString -connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx:72 +connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx:70 connectivity::odbc::ODatabaseMetaDataResultSet m_aStatement css::uno::WeakReferenceHelper connectivity/source/inc/OTypeInfo.hxx:31 connectivity::OTypeInfo aTypeName class rtl::OUString @@ -166,9 +164,9 @@ connectivity/source/inc/OTypeInfo.hxx:36 connectivity::OTypeInfo nMaximumScale sal_Int16 connectivity/source/inc/OTypeInfo.hxx:38 connectivity::OTypeInfo nType sal_Int16 -connectivity/source/inc/writer/WConnection.hxx:66 +connectivity/source/inc/writer/WConnection.hxx:55 connectivity::writer::OWriterConnection::CloseVetoButTerminateListener m_pCloseListener std::unique_ptr<utl::CloseVeto> -cppcanvas/source/inc/implrenderer.hxx:210 +cppcanvas/source/inc/implrenderer.hxx:207 cppcanvas::internal::ImplRenderer aBaseTransform struct cppcanvas::internal::XForm cppu/source/typelib/typelib.cxx:907 (anonymous namespace)::BaseList set (anonymous namespace)::BaseList::Set @@ -216,6 +214,8 @@ cppu/source/uno/copy.hxx:39 cppu::(anonymous namespace)::SequencePrefix nRefCount sal_Int32 cppu/source/uno/copy.hxx:40 cppu::(anonymous namespace)::SequencePrefix nElements sal_Int32 +cppuhelper/qa/ifcontainer/cppu_ifcontainer.cxx:45 + (anonymous namespace)::ContainerListener m_pStats struct (anonymous namespace)::ContainerStats * cppuhelper/source/access_control.cxx:79 cppu::(anonymous namespace)::permission m_str1 rtl_uString * cppuhelper/source/access_control.cxx:80 @@ -240,15 +240,15 @@ dbaccess/source/core/inc/SingleSelectQueryComposer.hxx:86 dbaccess::OSingleSelectQueryComposer m_aTablesCollection std::vector<std::unique_ptr<OPrivateTables> > dbaccess/source/core/inc/TableDeco.hxx:66 dbaccess::ODBTableDecorator m_xColumnMediator css::uno::Reference<css::container::XContainerListener> -dbaccess/source/filter/xml/dbloader2.cxx:223 +dbaccess/source/filter/xml/dbloader2.cxx:202 dbaxml::(anonymous namespace)::DBContentLoader m_xMySelf Reference<class com::sun::star::frame::XFrameLoader> -dbaccess/source/ui/browser/dbloader.cxx:65 +dbaccess/source/ui/browser/dbloader.cxx:62 (anonymous namespace)::DBContentLoader m_xListener Reference<class com::sun::star::frame::XLoadEventListener> -desktop/qa/desktop_lib/test_desktop_lib.cxx:258 +desktop/qa/desktop_lib/test_desktop_lib.cxx:261 DesktopLOKTest m_bModified _Bool -desktop/source/app/app.cxx:1211 +desktop/source/app/app.cxx:1209 desktop::(anonymous namespace)::ExecuteGlobals pLanguageOptions std::unique_ptr<SvtLanguageOptions> -desktop/source/app/app.cxx:1212 +desktop/source/app/app.cxx:1210 desktop::(anonymous namespace)::ExecuteGlobals pPathOptions std::unique_ptr<SvtPathOptions> desktop/source/deployment/gui/dp_gui_extlistbox.hxx:138 dp_gui::ExtensionBox_Impl m_vRemovedEntries std::vector<TEntry_Impl> @@ -312,16 +312,12 @@ framework/inc/services/layoutmanager.hxx:248 framework::LayoutManager m_bGlobalSettings _Bool framework/inc/services/layoutmanager.hxx:262 framework::LayoutManager m_pGlobalSettings std::unique_ptr<GlobalSettings> -framework/inc/uielement/langselectionmenucontroller.hxx:75 +framework/inc/uielement/langselectionmenucontroller.hxx:71 framework::LanguageSelectionMenuController m_xMenuDispatch_Lang css::uno::Reference<css::frame::XDispatch> -framework/inc/uielement/langselectionmenucontroller.hxx:77 +framework/inc/uielement/langselectionmenucontroller.hxx:73 framework::LanguageSelectionMenuController m_xMenuDispatch_Font css::uno::Reference<css::frame::XDispatch> -framework/inc/uielement/langselectionmenucontroller.hxx:79 +framework/inc/uielement/langselectionmenucontroller.hxx:75 framework::LanguageSelectionMenuController m_xMenuDispatch_CharDlgForParagraph css::uno::Reference<css::frame::XDispatch> -framework/inc/uielement/spinfieldtoolbarcontroller.hxx:64 - framework::SpinfieldToolbarController m_bMaxSet _Bool -framework/inc/uielement/spinfieldtoolbarcontroller.hxx:65 - framework::SpinfieldToolbarController m_bMinSet _Bool framework/source/layoutmanager/toolbarlayoutmanager.hxx:272 framework::ToolbarLayoutManager m_pGlobalSettings std::unique_ptr<GlobalSettings> framework/source/layoutmanager/toolbarlayoutmanager.hxx:276 @@ -336,11 +332,11 @@ include/basic/basmgr.hxx:56 BasicError nReason enum BasicErrorReason include/basic/sbxvar.hxx:73 SbxValues::(anonymous) pData void * -include/comphelper/parallelsort.hxx:89 +include/comphelper/parallelsort.hxx:88 comphelper::(anonymous namespace)::ProfileZone mbDummy _Bool include/comphelper/unique_disposing_ptr.hxx:30 comphelper::unique_disposing_ptr m_xTerminateListener css::uno::Reference<css::frame::XTerminateListener> -include/drawinglayer/attribute/sdrallattribute3d.hxx:44 +include/drawinglayer/attribute/sdrallattribute3d.hxx:42 drawinglayer::attribute::SdrLineFillShadowAttribute3D maLineStartEnd const class drawinglayer::attribute::SdrLineStartEndAttribute include/drawinglayer/primitive2d/mediaprimitive2d.hxx:48 drawinglayer::primitive2d::MediaPrimitive2D maURL class rtl::OUString @@ -384,11 +380,11 @@ include/sfx2/minfitem.hxx:35 SfxMacroInfoItem aCommentText class rtl::OUString include/sfx2/templdlg.hxx:41 SfxTemplatePanelControl pImpl std::unique_ptr<SfxTemplateDialog_Impl> -include/svtools/brwbox.hxx:246 +include/svtools/brwbox.hxx:327 BrowseBox::CursorMoveAttempt m_nCol long -include/svtools/brwbox.hxx:247 +include/svtools/brwbox.hxx:328 BrowseBox::CursorMoveAttempt m_nRow long -include/svtools/brwbox.hxx:248 +include/svtools/brwbox.hxx:329 BrowseBox::CursorMoveAttempt m_bScrolledToReachCell _Bool include/svtools/ctrltool.hxx:151 FontList mpDev2 VclPtr<class OutputDevice> @@ -428,6 +424,8 @@ include/test/beans/xpropertyset.hxx:56 apitest::XPropertySet::PropsToTest constrained std::vector<OUString> include/unotools/fontcfg.hxx:159 utl::FontSubstConfiguration maSubstHash utl::FontSubstConfiguration::UniqueSubstHash +include/vcl/edit.hxx:71 + Edit mbModified _Bool include/vcl/menu.hxx:451 MenuBar::MenuBarButtonCallbackArg bHighlight _Bool include/vcl/NotebookBarAddonsMerger.hxx:54 @@ -452,6 +450,8 @@ include/vcl/sysdata.hxx:69 SystemEnvData pSalFrame void * include/vcl/textrectinfo.hxx:32 TextRectInfo mnLineCount sal_uInt16 +include/vcl/toolkit/button.hxx:89 + CheckBox meSaveValue enum TriState include/vcl/vclenum.hxx:202 ItalicMatrix yy double include/vcl/vclenum.hxx:202 @@ -466,9 +466,9 @@ include/xmloff/shapeimport.hxx:181 SdXML3DSceneAttributesHelper mbVPNUsed _Bool include/xmloff/shapeimport.hxx:182 SdXML3DSceneAttributesHelper mbVUPUsed _Bool -io/source/stm/odata.cxx:244 +io/source/stm/odata.cxx:242 io_stm::(anonymous namespace)::ODataInputStream::readDouble()::(anonymous union)::(anonymous) n2 sal_uInt32 -io/source/stm/odata.cxx:244 +io/source/stm/odata.cxx:242 io_stm::(anonymous namespace)::ODataInputStream::readDouble()::(anonymous union)::(anonymous) n1 sal_uInt32 jvmfwk/inc/vendorbase.hxx:173 jfw_plugin::VendorBase m_sArch class rtl::OUString @@ -526,7 +526,7 @@ sc/inc/compiler.hxx:265 ScCompiler::AddInMap pUpper const char * sc/inc/compressedarray.hxx:70 ScCompressedArray::RangeData mnRow2 A -sc/inc/document.hxx:2619 +sc/inc/document.hxx:2639 ScMutationDisable mpDocument class ScDocument * sc/inc/patattr.hxx:55 ScPatternAttr mxHashCode std::optional<size_t> @@ -642,15 +642,15 @@ sc/source/ui/vba/vbachartobject.hxx:44 ScVbaChartObject oShapeHelper std::unique_ptr<ov::ShapeHelper> sd/inc/sdmod.hxx:133 SdModule mpErrorHdl std::unique_ptr<SfxErrorHandler> -sd/qa/unit/tiledrendering/tiledrendering.cxx:190 +sd/qa/unit/tiledrendering/tiledrendering.cxx:194 SdTiledRenderingTest m_bFound _Bool -sd/qa/unit/tiledrendering/tiledrendering.cxx:191 +sd/qa/unit/tiledrendering/tiledrendering.cxx:195 SdTiledRenderingTest m_nPart sal_Int32 -sd/qa/unit/tiledrendering/tiledrendering.cxx:193 +sd/qa/unit/tiledrendering/tiledrendering.cxx:197 SdTiledRenderingTest m_aSearchResultPart std::vector<int> -sd/qa/unit/tiledrendering/tiledrendering.cxx:194 +sd/qa/unit/tiledrendering/tiledrendering.cxx:198 SdTiledRenderingTest m_nSelectionBeforeSearchResult int -sd/qa/unit/tiledrendering/tiledrendering.cxx:195 +sd/qa/unit/tiledrendering/tiledrendering.cxx:199 SdTiledRenderingTest m_nSelectionAfterSearchResult int sd/source/ui/dlg/RemoteDialogClientBox.hxx:67 sd::ClientBox m_vEntries std::vector<TClientBoxEntry> @@ -658,7 +658,7 @@ sd/source/ui/framework/module/ToolBarModule.hxx:75 sd::framework::ToolBarModule mpToolBarManagerLock std::unique_ptr<ToolBarManager::UpdateLock, o3tl::default_delete<ToolBarManager::UpdateLock> > sd/source/ui/inc/AccessibleDocumentViewBase.hxx:243 accessibility::AccessibleDocumentViewBase mpWindow VclPtr< ::sd::Window> -sd/source/ui/inc/animobjs.hxx:120 +sd/source/ui/inc/animobjs.hxx:122 sd::AnimationWindow pControllerItem std::unique_ptr<AnimationControllerItem> sd/source/ui/inc/fudspord.hxx:51 sd::FuDisplayOrder mpOverlay std::unique_ptr<SdrDropMarkerOverlay> @@ -698,13 +698,13 @@ sfx2/source/appl/fileobj.hxx:40 SvFileObject mxDelMed tools::SvRef<SfxMedium> sfx2/source/doc/sfxbasemodel.cxx:448 (anonymous namespace)::SfxSaveGuard m_pFramesLock std::unique_ptr<SfxOwnFramesLocker> -sfx2/source/inc/appdata.hxx:73 +sfx2/source/inc/appdata.hxx:71 SfxAppData_Impl pDocTopics std::unique_ptr<SfxDdeDocTopics_Impl> -sfx2/source/inc/appdata.hxx:74 +sfx2/source/inc/appdata.hxx:72 SfxAppData_Impl pTriggerTopic std::unique_ptr<SfxDdeTriggerTopic_Impl> -sfx2/source/inc/appdata.hxx:75 +sfx2/source/inc/appdata.hxx:73 SfxAppData_Impl pDdeService2 std::unique_ptr<DdeService> -sfx2/source/inc/appdata.hxx:89 +sfx2/source/inc/appdata.hxx:87 SfxAppData_Impl mxAppPickList std::unique_ptr<SfxPickList> sfx2/source/inc/splitwin.hxx:52 SfxSplitWindow pActive VclPtr<class SfxDockingWindow> @@ -720,7 +720,7 @@ slideshow/source/engine/opengl/TransitionImpl.hxx:301 Vertex normal glm::vec3 slideshow/source/engine/opengl/TransitionImpl.hxx:302 Vertex texcoord glm::vec2 -slideshow/source/engine/slideshowimpl.cxx:1018 +slideshow/source/engine/slideshowimpl.cxx:1039 (anonymous namespace)::SlideShowImpl::PrefetchPropertiesFunc mpSlideShowImpl class (anonymous namespace)::SlideShowImpl *const slideshow/test/testview.cxx:50 (anonymous namespace)::ImplTestView maCreatedSprites std::vector<std::pair<basegfx::B2DVector, double> > @@ -736,15 +736,15 @@ store/source/storbios.cxx:58 (anonymous namespace)::OStoreSuperBlock m_nMarked sal_uInt32 store/source/storbios.cxx:59 (anonymous namespace)::OStoreSuperBlock m_aMarked (anonymous namespace)::OStoreSuperBlock::L -svgio/inc/svgcharacternode.hxx:89 +svgio/inc/svgcharacternode.hxx:85 svgio::svgreader::SvgTextPosition maY ::std::vector<double> -svgio/inc/svgsvgnode.hxx:44 +svgio/inc/svgsvgnode.hxx:42 svgio::svgreader::SvgSvgNode maVersion class svgio::svgreader::SvgNumber -svgio/inc/svgsymbolnode.hxx:35 +svgio/inc/svgsymbolnode.hxx:33 svgio::svgreader::SvgSymbolNode maSvgAspectRatio class svgio::svgreader::SvgAspectRatio -svgio/inc/svgusenode.hxx:43 +svgio/inc/svgusenode.hxx:41 svgio::svgreader::SvgUseNode maWidth class svgio::svgreader::SvgNumber -svgio/inc/svgusenode.hxx:44 +svgio/inc/svgusenode.hxx:42 svgio::svgreader::SvgUseNode maHeight class svgio::svgreader::SvgNumber svl/source/crypto/cryptosign.cxx:113 (anonymous namespace)::MessageImprint hashedMessage SECItem @@ -780,7 +780,7 @@ svx/inc/galbrws2.hxx:82 GalleryBrowser2 mxDragDropTargetHelper std::unique_ptr<GalleryDragDrop> svx/inc/sdr/overlay/overlaytools.hxx:41 drawinglayer::primitive2d::OverlayStaticRectanglePrimitive mfRotation double -svx/inc/sdr/primitive2d/sdrolecontentprimitive2d.hxx:46 +svx/inc/sdr/primitive2d/sdrolecontentprimitive2d.hxx:44 drawinglayer::primitive2d::SdrOleContentPrimitive2D mnGraphicVersion sal_uInt32 svx/source/form/dataaccessdescriptor.cxx:39 svx::ODADescriptorImpl m_bSetOutOfDate _Bool @@ -804,19 +804,19 @@ svx/source/sidebar/glow/GlowPropertyPanel.hxx:41 svx::sidebar::GlowPropertyPanel maGlowRadiusController sfx2::sidebar::ControllerItem svx/source/sidebar/glow/GlowPropertyPanel.hxx:42 svx::sidebar::GlowPropertyPanel maGlowTransparencyController sfx2::sidebar::ControllerItem -svx/source/sidebar/line/LinePropertyPanel.hxx:85 +svx/source/sidebar/line/LinePropertyPanel.hxx:83 svx::sidebar::LinePropertyPanel maStyleControl sfx2::sidebar::ControllerItem -svx/source/sidebar/line/LinePropertyPanel.hxx:86 +svx/source/sidebar/line/LinePropertyPanel.hxx:84 svx::sidebar::LinePropertyPanel maDashControl sfx2::sidebar::ControllerItem -svx/source/sidebar/line/LinePropertyPanel.hxx:88 +svx/source/sidebar/line/LinePropertyPanel.hxx:86 svx::sidebar::LinePropertyPanel maTransControl sfx2::sidebar::ControllerItem -svx/source/sidebar/line/LinePropertyPanel.hxx:89 +svx/source/sidebar/line/LinePropertyPanel.hxx:87 svx::sidebar::LinePropertyPanel maEdgeStyle sfx2::sidebar::ControllerItem -svx/source/sidebar/line/LinePropertyPanel.hxx:90 +svx/source/sidebar/line/LinePropertyPanel.hxx:88 svx::sidebar::LinePropertyPanel maCapStyle sfx2::sidebar::ControllerItem -svx/source/sidebar/lists/ListsPropertyPanel.hxx:44 +svx/source/sidebar/lists/ListsPropertyPanel.hxx:42 svx::sidebar::ListsPropertyPanel mxNumBulletDispatcher std::unique_ptr<ToolbarUnoDispatcher> -svx/source/sidebar/lists/ListsPropertyPanel.hxx:46 +svx/source/sidebar/lists/ListsPropertyPanel.hxx:44 svx::sidebar::ListsPropertyPanel mxOutlineDispatcher std::unique_ptr<ToolbarUnoDispatcher> svx/source/sidebar/paragraph/ParaPropertyPanel.hxx:79 svx::sidebar::ParaPropertyPanel mxHorzAlignDispatch std::unique_ptr<ToolbarUnoDispatcher> @@ -900,7 +900,7 @@ sw/source/core/inc/unoflatpara.hxx:134 SwXFlatParagraphIterator m_aFlatParaList std::set<css::uno::Reference<css::text::XFlatParagraph> > sw/source/core/layout/dbg_lay.cxx:132 SwImplProtocol aVars std::vector<long> -sw/source/core/table/swtable.cxx:2601 +sw/source/core/table/swtable.cxx:2602 SwTableCellInfo::Impl m_HandledTableBoxes SwTableCellInfo::Impl::TableBoxes_t sw/source/core/text/porfld.hxx:59 SwFieldPortion m_nAttrFieldType sal_uInt16 @@ -924,19 +924,19 @@ sw/source/uibase/inc/navipi.hxx:62 SwNavigationPI m_xContent1Dispatch std::unique_ptr<ToolbarUnoDispatcher> sw/source/uibase/inc/redlndlg.hxx:61 SwRedlineAcceptDlg m_aUsedSeqNo class SwRedlineDataParentSortArr -sw/source/uibase/sidebar/TableEditPanel.hxx:54 +sw/source/uibase/sidebar/TableEditPanel.hxx:52 sw::sidebar::TableEditPanel m_xInsertDispatch std::unique_ptr<ToolbarUnoDispatcher> -sw/source/uibase/sidebar/TableEditPanel.hxx:56 +sw/source/uibase/sidebar/TableEditPanel.hxx:54 sw::sidebar::TableEditPanel m_xSelectDispatch std::unique_ptr<ToolbarUnoDispatcher> -sw/source/uibase/sidebar/TableEditPanel.hxx:58 +sw/source/uibase/sidebar/TableEditPanel.hxx:56 sw::sidebar::TableEditPanel m_xRowSizingDispatch std::unique_ptr<ToolbarUnoDispatcher> -sw/source/uibase/sidebar/TableEditPanel.hxx:60 +sw/source/uibase/sidebar/TableEditPanel.hxx:58 sw::sidebar::TableEditPanel m_xColumnSizingDispatch std::unique_ptr<ToolbarUnoDispatcher> -sw/source/uibase/sidebar/TableEditPanel.hxx:62 +sw/source/uibase/sidebar/TableEditPanel.hxx:60 sw::sidebar::TableEditPanel m_xDeleteDispatch std::unique_ptr<ToolbarUnoDispatcher> -sw/source/uibase/sidebar/TableEditPanel.hxx:64 +sw/source/uibase/sidebar/TableEditPanel.hxx:62 sw::sidebar::TableEditPanel m_xSplitMergeDispatch std::unique_ptr<ToolbarUnoDispatcher> -sw/source/uibase/sidebar/TableEditPanel.hxx:66 +sw/source/uibase/sidebar/TableEditPanel.hxx:64 sw::sidebar::TableEditPanel m_xMiscDispatch std::unique_ptr<ToolbarUnoDispatcher> sw/source/uibase/sidebar/WrapPropertyPanel.hxx:74 sw::sidebar::WrapPropertyPanel mxWrapOptionsDispatch std::unique_ptr<ToolbarUnoDispatcher> @@ -1004,9 +1004,9 @@ unotools/source/config/defaultoptions.cxx:90 SvtDefaultOptions_Impl m_aWorkPath class rtl::OUString unotools/source/config/defaultoptions.cxx:91 SvtDefaultOptions_Impl m_aClassificationPath class rtl::OUString -unoxml/source/rdf/librdf_repository.cxx:470 +unoxml/source/rdf/librdf_repository.cxx:468 (anonymous namespace)::librdf_GraphResult m_pQuery const std::shared_ptr<librdf_query> -unoxml/source/rdf/librdf_repository.cxx:623 +unoxml/source/rdf/librdf_repository.cxx:621 (anonymous namespace)::librdf_QuerySelectResult m_pQuery const std::shared_ptr<librdf_query> unoxml/source/xpath/nodelist.hxx:52 XPath::CNodeList m_pXPathObj std::shared_ptr<xmlXPathObject> @@ -1014,8 +1014,6 @@ vbahelper/source/vbahelper/vbafillformat.hxx:36 ScVbaFillFormat m_nForeColor sal_Int32 vcl/inc/accel.h:33 ImplAccelEntry mpAutoAccel class Accelerator * -vcl/inc/calendar.hxx:159 - Calendar mbTravelSelect _Bool vcl/inc/driverblocklist.hxx:99 DriverBlocklist::DriverInfo maMsg class rtl::OUString vcl/inc/fontselect.hxx:61 @@ -1032,13 +1030,13 @@ vcl/inc/qt5/Qt5Frame.hxx:97 Qt5Frame m_pSalMenu class Qt5Menu * vcl/inc/qt5/Qt5Graphics.hxx:53 Qt5Graphics m_pFontCollection class PhysicalFontCollection * -vcl/inc/qt5/Qt5Instance.hxx:59 +vcl/inc/qt5/Qt5Instance.hxx:62 Qt5Instance m_pQApplication std::unique_ptr<QApplication> -vcl/inc/qt5/Qt5Instance.hxx:60 +vcl/inc/qt5/Qt5Instance.hxx:63 Qt5Instance m_pFakeArgvFreeable std::vector<FreeableCStr> -vcl/inc/qt5/Qt5Instance.hxx:61 +vcl/inc/qt5/Qt5Instance.hxx:64 Qt5Instance m_pFakeArgv std::unique_ptr<char *[]> -vcl/inc/qt5/Qt5Instance.hxx:62 +vcl/inc/qt5/Qt5Instance.hxx:65 Qt5Instance m_pFakeArgc std::unique_ptr<int> vcl/inc/salmenu.hxx:33 SalItemParams pMenu VclPtr<class Menu> @@ -1052,25 +1050,25 @@ vcl/inc/salmenu.hxx:43 SalMenuButtonItem maImage class Image vcl/inc/salmenu.hxx:44 SalMenuButtonItem maToolTipText class rtl::OUString -vcl/inc/salwtype.hxx:198 +vcl/inc/salwtype.hxx:203 SalSurroundingTextRequestEvent mnStart sal_uLong -vcl/inc/salwtype.hxx:199 +vcl/inc/salwtype.hxx:204 SalSurroundingTextRequestEvent mnEnd sal_uLong -vcl/inc/salwtype.hxx:210 +vcl/inc/salwtype.hxx:215 SalQueryCharPositionEvent mbValid _Bool -vcl/inc/salwtype.hxx:212 +vcl/inc/salwtype.hxx:217 SalQueryCharPositionEvent mbVertical _Bool -vcl/inc/salwtype.hxx:213 +vcl/inc/salwtype.hxx:218 SalQueryCharPositionEvent mnCursorBoundX long -vcl/inc/salwtype.hxx:214 +vcl/inc/salwtype.hxx:219 SalQueryCharPositionEvent mnCursorBoundY long -vcl/inc/salwtype.hxx:215 +vcl/inc/salwtype.hxx:220 SalQueryCharPositionEvent mnCursorBoundWidth long -vcl/inc/salwtype.hxx:216 +vcl/inc/salwtype.hxx:221 SalQueryCharPositionEvent mnCursorBoundHeight long -vcl/inc/salwtype.hxx:243 +vcl/inc/salwtype.hxx:248 SalInputContext mpFont rtl::Reference<LogicalFontInstance> -vcl/inc/salwtype.hxx:250 +vcl/inc/salwtype.hxx:255 SalSwipeEvent mnVelocityY double vcl/inc/scanlinewriter.hxx:36 vcl::ScanlineWriter mpCurrentScanline sal_uInt8 * @@ -1134,7 +1132,7 @@ vcl/unx/gtk3/gtk3glomenu.cxx:14 GLOMenu parent_instance const GMenuModel vcl/unx/gtk3/gtk3gtkinst.cxx:1613 in char * -vcl/unx/gtk3/gtk3gtkinst.cxx:12876 +vcl/unx/gtk3/gtk3gtkinst.cxx:13066 (anonymous namespace)::GtkInstanceComboBox m_xCustomMenuButtonHelper std::unique_ptr<CustomRenderMenuButtonHelper> vcl/unx/gtk3/gtk3hudawareness.cxx:18 (anonymous namespace)::HudAwarenessHandle connection GDBusConnection * @@ -1142,9 +1140,11 @@ vcl/unx/gtk3/gtk3hudawareness.cxx:21 (anonymous namespace)::HudAwarenessHandle notify GDestroyNotify vcl/workben/vcldemo.cxx:1748 (anonymous namespace)::DemoWin mxThread rtl::Reference<RenderThread> -writerfilter/source/dmapper/DomainMapperTableHandler.cxx:234 +writerfilter/source/dmapper/DomainMapperTableHandler.cxx:226 writerfilter::dmapper::TableInfo aTablePropertyIds std::vector<PropertyIds> -writerfilter/source/dmapper/PropertyMap.hxx:220 +writerfilter/source/dmapper/DomainMapperTableManager.hxx:42 + writerfilter::dmapper::DomainMapperTableManager m_nGridAfter sal_uInt32 +writerfilter/source/dmapper/PropertyMap.hxx:219 writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32 writerfilter/source/dmapper/SettingsTable.cxx:264 writerfilter::dmapper::SettingsTable_Impl m_sRedlineProtectionKey class rtl::OUString diff --git a/include/vcl/edit.hxx b/include/vcl/edit.hxx index fe1e12826ee4..5b733dc42ef6 100644 --- a/include/vcl/edit.hxx +++ b/include/vcl/edit.hxx @@ -68,8 +68,7 @@ private: sal_Int32 mnWidthInChars; sal_Int32 mnMaxWidthChars; sal_Unicode mcEchoChar; - bool mbModified:1, - mbInternModified:1, + bool mbInternModified:1, mbReadOnly:1, mbInsertMode:1, mbClickedInSelection:1, @@ -87,7 +86,6 @@ private: SAL_DLLPRIVATE bool ImplTruncateToMaxLen( OUString&, sal_Int32 nSelectionLen ) const; SAL_DLLPRIVATE void ImplInitEditData(); - SAL_DLLPRIVATE void ImplModified(); SAL_DLLPRIVATE OUString ImplGetText() const; SAL_DLLPRIVATE void ImplRepaint(vcl::RenderContext& rRenderContext, const tools::Rectangle& rRectangle); SAL_DLLPRIVATE void ImplInvalidateOrRepaint(); diff --git a/include/vcl/toolkit/button.hxx b/include/vcl/toolkit/button.hxx index 1f47597397a2..cb581a407c59 100644 --- a/include/vcl/toolkit/button.hxx +++ b/include/vcl/toolkit/button.hxx @@ -86,14 +86,8 @@ private: tools::Rectangle maStateRect; tools::Rectangle maMouseRect; TriState meState; - TriState meSaveValue; bool mbTriState; Link<CheckBox&,void> maToggleHdl; - // when mbLegacyNoTextAlign is set then the old behaviour where - // the WB_LEFT, WB_RIGHT & WB_CENTER affect the image placement - // occurs, otherwise the image ( checkbox box ) is placed - // to the left or right ( depending on RTL or LTR settings ) - bool mbLegacyNoTextAlign; SAL_DLLPRIVATE void ImplInitCheckBoxData(); SAL_DLLPRIVATE static WinBits ImplInitStyle( const vcl::Window* pPrevWindow, WinBits nStyle ); SAL_DLLPRIVATE void ImplInitSettings( bool bBackground ); diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx index 8d9b269ea823..b58b8d9fe019 100644 --- a/vcl/source/control/button.cxx +++ b/vcl/source/control/button.cxx @@ -2858,7 +2858,6 @@ FactoryFunction RadioButton::GetUITestFactory() const void CheckBox::ImplInitCheckBoxData() { meState = TRISTATE_FALSE; - meSaveValue = TRISTATE_FALSE; mbTriState = false; } @@ -3022,12 +3021,7 @@ void CheckBox::ImplDraw( OutputDevice* pDev, DrawFlags nDrawFlags, } else { - if ( mbLegacyNoTextAlign && ( nWinStyle & WB_CENTER ) ) - rStateRect.SetLeft( rPos.X()+((rSize.Width()-rImageSize.Width())/2) ); - else if ( mbLegacyNoTextAlign && ( nWinStyle & WB_RIGHT ) ) - rStateRect.SetLeft( rPos.X()+rSize.Width()-rImageSize.Width() ); - else - rStateRect.SetLeft( rPos.X() ); + rStateRect.SetLeft( rPos.X() ); if ( nWinStyle & WB_VCENTER ) rStateRect.SetTop( rPos.Y()+((rSize.Height()-rImageSize.Height())/2) ); else if ( nWinStyle & WB_BOTTOM ) @@ -3087,7 +3081,7 @@ void CheckBox::ImplCheck() } CheckBox::CheckBox( vcl::Window* pParent, WinBits nStyle ) : - Button( WindowType::CHECKBOX ), mbLegacyNoTextAlign( false ) + Button( WindowType::CHECKBOX ) { ImplInitCheckBoxData(); ImplInit( pParent, nStyle ); diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx index 11121241868c..6ecbb32689fd 100644 --- a/vcl/source/control/edit.cxx +++ b/vcl/source/control/edit.cxx @@ -259,7 +259,6 @@ void Edit::ImplInitEditData() mnMaxTextLen = EDIT_NOLIMIT; mnWidthInChars = -1; mnMaxWidthChars = -1; - mbModified = false; mbInternModified = false; mbReadOnly = false; mbInsertMode = true; @@ -355,12 +354,6 @@ bool Edit::IsCharInput( const KeyEvent& rKeyEvent ) !rKeyEvent.GetKeyCode().IsMod1() ); } -void Edit::ImplModified() -{ - mbModified = true; - Modify(); -} - void Edit::ApplySettings(vcl::RenderContext& rRenderContext) { Control::ApplySettings(rRenderContext); @@ -1362,7 +1355,7 @@ void Edit::MouseButtonUp( const MouseEvent& rMEvt ) { css::uno::Reference<css::datatransfer::clipboard::XClipboard> aSelection(Window::GetPrimarySelection()); ImplPaste( aSelection ); - ImplModified(); + Modify(); } } @@ -1408,7 +1401,7 @@ bool Edit::ImplHandleKeyEvent( const KeyEvent& rKEvt ) if ( !mbReadOnly && maSelection.Len() && !mbPassword ) { Cut(); - ImplModified(); + Modify(); bDone = true; } } @@ -1466,7 +1459,7 @@ bool Edit::ImplHandleKeyEvent( const KeyEvent& rKEvt ) if ( !aChars.isEmpty() ) { ImplInsertText( aChars ); - ImplModified(); + Modify(); } bDone = true; } @@ -1651,7 +1644,7 @@ bool Edit::ImplHandleKeyEvent( const KeyEvent& rKEvt ) sal_Int32 nOldLen = maText.getLength(); ImplDelete( maSelection, nDel, nMode ); if ( maText.getLength() != nOldLen ) - ImplModified(); + Modify(); bDone = true; } } @@ -1696,7 +1689,7 @@ bool Edit::ImplHandleKeyEvent( const KeyEvent& rKEvt ) } if ( mbInternModified ) - ImplModified(); + Modify(); return bDone; } @@ -1985,12 +1978,12 @@ void Edit::Command( const CommandEvent& rCEvt ) if (sCommand == "undo") { Undo(); - ImplModified(); + Modify(); } else if (sCommand == "cut") { Cut(); - ImplModified(); + Modify(); } else if (sCommand == "copy") { @@ -1999,12 +1992,12 @@ void Edit::Command( const CommandEvent& rCEvt ) else if (sCommand == "paste") { Paste(); - ImplModified(); + Modify(); } else if (sCommand == "delete") { DeleteSelected(); - ImplModified(); + Modify(); } else if (sCommand == "selectall") { @@ -2017,7 +2010,7 @@ void Edit::Command( const CommandEvent& rCEvt ) if (!aChars.isEmpty()) { ImplInsertText( aChars ); - ImplModified(); + Modify(); } } pPopup.clear(); @@ -2036,7 +2029,7 @@ void Edit::Command( const CommandEvent& rCEvt ) mpIMEInfos.reset(); SetInsertMode(bInsertMode); - ImplModified(); + Modify(); Invalidate(); @@ -2585,18 +2578,10 @@ void Edit::SetPlaceholderText( const OUString& rStr ) void Edit::SetModifyFlag() { - if ( mpSubEdit ) - mpSubEdit->mbModified = true; - else - mbModified = true; } void Edit::ClearModifyFlag() { - if ( mpSubEdit ) - mpSubEdit->mbModified = false; - else - mbModified = false; } void Edit::SetSubEdit(Edit* pEdit) @@ -2792,7 +2777,7 @@ void Edit::dragDropEnd( const css::datatransfer::dnd::DragSourceDropEvent& rDSDE } } ImplDelete( aSel, EDIT_DEL_RIGHT, EDIT_DELMODE_SIMPLE ); - ImplModified(); + Modify(); } ImplHideDDCursor(); @@ -2833,7 +2818,7 @@ void Edit::drop( const css::datatransfer::dnd::DropTargetDropEvent& rDTDE ) aData >>= aText; ImplInsertText( aText ); bChanges = true; - ImplModified(); + Modify(); } } _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits