sw/qa/uitest/writer_tests3/hyperlinkdialog.py | 2 --
1 file changed, 2 deletions(-)
New commits:
commit bc16f329b7aadbc429be10f0b0b1e90b6e9545ae
Author: Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Sat Aug 1 11:08:36 2020 +0200
Commit: Stephan Bergmann <sberg...@redhat.com>
CommitDate: Sat Aug 1 13:21:29 2020 +0200
Remove the wait_until_property_is_updated calls again
They had been added with 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest :
Avoid any timing issue in test_insert_hyperlink" and
1cdda798def040fe778348061c0e18b28aa0e6bd "Further timing issues with
test_insert_hyperlink", but 63049e98a659290229d3356e76d49cea44575011
"Reliably
set up controls of hyperlink dialog in constructor" now argues that they are
probably not necessary after all: For one, they had presumably been added
as
blind fixes, without actually understanding what's going on (that's at least
true for the second, monkey-see-monkey-do one by me). And for another,
after I
had seen their failures frequently with my local ASan+UBSan Linux build, I
haven't seen them at all in lots of executions of that test with the
63049e98a659290229d3356e76d49cea44575011 fix included.
So lets assume that those "magic" calls are indeed not necessary after all.
If
we run into trouble again, they can be added back.
Change-Id: I6f4417c9fd243758a03a4de05270f342e7147d27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99931
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
diff --git a/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
b/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
index 6e3285b5f3ba..5b414242babc 100644
--- a/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
+++ b/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
@@ -63,12 +63,10 @@ class HyperlinkDialog(UITestCase):
xtarget = xDialog.getChild("target")
xtarget.executeAction("TYPE", mkPropertyValues({"TEXT":
"http://www.libreoffice.org/"}))
- self.ui_test.wait_until_property_is_updated(xtarget, "Text",
"http://www.libreoffice.org/";)
self.assertEqual(get_state_as_dict(xtarget)["Text"],
"http://www.libreoffice.org/";)
xindication = xDialog.getChild("indication")
xindication.executeAction("TYPE", mkPropertyValues({"TEXT": "link"}))
- self.ui_test.wait_until_property_is_updated(xindication, "Text",
"link")
self.assertEqual(get_state_as_dict(xindication)["Text"], "link")
xok = xDialog.getChild("ok")
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
