On Wed, Apr 11, 2012 at 01:05:01AM +0200, David Ostrovsky wrote: > Hi David, > > thank you for your comments. Here is another try. > See also my comments bellow. If there still any issues, just let me > know ... > and I will give it another try ;-)
This seems more-or-less correct. I fixed the few remaining issues myself. > > David > > On 08.04.2012 10:29, David Tardon wrote: > >On Wed, Apr 04, 2012 at 06:33:44AM +0200, David Tardon wrote: > >>On Wed, Apr 04, 2012 at 12:50:47AM +0200, David Ostrovsky wrote: > >>>Hi David, > >>> > >>>thank you for your comments. Here is another try. > >Hi, > > > >I looked at the patch and there are still some problems to correct. I > >could easily do it myself, but I think that you can learn more this way. > >So: > > > >1. registercomponent sets APP1RPATH=UREBIN. That means the executable > > should be registered in UREBIN layer, instead of NONE, in gbuild. > > (Not knowing that is not your fault--I doubt this is documented > > anywhere...) > done. > > > >2. The executables should not be built for IOS. > done. > >3. unoexe is actually built on IOS, but as a static library. > done. I don't have mac out there to try. > But I commented MACOSX condition out and tried to built it on my > Linux machine. > Then I saw, that Repository.mk should be updated. IOS is not MACOSX .-) > With staticLibrary I'm using > > $(eval $(call gb_StaticLibrary_use_api,uno,\ > udkapi \ > )) > > and not this: > $(eval $(call gb_StaticLibrary_use_internal_comprehensive_api,uno,\ > udkapi \ > )) I added the _use_internal*api functions to StaticLibrary too (I should have done that before, sorry for that). > > > >4. regsingleton sets an additional compiler flag for MSC. You can use > > gb_Executable_add_cxxflags to do that in gbuild land. > done, > actually there are two conditions: > 1. without debug > 2. with MSC compiler > I hope i cathed the right one, please correct me, if I'm wrong. Yes, you did. > >5. re gb_Executable_add_api: you should use > > gb_Executable_use_internal_comprehensive_api for these > > executables/libraries that have NO_OFFUH=TRUE in makefile.mk . > done, > only sp2bv and staticLibrary use the old version. D. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice