loleaflet/src/map/handler/Map.Keyboard.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 536ccdd6017673d33f8a18f83c6ee2cf321e8786
Author: Tor Lillqvist <t...@collabora.com>
AuthorDate: Mon Aug 31 12:34:41 2020 +0300
Commit: Tor Lillqvist <t...@collabora.com>
CommitDate: Mon Aug 31 12:13:56 2020 +0200
Make comments match reality
"Private" and "public" have no meaning in JavaScript as far as I know,
there are only naming conventions. And we keep using properties and
functions intended to be "private" (have names that start with an
underscore) quite freely across source files and classes anyway.
Also, the names in the comments were wrong.
Change-Id: Ib5172c26be8818cb261dbe7d08d1c3245ff64af8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101699
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
Reviewed-by: Tor Lillqvist <t...@collabora.com>
diff --git a/loleaflet/src/map/handler/Map.Keyboard.js
b/loleaflet/src/map/handler/Map.Keyboard.js
index 852ab07fb..c3f578612 100644
--- a/loleaflet/src/map/handler/Map.Keyboard.js
+++ b/loleaflet/src/map/handler/Map.Keyboard.js
@@ -229,8 +229,8 @@ L.Map.Keyboard = L.Handler.extend({
return this.keymap[keyCode] || keyCode;
},
- // Private onKeyDown - called only as a DOM event handler
- // Calls the public onKeyDown(), but only if the event doesn't have
+ // _onKeyDown - called only as a DOM event handler
+ // Calls _handleKeyEvent(), but only if the event doesn't have
// a charCode property (set to something different than 0) - that
ignores
// any 'beforeinput', 'keypress' and 'input' events that would add
// printable characters. Those are handled by TextInput.js.
@@ -245,7 +245,7 @@ L.Map.Keyboard = L.Handler.extend({
// _handleKeyEvent - checks if the given keyboard event shall trigger
// a message to loolwsd, and calls the given keyEventFn(type, charcode,
keycode)
// callback if so.
- // Called from private _onKeyDown
+ // Called from _onKeyDown
_handleKeyEvent: function (ev, keyEventFn) {
this._map.notifyActive();
if (this._map.slideShow && this._map.slideShow.fullscreen) {
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
