Hi, Thanks for pushing the patch. I will try to keep my build tree more up to date in the future.
On Tue, Apr 10, 2012 at 18:31, Kohei Yoshida <kohei.yosh...@gmail.com> wrote: > Hi Albert, > > On Mon, Apr 9, 2012 at 6:31 PM, Albert Thuswaldner > <albert.thuswald...@gmail.com> wrote: >> Hi Kohei, >> As said back in February: >> http://lists.freedesktop.org/archives/libreoffice/2012-February/027009.html >> here is a follow-on patch that "groups" the formula options in the >> same fashion as the print options. > > Reviewed it, and pushed to master with some minor modifications. > > What I modified are: > > 1) have the assignment operator return a non-const reference of "this" > object instead of const reference. > 2) have the equality and non-equality operators of ScFormulaOptions > return bool instead of int. > > Regarding 2), I didn't modify the return type of operator== for > ScTpFormulaItem because it was a virtual function. > I was happily unaware of those things. ;) > Another nice work, Albert. Much appreciated. :-) Thanks. Here is a small follow-up patch that removes some unneeded includes from tpformula.hxx, which I previously overlooked. /Albert
From aad551d5c19bab4335d01b1c44a6fde7c91211cf Mon Sep 17 00:00:00 2001 From: Albert Thuswaldner <albert.thuswald...@gmail.com> Date: Thu, 12 Apr 2012 01:01:06 +0200 Subject: [PATCH] removed unused includes in tpformula.hxx --- sc/source/ui/inc/tpformula.hxx | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/sc/source/ui/inc/tpformula.hxx b/sc/source/ui/inc/tpformula.hxx index 033f61d..c547849 100644 --- a/sc/source/ui/inc/tpformula.hxx +++ b/sc/source/ui/inc/tpformula.hxx @@ -35,14 +35,6 @@ #include <vcl/edit.hxx> #include <vcl/button.hxx> -#include <memory> - -#include <boost/shared_ptr.hpp> - -class ScAppOptions; -class SfxItemSet; -class Window; - class ScTpFormulaOptions : public SfxTabPage { public: @@ -50,7 +42,6 @@ public: static SfxTabPage* Create (Window* pParent, const SfxItemSet& rCoreSet); -// static USHORT* GetRanges(); virtual sal_Bool FillItemSet(SfxItemSet& rCoreSet); virtual void Reset( const SfxItemSet& rCoreSet ); virtual int DeactivatePage(SfxItemSet* pSet = NULL); -- 1.7.3.4
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice