On Wednesday 07 of October 2020, Noel Grandin wrote: > On Wed, 7 Oct 2020 at 16:51, Luboš Luňák <l.lu...@collabora.com> wrote: > > On Tuesday 06 of October 2020, Noel Grandin wrote: > > Does it really need to be this extensive though? E.g. VCL should be more > > or > > less safe from this, I think trying any drawing with >32bit sizes is > > simply > > not going to work one way or another. > > We extensively use shared types like tool::Rectangle in sc.
Yes, I know, but the question was more like how many like these are there. > > Also, how realistic of a solution would be to compile with the > > undefined-behaviour sanitizer and make it fail on overflows as a way to > > get a > > decent enough coverage of the problematic areas? > > If you can get that working under Windows, sure, that could help. The Clang/UBSan page says it works on Windows (I'm not going to try that myself though). On Wednesday 07 of October 2020, Thorsten Behrens wrote: > Noel Grandin wrote: > > We extensively use shared types like tool::Rectangle in sc. > > But we don't do spreadsheet math with them, no? No, but we do math to show spreadsheet math with them. -- Luboš Luňák l.lu...@collabora.com _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
